You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "HyukjinKwon (via GitHub)" <gi...@apache.org> on 2023/08/21 02:59:51 UTC
[GitHub] [spark] HyukjinKwon commented on a diff in pull request #42541: Spark 44854
HyukjinKwon commented on code in PR #42541:
URL: https://github.com/apache/spark/pull/42541#discussion_r1299533479
##########
python/pyspark/sql/types.py:
##########
@@ -442,7 +442,7 @@ def needConversion(self) -> bool:
def toInternal(self, dt: datetime.timedelta) -> Optional[int]:
if dt is not None:
- return (math.floor(dt.total_seconds()) * 1000000) + dt.microseconds
Review Comment:
BTW, do you know why and how it adds one more second though?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org