You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2017/04/07 03:20:52 UTC
[kudu-CR] [security-faults-itest] fix test flakiness
Alexey Serbin has uploaded a new change for review.
http://gerrit.cloudera.org:8080/6586
Change subject: [security-faults-itest] fix test flakiness
......................................................................
[security-faults-itest] fix test flakiness
When running the security-faults-itest on a slow VM with other
activities in parallel, it might take up to 8 seconds to start a master.
So, bumping the ticket TTL to higher value so Kudu cluster with 3
masters finishes starting up when initially acquired tickets are valid.
Also, updated Raft parameters interval to speed up leader election.
Change-Id: I132426ee37358a228cf3f5d1fef9e9ec08610b16
---
M src/kudu/integration-tests/security-faults-itest.cc
1 file changed, 12 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/86/6586/1
--
To view, visit http://gerrit.cloudera.org:8080/6586
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I132426ee37358a228cf3f5d1fef9e9ec08610b16
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
[kudu-CR] [security-faults-itest] fix test flakiness
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change.
Change subject: [security-faults-itest] fix test flakiness
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/6586/1/src/kudu/integration-tests/security-faults-itest.cc
File src/kudu/integration-tests/security-faults-itest.cc:
PS1, Line 55: #if defined(ADDRESS_SANITIZER) || defined(THREAD_SANITIZER)
: : krb_lifetime_seconds_(64),
: #else
: : krb_lifetime_seconds_(32),
: #endif
> Any particular reason not to use 64 universally?
Nothing except for shorter test run-time: I started it with just 8 seconds without AllowSlowTests(), but due to the nature of the test and necessity to run at slow VMs it turned into 32.
It seems now I can put 64 universally -- it's a good idea.
--
To view, visit http://gerrit.cloudera.org:8080/6586
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I132426ee37358a228cf3f5d1fef9e9ec08610b16
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: Yes
[kudu-CR] [security-faults-itest] fix test flakiness
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged.
Change subject: [security-faults-itest] fix test flakiness
......................................................................
[security-faults-itest] fix test flakiness
When running the security-faults-itest on a slow VM with other
activities in parallel, it might take up to 8 seconds to start a master.
So, bumping the ticket TTL to higher value so Kudu cluster with 3
masters finishes starting up when initially acquired tickets are valid.
Also, updated Raft parameters interval to speed up leader election.
Change-Id: I132426ee37358a228cf3f5d1fef9e9ec08610b16
Reviewed-on: http://gerrit.cloudera.org:8080/6586
Tested-by: Kudu Jenkins
Reviewed-by: Adar Dembo <ad...@cloudera.com>
---
M src/kudu/integration-tests/security-faults-itest.cc
1 file changed, 11 insertions(+), 4 deletions(-)
Approvals:
Adar Dembo: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/6586
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I132426ee37358a228cf3f5d1fef9e9ec08610b16
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] [security-faults-itest] fix test flakiness
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change.
Change subject: [security-faults-itest] fix test flakiness
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/6586/1/src/kudu/integration-tests/security-faults-itest.cc
File src/kudu/integration-tests/security-faults-itest.cc:
PS1, Line 55: #if defined(ADDRESS_SANITIZER) || defined(THREAD_SANITIZER)
: : krb_lifetime_seconds_(64),
: #else
: : krb_lifetime_seconds_(32),
: #endif
Any particular reason not to use 64 universally?
--
To view, visit http://gerrit.cloudera.org:8080/6586
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I132426ee37358a228cf3f5d1fef9e9ec08610b16
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: Yes
[kudu-CR] [security-faults-itest] fix test flakiness
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change.
Change subject: [security-faults-itest] fix test flakiness
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/6586
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I132426ee37358a228cf3f5d1fef9e9ec08610b16
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No
[kudu-CR] [security-faults-itest] fix test flakiness
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/6586
to look at the new patch set (#2).
Change subject: [security-faults-itest] fix test flakiness
......................................................................
[security-faults-itest] fix test flakiness
When running the security-faults-itest on a slow VM with other
activities in parallel, it might take up to 8 seconds to start a master.
So, bumping the ticket TTL to higher value so Kudu cluster with 3
masters finishes starting up when initially acquired tickets are valid.
Also, updated Raft parameters interval to speed up leader election.
Change-Id: I132426ee37358a228cf3f5d1fef9e9ec08610b16
---
M src/kudu/integration-tests/security-faults-itest.cc
1 file changed, 11 insertions(+), 4 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/86/6586/2
--
To view, visit http://gerrit.cloudera.org:8080/6586
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I132426ee37358a228cf3f5d1fef9e9ec08610b16
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>