You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pivot.apache.org by "Michael Allman (JIRA)" <ji...@apache.org> on 2010/07/28 10:19:17 UTC

[jira] Created: (PIVOT-581) org.apache.pivot.wtk.content.ListViewItemRenderer does not call toString(Object) when rendering

org.apache.pivot.wtk.content.ListViewItemRenderer does not call toString(Object) when rendering
-----------------------------------------------------------------------------------------------

                 Key: PIVOT-581
                 URL: https://issues.apache.org/jira/browse/PIVOT-581
             Project: Pivot
          Issue Type: Bug
          Components: wtk
    Affects Versions: 1.5
            Reporter: Michael Allman


The render() method of ListViewItemRenderer does not use the renderer's toString(Object) method.  This makes overriding the latter method in a subclass useless.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (PIVOT-581) org.apache.pivot.wtk.content.ListViewItemRenderer does not call toString(Object) when rendering

Posted by "Greg Brown (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/PIVOT-581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12893157#action_12893157 ] 

Greg Brown commented on PIVOT-581:
----------------------------------

Calling label.setText() is valid. You could also pass a different item value to the base render() method.


> org.apache.pivot.wtk.content.ListViewItemRenderer does not call toString(Object) when rendering
> -----------------------------------------------------------------------------------------------
>
>                 Key: PIVOT-581
>                 URL: https://issues.apache.org/jira/browse/PIVOT-581
>             Project: Pivot
>          Issue Type: Bug
>          Components: wtk
>    Affects Versions: 1.5
>            Reporter: Michael Allman
>
> The render() method of ListViewItemRenderer does not use the renderer's toString(Object) method.  This makes overriding the latter method in a subclass useless.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (PIVOT-581) org.apache.pivot.wtk.content.ListViewItemRenderer does not call toString(Object) when rendering

Posted by "Michael Allman (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/PIVOT-581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12893153#action_12893153 ] 

Michael Allman commented on PIVOT-581:
--------------------------------------

Okay.  As a workaround, I just override the render method and called label.setText() after super.

Anyway, the purpose and utility of the toString(Object) method could be clarified in the documentation.  Otherwise people like me won't have a clue what it's there for.

Cheers.

> org.apache.pivot.wtk.content.ListViewItemRenderer does not call toString(Object) when rendering
> -----------------------------------------------------------------------------------------------
>
>                 Key: PIVOT-581
>                 URL: https://issues.apache.org/jira/browse/PIVOT-581
>             Project: Pivot
>          Issue Type: Bug
>          Components: wtk
>    Affects Versions: 1.5
>            Reporter: Michael Allman
>
> The render() method of ListViewItemRenderer does not use the renderer's toString(Object) method.  This makes overriding the latter method in a subclass useless.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (PIVOT-581) org.apache.pivot.wtk.content.ListViewItemRenderer does not call toString(Object) when rendering

Posted by "Greg Brown (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/PIVOT-581?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Greg Brown resolved PIVOT-581.
------------------------------

    Resolution: Not A Problem

render() is used to draw the list item on the screen. toString() is used to support keyboard navigation.


> org.apache.pivot.wtk.content.ListViewItemRenderer does not call toString(Object) when rendering
> -----------------------------------------------------------------------------------------------
>
>                 Key: PIVOT-581
>                 URL: https://issues.apache.org/jira/browse/PIVOT-581
>             Project: Pivot
>          Issue Type: Bug
>          Components: wtk
>    Affects Versions: 1.5
>            Reporter: Michael Allman
>
> The render() method of ListViewItemRenderer does not use the renderer's toString(Object) method.  This makes overriding the latter method in a subclass useless.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (PIVOT-581) org.apache.pivot.wtk.content.ListViewItemRenderer does not call toString(Object) when rendering

Posted by "Michael Allman (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/PIVOT-581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12893169#action_12893169 ] 

Michael Allman commented on PIVOT-581:
--------------------------------------

Yeah, just passing in the string value I want to render is cleaner.

> org.apache.pivot.wtk.content.ListViewItemRenderer does not call toString(Object) when rendering
> -----------------------------------------------------------------------------------------------
>
>                 Key: PIVOT-581
>                 URL: https://issues.apache.org/jira/browse/PIVOT-581
>             Project: Pivot
>          Issue Type: Bug
>          Components: wtk
>    Affects Versions: 1.5
>            Reporter: Michael Allman
>
> The render() method of ListViewItemRenderer does not use the renderer's toString(Object) method.  This makes overriding the latter method in a subclass useless.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.