[GitHub] [ignite] nizhikov commented on a change in pull request #6907: IGNITE-11723: IgniteSpark integration should support skipStore option for internal dataStreamer (IgniteRdd and Ignite DataFrame)

[GitBox <gi...@apache.org>]

nizhikov commented on a change in pull request #6907: IGNITE-11723: IgniteSpark integration should support skipStore option for internal dataStreamer (IgniteRdd and Ignite DataFrame)
URL: https://github.com/apache/ignite/pull/6907#discussion_r330016470
 
 

 ##########
 File path: modules/spark/src/test/java/org/apache/ignite/spark/JavaEmbeddedIgniteRDDSelfTest.java
 ##########
 @@ -150,6 +169,59 @@ public void testStoreDataToIgnite() throws Exception {
         }
     }
 
+    /**
+     * @throws Exception If failed.
+     */
+    @Test
+    public void testStoreDataToIgniteWithEnabledOptionSkipStore() throws Exception {
+        storeMap = new ConcurrentHashMap<>();
+        store = new TestStore();
+
+        JavaSparkContext sc = createContext();
+
+        JavaIgniteContext<Integer, Integer> ic = null;
+
+        try {
+            ic = new JavaIgniteContext<>(sc, new IgniteConfigProvider(), false);
+
+            Ignite ignite = ic.ignite();
+
+            IgniteCache<Integer, Integer> cache = ignite.cache(PARTITIONED_CACHE_NAME);
+
+            // 1000 entries in store; 1000 entries in cache
+            for (int i = 0; i < 1000; i++)
+                storeMap.put(i, i);
+
+            // 1000 entries in store and cache; 1000 another entries in cache writing to store
+            ic.fromCache(PARTITIONED_CACHE_NAME)
+                .savePairs(sc.parallelize(F.range(1000, 2000), GRID_CNT).mapToPair(SIMPLE_FUNCTION), true, false);
+
+            // check 2000 entries in store
 
 Review comment:
   Nit: The sentence should start with the capital letter and ends with the dot.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services