You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by GitBox <gi...@apache.org> on 2022/03/04 12:37:02 UTC
[GitHub] [solr] janhoy opened a new pull request #725: SOLR-16075 ShowFile handler should validate that files param is strictly relative to instance dir in standalone mode
janhoy opened a new pull request #725:
URL: https://github.com/apache/solr/pull/725
The /admin/file handler is not used for other tasks than displaying files in the same core/collection config. Aligning with how this is done when in cloud mode.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] janhoy edited a comment on pull request #725: SOLR-16075 ShowFile handler should validate that files param is strictly relative to instance dir in standalone mode
Posted by GitBox <gi...@apache.org>.
janhoy edited a comment on pull request #725:
URL: https://github.com/apache/solr/pull/725#issuecomment-1059259268
> I like seeing spotless failing on the code formatting ;-). Though, I think the format that you had is a bit nicer to read then what Spotless wants, but regardless, I love that we will have more consistency in formatting.
I installed [an IntelliJ plugin to apply Spotless](https://plugins.jetbrains.com/plugin/18321-spotless-gradle) on current editor file and assigned it to a shortcut. Would be nice if it could be triggered on save as well...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] janhoy commented on pull request #725: SOLR-16075 ShowFile handler should validate that files param is strictly relative to instance dir in standalone mode
Posted by GitBox <gi...@apache.org>.
janhoy commented on pull request #725:
URL: https://github.com/apache/solr/pull/725#issuecomment-1059259268
> I like seeing spotless failing on the code formatting ;-). Though, I think the format that you had is a bit nicer to read then what Spotless wants, but regardless, I love that we will have more consistency in formatting.
I installed an IntelliJ plugin to apply Spotless on current editor file and assigned it to a shortcut. Would be nice if it could be triggered on save as well...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] janhoy merged pull request #725: SOLR-16075 ShowFile handler should validate that files param is strictly relative to instance dir in standalone mode
Posted by GitBox <gi...@apache.org>.
janhoy merged pull request #725:
URL: https://github.com/apache/solr/pull/725
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] epugh commented on pull request #725: SOLR-16075 ShowFile handler should validate that files param is strictly relative to instance dir in standalone mode
Posted by GitBox <gi...@apache.org>.
epugh commented on pull request #725:
URL: https://github.com/apache/solr/pull/725#issuecomment-1059176249
I like seeing spotless failing on the code formatting ;-). Though, I think the format that you had is a bit nicer to read then what Spotless wants, but regardless, I love that we will have more consistency in formatting.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org