You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Thomas Rampelberg <th...@saunter.org> on 2014/01/11 00:49:06 UTC
Review Request 16798: Updated to bootstrap-3.0.3.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16798/
-----------------------------------------------------------
Review request for mesos.
Repository: mesos-git
Description
-------
Updated to bootstrap-3.0.3.
Diffs
-----
src/webui/master/static/browse.html fe8be009fc548d7b0ff62032ab284fc19e3ea2c7
src/webui/master/static/css/bootstrap-2.3.2.min.css b6428e695860151f82076e87810fe2d133339c2a
src/webui/master/static/css/bootstrap-3.0.3.min.css PRE-CREATION
src/webui/master/static/css/bootstrap-responsive-2.3.2.min.css f4ede63f32e2ec803876a38efac05dd49acc4684
src/webui/master/static/framework.html 72e14dfb58895e43a10f10c139a983a78b3e8878
src/webui/master/static/frameworks.html 39e7883ffe001ff33ed1b35108c893fa8ff1f92d
src/webui/master/static/home.html fb3a38e94c30487c9b7e50c65c73b7af29999c3f
src/webui/master/static/index.html 7133ecdc77650cd31f9a80edfe2d190935f94846
src/webui/master/static/js/ui-bootstrap-tpls-0.7.0.js 08c2b78cb5177cded00f742eb7f35aa0f9e37baf
src/webui/master/static/js/ui-bootstrap-tpls-0.7.0.min.js d2da4e20ebd5bb5b6f70fc785ff42cf3c2e7e32c
src/webui/master/static/js/ui-bootstrap-tpls-0.9.0.min.js PRE-CREATION
src/webui/master/static/offers.html 215d65e1ad30fb0df06bcf05cec797d60672ec66
src/webui/master/static/slave.html f30d914e4b43b5d4579c52053f9c0e04089a3adf
src/webui/master/static/slave_executor.html 519847c0de077717c88c4d35804ad40d339d4246
src/webui/master/static/slave_framework.html 947bab12eec8c3be5c3893b873b4b6378c8dcbbb
src/webui/master/static/slaves.html ef5b66290e65408312dcf1e59221ee9517b37203
Diff: https://reviews.apache.org/r/16798/diff/
Testing
-------
Thanks,
Thomas Rampelberg
Re: Review Request 16798: Updated to bootstrap-3.0.3.
Posted by Ross Allen <ro...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16798/#review31567
-----------------------------------------------------------
src/webui/master/static/home.html
<https://reviews.apache.org/r/16798/#comment60086>
Could this be an <ol> too?
src/webui/master/static/index.html
<https://reviews.apache.org/r/16798/#comment60088>
We can drop the HTML comments.
src/webui/master/static/index.html
<https://reviews.apache.org/r/16798/#comment60087>
I think you still want a "container" here to keep the content of the navbar the same width as the content of the rest of the page.
- Ross Allen
On Jan. 11, 2014, 12:18 a.m., Thomas Rampelberg wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16798/
> -----------------------------------------------------------
>
> (Updated Jan. 11, 2014, 12:18 a.m.)
>
>
> Review request for mesos and Ross Allen.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Updated to bootstrap-3.0.3.
>
> Review: http://reviews.apache.org/r/16798
>
>
> Diffs
> -----
>
> src/webui/master/static/browse.html fe8be009fc548d7b0ff62032ab284fc19e3ea2c7
> src/webui/master/static/css/bootstrap-2.3.2.min.css b6428e695860151f82076e87810fe2d133339c2a
> src/webui/master/static/css/bootstrap-3.0.3.min.css PRE-CREATION
> src/webui/master/static/css/bootstrap-responsive-2.3.2.min.css f4ede63f32e2ec803876a38efac05dd49acc4684
> src/webui/master/static/framework.html 72e14dfb58895e43a10f10c139a983a78b3e8878
> src/webui/master/static/frameworks.html 39e7883ffe001ff33ed1b35108c893fa8ff1f92d
> src/webui/master/static/home.html fb3a38e94c30487c9b7e50c65c73b7af29999c3f
> src/webui/master/static/index.html 7133ecdc77650cd31f9a80edfe2d190935f94846
> src/webui/master/static/js/ui-bootstrap-tpls-0.7.0.js 08c2b78cb5177cded00f742eb7f35aa0f9e37baf
> src/webui/master/static/js/ui-bootstrap-tpls-0.7.0.min.js d2da4e20ebd5bb5b6f70fc785ff42cf3c2e7e32c
> src/webui/master/static/js/ui-bootstrap-tpls-0.9.0.min.js PRE-CREATION
> src/webui/master/static/offers.html 215d65e1ad30fb0df06bcf05cec797d60672ec66
> src/webui/master/static/slave.html f30d914e4b43b5d4579c52053f9c0e04089a3adf
> src/webui/master/static/slave_executor.html 519847c0de077717c88c4d35804ad40d339d4246
> src/webui/master/static/slave_framework.html 947bab12eec8c3be5c3893b873b4b6378c8dcbbb
> src/webui/master/static/slaves.html ef5b66290e65408312dcf1e59221ee9517b37203
>
> Diff: https://reviews.apache.org/r/16798/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Thomas Rampelberg
>
>
Re: Review Request 16798: Updated to bootstrap-3.0.3.
Posted by Ross Allen <ro...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16798/#review31627
-----------------------------------------------------------
configure.ac
<https://reviews.apache.org/r/16798/#comment60304>
Was this a bad rebase? It looks like this shouldn't be part of this change.
- Ross Allen
On Jan. 13, 2014, 6:07 p.m., Thomas Rampelberg wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16798/
> -----------------------------------------------------------
>
> (Updated Jan. 13, 2014, 6:07 p.m.)
>
>
> Review request for mesos and Ross Allen.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Updated to bootstrap-3.0.3.
>
> Review: http://reviews.apache.org/r/16798
>
>
> Diffs
> -----
>
> configure.ac 18d9730394d6f1b2f1006d1db0ab814c595801d9
> src/Makefile.am ef707706315911c73e12c024b8bb38bbf5487621
> src/slave/paths.hpp b1a56a346ca84e7e71c31386602264c5097ef1cf
> src/webui/master/static/browse.html fe8be009fc548d7b0ff62032ab284fc19e3ea2c7
> src/webui/master/static/css/bootstrap-2.3.2.min.css b6428e695860151f82076e87810fe2d133339c2a
> src/webui/master/static/css/bootstrap-3.0.3.min.css PRE-CREATION
> src/webui/master/static/css/bootstrap-responsive-2.3.2.min.css f4ede63f32e2ec803876a38efac05dd49acc4684
> src/webui/master/static/framework.html 72e14dfb58895e43a10f10c139a983a78b3e8878
> src/webui/master/static/frameworks.html 39e7883ffe001ff33ed1b35108c893fa8ff1f92d
> src/webui/master/static/home.html fb3a38e94c30487c9b7e50c65c73b7af29999c3f
> src/webui/master/static/index.html 7133ecdc77650cd31f9a80edfe2d190935f94846
> src/webui/master/static/js/ui-bootstrap-tpls-0.7.0.js 08c2b78cb5177cded00f742eb7f35aa0f9e37baf
> src/webui/master/static/js/ui-bootstrap-tpls-0.7.0.min.js d2da4e20ebd5bb5b6f70fc785ff42cf3c2e7e32c
> src/webui/master/static/js/ui-bootstrap-tpls-0.9.0.min.js PRE-CREATION
> src/webui/master/static/offers.html 215d65e1ad30fb0df06bcf05cec797d60672ec66
> src/webui/master/static/slave.html f30d914e4b43b5d4579c52053f9c0e04089a3adf
> src/webui/master/static/slave_executor.html 519847c0de077717c88c4d35804ad40d339d4246
> src/webui/master/static/slave_framework.html 947bab12eec8c3be5c3893b873b4b6378c8dcbbb
> src/webui/master/static/slaves.html ef5b66290e65408312dcf1e59221ee9517b37203
>
> Diff: https://reviews.apache.org/r/16798/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Thomas Rampelberg
>
>
Re: Review Request 16798: Updated to bootstrap-3.0.3.
Posted by Ross Allen <ro...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16798/#review31640
-----------------------------------------------------------
Ship it!
This was submitted.
- Ross Allen
On Jan. 13, 2014, 7:03 p.m., Thomas Rampelberg wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16798/
> -----------------------------------------------------------
>
> (Updated Jan. 13, 2014, 7:03 p.m.)
>
>
> Review request for mesos and Ross Allen.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Updated to bootstrap-3.0.3.
>
> Review: http://reviews.apache.org/r/16798
>
>
> Diffs
> -----
>
> src/Makefile.am ef707706315911c73e12c024b8bb38bbf5487621
> src/webui/master/static/browse.html fe8be009fc548d7b0ff62032ab284fc19e3ea2c7
> src/webui/master/static/css/bootstrap-2.3.2.min.css b6428e695860151f82076e87810fe2d133339c2a
> src/webui/master/static/css/bootstrap-3.0.3.min.css PRE-CREATION
> src/webui/master/static/css/bootstrap-responsive-2.3.2.min.css f4ede63f32e2ec803876a38efac05dd49acc4684
> src/webui/master/static/css/mesos.css 0a2daec0c5f287deef35fb1b8d3199c32f901788
> src/webui/master/static/fonts/glyphicons-halflings-regular.eot PRE-CREATION
> src/webui/master/static/fonts/glyphicons-halflings-regular.svg PRE-CREATION
> src/webui/master/static/fonts/glyphicons-halflings-regular.ttf PRE-CREATION
> src/webui/master/static/fonts/glyphicons-halflings-regular.woff PRE-CREATION
> src/webui/master/static/framework.html 72e14dfb58895e43a10f10c139a983a78b3e8878
> src/webui/master/static/frameworks.html 39e7883ffe001ff33ed1b35108c893fa8ff1f92d
> src/webui/master/static/home.html fb3a38e94c30487c9b7e50c65c73b7af29999c3f
> src/webui/master/static/img/glyphicons-halflings-white.png 3bf6484a29d8da269f9bc874b25493a45fae3bae
> src/webui/master/static/img/glyphicons-halflings.png 79bc568c21395d5a5ceab62fadb04457094b2ac7
> src/webui/master/static/index.html 7133ecdc77650cd31f9a80edfe2d190935f94846
> src/webui/master/static/js/app.js 5569d1143ab353a31515a77113fa742df4ec25ab
> src/webui/master/static/js/ui-bootstrap-tpls-0.7.0.js 08c2b78cb5177cded00f742eb7f35aa0f9e37baf
> src/webui/master/static/js/ui-bootstrap-tpls-0.7.0.min.js d2da4e20ebd5bb5b6f70fc785ff42cf3c2e7e32c
> src/webui/master/static/js/ui-bootstrap-tpls-0.9.0.min.js PRE-CREATION
> src/webui/master/static/offers.html 215d65e1ad30fb0df06bcf05cec797d60672ec66
> src/webui/master/static/slave.html f30d914e4b43b5d4579c52053f9c0e04089a3adf
> src/webui/master/static/slave_executor.html 519847c0de077717c88c4d35804ad40d339d4246
> src/webui/master/static/slave_framework.html 947bab12eec8c3be5c3893b873b4b6378c8dcbbb
> src/webui/master/static/slaves.html ef5b66290e65408312dcf1e59221ee9517b37203
>
> Diff: https://reviews.apache.org/r/16798/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Thomas Rampelberg
>
>
Re: Review Request 16798: Updated to bootstrap-3.0.3.
Posted by Ross Allen <ro...@mesosphere.io>.
> On Jan. 13, 2014, 7:59 p.m., Ben Mahler wrote:
> > src/Makefile.am, lines 462-465
> > <https://reviews.apache.org/r/16798/diff/9/?file=421839#file421839line462>
> >
> > It looks like this change broke the Makefile, a trailing \ is missing on this line.
> >
> > Kill the whitespace please on these other lines.
>
> Thomas Rampelberg wrote:
> I swear I'm going to get the hang of this eventually. Sorry about the build failure =/
Fixed in https://reviews.apache.org/r/16828/
- Ross
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16798/#review31649
-----------------------------------------------------------
On Jan. 13, 2014, 7:03 p.m., Thomas Rampelberg wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16798/
> -----------------------------------------------------------
>
> (Updated Jan. 13, 2014, 7:03 p.m.)
>
>
> Review request for mesos and Ross Allen.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Updated to bootstrap-3.0.3.
>
> Review: http://reviews.apache.org/r/16798
>
>
> Diffs
> -----
>
> src/Makefile.am ef707706315911c73e12c024b8bb38bbf5487621
> src/webui/master/static/browse.html fe8be009fc548d7b0ff62032ab284fc19e3ea2c7
> src/webui/master/static/css/bootstrap-2.3.2.min.css b6428e695860151f82076e87810fe2d133339c2a
> src/webui/master/static/css/bootstrap-3.0.3.min.css PRE-CREATION
> src/webui/master/static/css/bootstrap-responsive-2.3.2.min.css f4ede63f32e2ec803876a38efac05dd49acc4684
> src/webui/master/static/css/mesos.css 0a2daec0c5f287deef35fb1b8d3199c32f901788
> src/webui/master/static/fonts/glyphicons-halflings-regular.eot PRE-CREATION
> src/webui/master/static/fonts/glyphicons-halflings-regular.svg PRE-CREATION
> src/webui/master/static/fonts/glyphicons-halflings-regular.ttf PRE-CREATION
> src/webui/master/static/fonts/glyphicons-halflings-regular.woff PRE-CREATION
> src/webui/master/static/framework.html 72e14dfb58895e43a10f10c139a983a78b3e8878
> src/webui/master/static/frameworks.html 39e7883ffe001ff33ed1b35108c893fa8ff1f92d
> src/webui/master/static/home.html fb3a38e94c30487c9b7e50c65c73b7af29999c3f
> src/webui/master/static/img/glyphicons-halflings-white.png 3bf6484a29d8da269f9bc874b25493a45fae3bae
> src/webui/master/static/img/glyphicons-halflings.png 79bc568c21395d5a5ceab62fadb04457094b2ac7
> src/webui/master/static/index.html 7133ecdc77650cd31f9a80edfe2d190935f94846
> src/webui/master/static/js/app.js 5569d1143ab353a31515a77113fa742df4ec25ab
> src/webui/master/static/js/ui-bootstrap-tpls-0.7.0.js 08c2b78cb5177cded00f742eb7f35aa0f9e37baf
> src/webui/master/static/js/ui-bootstrap-tpls-0.7.0.min.js d2da4e20ebd5bb5b6f70fc785ff42cf3c2e7e32c
> src/webui/master/static/js/ui-bootstrap-tpls-0.9.0.min.js PRE-CREATION
> src/webui/master/static/offers.html 215d65e1ad30fb0df06bcf05cec797d60672ec66
> src/webui/master/static/slave.html f30d914e4b43b5d4579c52053f9c0e04089a3adf
> src/webui/master/static/slave_executor.html 519847c0de077717c88c4d35804ad40d339d4246
> src/webui/master/static/slave_framework.html 947bab12eec8c3be5c3893b873b4b6378c8dcbbb
> src/webui/master/static/slaves.html ef5b66290e65408312dcf1e59221ee9517b37203
>
> Diff: https://reviews.apache.org/r/16798/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Thomas Rampelberg
>
>
Re: Review Request 16798: Updated to bootstrap-3.0.3.
Posted by Thomas Rampelberg <th...@saunter.org>.
> On Jan. 13, 2014, 7:59 p.m., Ben Mahler wrote:
> > src/Makefile.am, lines 462-465
> > <https://reviews.apache.org/r/16798/diff/9/?file=421839#file421839line462>
> >
> > It looks like this change broke the Makefile, a trailing \ is missing on this line.
> >
> > Kill the whitespace please on these other lines.
I swear I'm going to get the hang of this eventually. Sorry about the build failure =/
- Thomas
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16798/#review31649
-----------------------------------------------------------
On Jan. 13, 2014, 7:03 p.m., Thomas Rampelberg wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16798/
> -----------------------------------------------------------
>
> (Updated Jan. 13, 2014, 7:03 p.m.)
>
>
> Review request for mesos and Ross Allen.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Updated to bootstrap-3.0.3.
>
> Review: http://reviews.apache.org/r/16798
>
>
> Diffs
> -----
>
> src/Makefile.am ef707706315911c73e12c024b8bb38bbf5487621
> src/webui/master/static/browse.html fe8be009fc548d7b0ff62032ab284fc19e3ea2c7
> src/webui/master/static/css/bootstrap-2.3.2.min.css b6428e695860151f82076e87810fe2d133339c2a
> src/webui/master/static/css/bootstrap-3.0.3.min.css PRE-CREATION
> src/webui/master/static/css/bootstrap-responsive-2.3.2.min.css f4ede63f32e2ec803876a38efac05dd49acc4684
> src/webui/master/static/css/mesos.css 0a2daec0c5f287deef35fb1b8d3199c32f901788
> src/webui/master/static/fonts/glyphicons-halflings-regular.eot PRE-CREATION
> src/webui/master/static/fonts/glyphicons-halflings-regular.svg PRE-CREATION
> src/webui/master/static/fonts/glyphicons-halflings-regular.ttf PRE-CREATION
> src/webui/master/static/fonts/glyphicons-halflings-regular.woff PRE-CREATION
> src/webui/master/static/framework.html 72e14dfb58895e43a10f10c139a983a78b3e8878
> src/webui/master/static/frameworks.html 39e7883ffe001ff33ed1b35108c893fa8ff1f92d
> src/webui/master/static/home.html fb3a38e94c30487c9b7e50c65c73b7af29999c3f
> src/webui/master/static/img/glyphicons-halflings-white.png 3bf6484a29d8da269f9bc874b25493a45fae3bae
> src/webui/master/static/img/glyphicons-halflings.png 79bc568c21395d5a5ceab62fadb04457094b2ac7
> src/webui/master/static/index.html 7133ecdc77650cd31f9a80edfe2d190935f94846
> src/webui/master/static/js/app.js 5569d1143ab353a31515a77113fa742df4ec25ab
> src/webui/master/static/js/ui-bootstrap-tpls-0.7.0.js 08c2b78cb5177cded00f742eb7f35aa0f9e37baf
> src/webui/master/static/js/ui-bootstrap-tpls-0.7.0.min.js d2da4e20ebd5bb5b6f70fc785ff42cf3c2e7e32c
> src/webui/master/static/js/ui-bootstrap-tpls-0.9.0.min.js PRE-CREATION
> src/webui/master/static/offers.html 215d65e1ad30fb0df06bcf05cec797d60672ec66
> src/webui/master/static/slave.html f30d914e4b43b5d4579c52053f9c0e04089a3adf
> src/webui/master/static/slave_executor.html 519847c0de077717c88c4d35804ad40d339d4246
> src/webui/master/static/slave_framework.html 947bab12eec8c3be5c3893b873b4b6378c8dcbbb
> src/webui/master/static/slaves.html ef5b66290e65408312dcf1e59221ee9517b37203
>
> Diff: https://reviews.apache.org/r/16798/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Thomas Rampelberg
>
>
Re: Review Request 16798: Updated to bootstrap-3.0.3.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16798/#review31649
-----------------------------------------------------------
src/Makefile.am
<https://reviews.apache.org/r/16798/#comment60330>
It looks like this change broke the Makefile, a trailing \ is missing on this line.
Kill the whitespace please on these other lines.
- Ben Mahler
On Jan. 13, 2014, 7:03 p.m., Thomas Rampelberg wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16798/
> -----------------------------------------------------------
>
> (Updated Jan. 13, 2014, 7:03 p.m.)
>
>
> Review request for mesos and Ross Allen.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Updated to bootstrap-3.0.3.
>
> Review: http://reviews.apache.org/r/16798
>
>
> Diffs
> -----
>
> src/Makefile.am ef707706315911c73e12c024b8bb38bbf5487621
> src/webui/master/static/browse.html fe8be009fc548d7b0ff62032ab284fc19e3ea2c7
> src/webui/master/static/css/bootstrap-2.3.2.min.css b6428e695860151f82076e87810fe2d133339c2a
> src/webui/master/static/css/bootstrap-3.0.3.min.css PRE-CREATION
> src/webui/master/static/css/bootstrap-responsive-2.3.2.min.css f4ede63f32e2ec803876a38efac05dd49acc4684
> src/webui/master/static/css/mesos.css 0a2daec0c5f287deef35fb1b8d3199c32f901788
> src/webui/master/static/fonts/glyphicons-halflings-regular.eot PRE-CREATION
> src/webui/master/static/fonts/glyphicons-halflings-regular.svg PRE-CREATION
> src/webui/master/static/fonts/glyphicons-halflings-regular.ttf PRE-CREATION
> src/webui/master/static/fonts/glyphicons-halflings-regular.woff PRE-CREATION
> src/webui/master/static/framework.html 72e14dfb58895e43a10f10c139a983a78b3e8878
> src/webui/master/static/frameworks.html 39e7883ffe001ff33ed1b35108c893fa8ff1f92d
> src/webui/master/static/home.html fb3a38e94c30487c9b7e50c65c73b7af29999c3f
> src/webui/master/static/img/glyphicons-halflings-white.png 3bf6484a29d8da269f9bc874b25493a45fae3bae
> src/webui/master/static/img/glyphicons-halflings.png 79bc568c21395d5a5ceab62fadb04457094b2ac7
> src/webui/master/static/index.html 7133ecdc77650cd31f9a80edfe2d190935f94846
> src/webui/master/static/js/app.js 5569d1143ab353a31515a77113fa742df4ec25ab
> src/webui/master/static/js/ui-bootstrap-tpls-0.7.0.js 08c2b78cb5177cded00f742eb7f35aa0f9e37baf
> src/webui/master/static/js/ui-bootstrap-tpls-0.7.0.min.js d2da4e20ebd5bb5b6f70fc785ff42cf3c2e7e32c
> src/webui/master/static/js/ui-bootstrap-tpls-0.9.0.min.js PRE-CREATION
> src/webui/master/static/offers.html 215d65e1ad30fb0df06bcf05cec797d60672ec66
> src/webui/master/static/slave.html f30d914e4b43b5d4579c52053f9c0e04089a3adf
> src/webui/master/static/slave_executor.html 519847c0de077717c88c4d35804ad40d339d4246
> src/webui/master/static/slave_framework.html 947bab12eec8c3be5c3893b873b4b6378c8dcbbb
> src/webui/master/static/slaves.html ef5b66290e65408312dcf1e59221ee9517b37203
>
> Diff: https://reviews.apache.org/r/16798/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Thomas Rampelberg
>
>
Re: Review Request 16798: Updated to bootstrap-3.0.3.
Posted by Thomas Rampelberg <th...@saunter.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16798/
-----------------------------------------------------------
(Updated Jan. 13, 2014, 7:03 p.m.)
Review request for mesos and Ross Allen.
Repository: mesos-git
Description
-------
Updated to bootstrap-3.0.3.
Review: http://reviews.apache.org/r/16798
Diffs (updated)
-----
src/Makefile.am ef707706315911c73e12c024b8bb38bbf5487621
src/webui/master/static/browse.html fe8be009fc548d7b0ff62032ab284fc19e3ea2c7
src/webui/master/static/css/bootstrap-2.3.2.min.css b6428e695860151f82076e87810fe2d133339c2a
src/webui/master/static/css/bootstrap-3.0.3.min.css PRE-CREATION
src/webui/master/static/css/bootstrap-responsive-2.3.2.min.css f4ede63f32e2ec803876a38efac05dd49acc4684
src/webui/master/static/css/mesos.css 0a2daec0c5f287deef35fb1b8d3199c32f901788
src/webui/master/static/fonts/glyphicons-halflings-regular.eot PRE-CREATION
src/webui/master/static/fonts/glyphicons-halflings-regular.svg PRE-CREATION
src/webui/master/static/fonts/glyphicons-halflings-regular.ttf PRE-CREATION
src/webui/master/static/fonts/glyphicons-halflings-regular.woff PRE-CREATION
src/webui/master/static/framework.html 72e14dfb58895e43a10f10c139a983a78b3e8878
src/webui/master/static/frameworks.html 39e7883ffe001ff33ed1b35108c893fa8ff1f92d
src/webui/master/static/home.html fb3a38e94c30487c9b7e50c65c73b7af29999c3f
src/webui/master/static/img/glyphicons-halflings-white.png 3bf6484a29d8da269f9bc874b25493a45fae3bae
src/webui/master/static/img/glyphicons-halflings.png 79bc568c21395d5a5ceab62fadb04457094b2ac7
src/webui/master/static/index.html 7133ecdc77650cd31f9a80edfe2d190935f94846
src/webui/master/static/js/app.js 5569d1143ab353a31515a77113fa742df4ec25ab
src/webui/master/static/js/ui-bootstrap-tpls-0.7.0.js 08c2b78cb5177cded00f742eb7f35aa0f9e37baf
src/webui/master/static/js/ui-bootstrap-tpls-0.7.0.min.js d2da4e20ebd5bb5b6f70fc785ff42cf3c2e7e32c
src/webui/master/static/js/ui-bootstrap-tpls-0.9.0.min.js PRE-CREATION
src/webui/master/static/offers.html 215d65e1ad30fb0df06bcf05cec797d60672ec66
src/webui/master/static/slave.html f30d914e4b43b5d4579c52053f9c0e04089a3adf
src/webui/master/static/slave_executor.html 519847c0de077717c88c4d35804ad40d339d4246
src/webui/master/static/slave_framework.html 947bab12eec8c3be5c3893b873b4b6378c8dcbbb
src/webui/master/static/slaves.html ef5b66290e65408312dcf1e59221ee9517b37203
Diff: https://reviews.apache.org/r/16798/diff/
Testing
-------
Thanks,
Thomas Rampelberg
Re: Review Request 16798: Updated to bootstrap-3.0.3.
Posted by Thomas Rampelberg <th...@saunter.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16798/
-----------------------------------------------------------
(Updated Jan. 13, 2014, 6:58 p.m.)
Review request for mesos and Ross Allen.
Repository: mesos-git
Description
-------
Updated to bootstrap-3.0.3.
Review: http://reviews.apache.org/r/16798
Diffs (updated)
-----
src/Makefile.am ef707706315911c73e12c024b8bb38bbf5487621
src/webui/master/static/browse.html fe8be009fc548d7b0ff62032ab284fc19e3ea2c7
src/webui/master/static/css/bootstrap-2.3.2.min.css b6428e695860151f82076e87810fe2d133339c2a
src/webui/master/static/css/bootstrap-3.0.3.min.css PRE-CREATION
src/webui/master/static/css/bootstrap-responsive-2.3.2.min.css f4ede63f32e2ec803876a38efac05dd49acc4684
src/webui/master/static/fonts/glyphicons-halflings-regular.eot PRE-CREATION
src/webui/master/static/fonts/glyphicons-halflings-regular.svg PRE-CREATION
src/webui/master/static/fonts/glyphicons-halflings-regular.ttf PRE-CREATION
src/webui/master/static/fonts/glyphicons-halflings-regular.woff PRE-CREATION
src/webui/master/static/framework.html 72e14dfb58895e43a10f10c139a983a78b3e8878
src/webui/master/static/frameworks.html 39e7883ffe001ff33ed1b35108c893fa8ff1f92d
src/webui/master/static/home.html fb3a38e94c30487c9b7e50c65c73b7af29999c3f
src/webui/master/static/img/glyphicons-halflings-white.png 3bf6484a29d8da269f9bc874b25493a45fae3bae
src/webui/master/static/img/glyphicons-halflings.png 79bc568c21395d5a5ceab62fadb04457094b2ac7
src/webui/master/static/index.html 7133ecdc77650cd31f9a80edfe2d190935f94846
src/webui/master/static/js/app.js 5569d1143ab353a31515a77113fa742df4ec25ab
src/webui/master/static/js/ui-bootstrap-tpls-0.7.0.js 08c2b78cb5177cded00f742eb7f35aa0f9e37baf
src/webui/master/static/js/ui-bootstrap-tpls-0.7.0.min.js d2da4e20ebd5bb5b6f70fc785ff42cf3c2e7e32c
src/webui/master/static/js/ui-bootstrap-tpls-0.9.0.min.js PRE-CREATION
src/webui/master/static/offers.html 215d65e1ad30fb0df06bcf05cec797d60672ec66
src/webui/master/static/slave.html f30d914e4b43b5d4579c52053f9c0e04089a3adf
src/webui/master/static/slave_executor.html 519847c0de077717c88c4d35804ad40d339d4246
src/webui/master/static/slave_framework.html 947bab12eec8c3be5c3893b873b4b6378c8dcbbb
src/webui/master/static/slaves.html ef5b66290e65408312dcf1e59221ee9517b37203
Diff: https://reviews.apache.org/r/16798/diff/
Testing
-------
Thanks,
Thomas Rampelberg
Re: Review Request 16798: Updated to bootstrap-3.0.3.
Posted by Ross Allen <ro...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16798/#review31633
-----------------------------------------------------------
The buttons on the sandbox page should use the new "btn-xs" class instead of the removed "btn-mini". They also need a "btn-default" to get the default button colors:
https://www.dropbox.com/s/ffrop3gecre17qv/Screenshot%202014-01-13%2010.56.58.png
- Ross Allen
On Jan. 13, 2014, 6:45 p.m., Thomas Rampelberg wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16798/
> -----------------------------------------------------------
>
> (Updated Jan. 13, 2014, 6:45 p.m.)
>
>
> Review request for mesos and Ross Allen.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Updated to bootstrap-3.0.3.
>
> Review: http://reviews.apache.org/r/16798
>
>
> Diffs
> -----
>
> src/Makefile.am ef707706315911c73e12c024b8bb38bbf5487621
> src/webui/master/static/browse.html fe8be009fc548d7b0ff62032ab284fc19e3ea2c7
> src/webui/master/static/css/bootstrap-2.3.2.min.css b6428e695860151f82076e87810fe2d133339c2a
> src/webui/master/static/css/bootstrap-3.0.3.min.css PRE-CREATION
> src/webui/master/static/css/bootstrap-responsive-2.3.2.min.css f4ede63f32e2ec803876a38efac05dd49acc4684
> src/webui/master/static/fonts/glyphicons-halflings-regular.eot PRE-CREATION
> src/webui/master/static/fonts/glyphicons-halflings-regular.svg PRE-CREATION
> src/webui/master/static/fonts/glyphicons-halflings-regular.ttf PRE-CREATION
> src/webui/master/static/fonts/glyphicons-halflings-regular.woff PRE-CREATION
> src/webui/master/static/framework.html 72e14dfb58895e43a10f10c139a983a78b3e8878
> src/webui/master/static/frameworks.html 39e7883ffe001ff33ed1b35108c893fa8ff1f92d
> src/webui/master/static/home.html fb3a38e94c30487c9b7e50c65c73b7af29999c3f
> src/webui/master/static/img/glyphicons-halflings-white.png 3bf6484a29d8da269f9bc874b25493a45fae3bae
> src/webui/master/static/img/glyphicons-halflings.png 79bc568c21395d5a5ceab62fadb04457094b2ac7
> src/webui/master/static/index.html 7133ecdc77650cd31f9a80edfe2d190935f94846
> src/webui/master/static/js/app.js 5569d1143ab353a31515a77113fa742df4ec25ab
> src/webui/master/static/js/ui-bootstrap-tpls-0.7.0.js 08c2b78cb5177cded00f742eb7f35aa0f9e37baf
> src/webui/master/static/js/ui-bootstrap-tpls-0.7.0.min.js d2da4e20ebd5bb5b6f70fc785ff42cf3c2e7e32c
> src/webui/master/static/js/ui-bootstrap-tpls-0.9.0.min.js PRE-CREATION
> src/webui/master/static/offers.html 215d65e1ad30fb0df06bcf05cec797d60672ec66
> src/webui/master/static/slave.html f30d914e4b43b5d4579c52053f9c0e04089a3adf
> src/webui/master/static/slave_executor.html 519847c0de077717c88c4d35804ad40d339d4246
> src/webui/master/static/slave_framework.html 947bab12eec8c3be5c3893b873b4b6378c8dcbbb
> src/webui/master/static/slaves.html ef5b66290e65408312dcf1e59221ee9517b37203
>
> Diff: https://reviews.apache.org/r/16798/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Thomas Rampelberg
>
>
Re: Review Request 16798: Updated to bootstrap-3.0.3.
Posted by Ross Allen <ro...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16798/#review31632
-----------------------------------------------------------
<dd> elements got a new "margin-left: 0;" in v3, which smashes the <dt> and <dd> together in the left bar now. Can those get a "margin-left: 5px;" or whatever looks good so there is space between the colon and the value?
https://www.dropbox.com/s/9i4rw6utfh7g4hd/Screenshot%202014-01-13%2010.53.58.png
- Ross Allen
On Jan. 13, 2014, 6:45 p.m., Thomas Rampelberg wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16798/
> -----------------------------------------------------------
>
> (Updated Jan. 13, 2014, 6:45 p.m.)
>
>
> Review request for mesos and Ross Allen.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Updated to bootstrap-3.0.3.
>
> Review: http://reviews.apache.org/r/16798
>
>
> Diffs
> -----
>
> src/Makefile.am ef707706315911c73e12c024b8bb38bbf5487621
> src/webui/master/static/browse.html fe8be009fc548d7b0ff62032ab284fc19e3ea2c7
> src/webui/master/static/css/bootstrap-2.3.2.min.css b6428e695860151f82076e87810fe2d133339c2a
> src/webui/master/static/css/bootstrap-3.0.3.min.css PRE-CREATION
> src/webui/master/static/css/bootstrap-responsive-2.3.2.min.css f4ede63f32e2ec803876a38efac05dd49acc4684
> src/webui/master/static/fonts/glyphicons-halflings-regular.eot PRE-CREATION
> src/webui/master/static/fonts/glyphicons-halflings-regular.svg PRE-CREATION
> src/webui/master/static/fonts/glyphicons-halflings-regular.ttf PRE-CREATION
> src/webui/master/static/fonts/glyphicons-halflings-regular.woff PRE-CREATION
> src/webui/master/static/framework.html 72e14dfb58895e43a10f10c139a983a78b3e8878
> src/webui/master/static/frameworks.html 39e7883ffe001ff33ed1b35108c893fa8ff1f92d
> src/webui/master/static/home.html fb3a38e94c30487c9b7e50c65c73b7af29999c3f
> src/webui/master/static/img/glyphicons-halflings-white.png 3bf6484a29d8da269f9bc874b25493a45fae3bae
> src/webui/master/static/img/glyphicons-halflings.png 79bc568c21395d5a5ceab62fadb04457094b2ac7
> src/webui/master/static/index.html 7133ecdc77650cd31f9a80edfe2d190935f94846
> src/webui/master/static/js/app.js 5569d1143ab353a31515a77113fa742df4ec25ab
> src/webui/master/static/js/ui-bootstrap-tpls-0.7.0.js 08c2b78cb5177cded00f742eb7f35aa0f9e37baf
> src/webui/master/static/js/ui-bootstrap-tpls-0.7.0.min.js d2da4e20ebd5bb5b6f70fc785ff42cf3c2e7e32c
> src/webui/master/static/js/ui-bootstrap-tpls-0.9.0.min.js PRE-CREATION
> src/webui/master/static/offers.html 215d65e1ad30fb0df06bcf05cec797d60672ec66
> src/webui/master/static/slave.html f30d914e4b43b5d4579c52053f9c0e04089a3adf
> src/webui/master/static/slave_executor.html 519847c0de077717c88c4d35804ad40d339d4246
> src/webui/master/static/slave_framework.html 947bab12eec8c3be5c3893b873b4b6378c8dcbbb
> src/webui/master/static/slaves.html ef5b66290e65408312dcf1e59221ee9517b37203
>
> Diff: https://reviews.apache.org/r/16798/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Thomas Rampelberg
>
>
Re: Review Request 16798: Updated to bootstrap-3.0.3.
Posted by Thomas Rampelberg <th...@saunter.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16798/
-----------------------------------------------------------
(Updated Jan. 13, 2014, 6:45 p.m.)
Review request for mesos and Ross Allen.
Repository: mesos-git
Description
-------
Updated to bootstrap-3.0.3.
Review: http://reviews.apache.org/r/16798
Diffs (updated)
-----
src/Makefile.am ef707706315911c73e12c024b8bb38bbf5487621
src/webui/master/static/browse.html fe8be009fc548d7b0ff62032ab284fc19e3ea2c7
src/webui/master/static/css/bootstrap-2.3.2.min.css b6428e695860151f82076e87810fe2d133339c2a
src/webui/master/static/css/bootstrap-3.0.3.min.css PRE-CREATION
src/webui/master/static/css/bootstrap-responsive-2.3.2.min.css f4ede63f32e2ec803876a38efac05dd49acc4684
src/webui/master/static/fonts/glyphicons-halflings-regular.eot PRE-CREATION
src/webui/master/static/fonts/glyphicons-halflings-regular.svg PRE-CREATION
src/webui/master/static/fonts/glyphicons-halflings-regular.ttf PRE-CREATION
src/webui/master/static/fonts/glyphicons-halflings-regular.woff PRE-CREATION
src/webui/master/static/framework.html 72e14dfb58895e43a10f10c139a983a78b3e8878
src/webui/master/static/frameworks.html 39e7883ffe001ff33ed1b35108c893fa8ff1f92d
src/webui/master/static/home.html fb3a38e94c30487c9b7e50c65c73b7af29999c3f
src/webui/master/static/img/glyphicons-halflings-white.png 3bf6484a29d8da269f9bc874b25493a45fae3bae
src/webui/master/static/img/glyphicons-halflings.png 79bc568c21395d5a5ceab62fadb04457094b2ac7
src/webui/master/static/index.html 7133ecdc77650cd31f9a80edfe2d190935f94846
src/webui/master/static/js/app.js 5569d1143ab353a31515a77113fa742df4ec25ab
src/webui/master/static/js/ui-bootstrap-tpls-0.7.0.js 08c2b78cb5177cded00f742eb7f35aa0f9e37baf
src/webui/master/static/js/ui-bootstrap-tpls-0.7.0.min.js d2da4e20ebd5bb5b6f70fc785ff42cf3c2e7e32c
src/webui/master/static/js/ui-bootstrap-tpls-0.9.0.min.js PRE-CREATION
src/webui/master/static/offers.html 215d65e1ad30fb0df06bcf05cec797d60672ec66
src/webui/master/static/slave.html f30d914e4b43b5d4579c52053f9c0e04089a3adf
src/webui/master/static/slave_executor.html 519847c0de077717c88c4d35804ad40d339d4246
src/webui/master/static/slave_framework.html 947bab12eec8c3be5c3893b873b4b6378c8dcbbb
src/webui/master/static/slaves.html ef5b66290e65408312dcf1e59221ee9517b37203
Diff: https://reviews.apache.org/r/16798/diff/
Testing
-------
Thanks,
Thomas Rampelberg
Re: Review Request 16798: Updated to bootstrap-3.0.3.
Posted by Ross Allen <ro...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16798/#review31629
-----------------------------------------------------------
Bootstrap v3 switched to a Glyphicon font from the old PNGs. Can you add those as well?
- Ross Allen
On Jan. 13, 2014, 6:31 p.m., Thomas Rampelberg wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16798/
> -----------------------------------------------------------
>
> (Updated Jan. 13, 2014, 6:31 p.m.)
>
>
> Review request for mesos and Ross Allen.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Updated to bootstrap-3.0.3.
>
> Review: http://reviews.apache.org/r/16798
>
>
> Diffs
> -----
>
> src/Makefile.am ef707706315911c73e12c024b8bb38bbf5487621
> src/webui/master/static/browse.html fe8be009fc548d7b0ff62032ab284fc19e3ea2c7
> src/webui/master/static/css/bootstrap-2.3.2.min.css b6428e695860151f82076e87810fe2d133339c2a
> src/webui/master/static/css/bootstrap-3.0.3.min.css PRE-CREATION
> src/webui/master/static/css/bootstrap-responsive-2.3.2.min.css f4ede63f32e2ec803876a38efac05dd49acc4684
> src/webui/master/static/framework.html 72e14dfb58895e43a10f10c139a983a78b3e8878
> src/webui/master/static/frameworks.html 39e7883ffe001ff33ed1b35108c893fa8ff1f92d
> src/webui/master/static/home.html fb3a38e94c30487c9b7e50c65c73b7af29999c3f
> src/webui/master/static/index.html 7133ecdc77650cd31f9a80edfe2d190935f94846
> src/webui/master/static/js/ui-bootstrap-tpls-0.7.0.js 08c2b78cb5177cded00f742eb7f35aa0f9e37baf
> src/webui/master/static/js/ui-bootstrap-tpls-0.7.0.min.js d2da4e20ebd5bb5b6f70fc785ff42cf3c2e7e32c
> src/webui/master/static/js/ui-bootstrap-tpls-0.9.0.min.js PRE-CREATION
> src/webui/master/static/offers.html 215d65e1ad30fb0df06bcf05cec797d60672ec66
> src/webui/master/static/slave.html f30d914e4b43b5d4579c52053f9c0e04089a3adf
> src/webui/master/static/slave_executor.html 519847c0de077717c88c4d35804ad40d339d4246
> src/webui/master/static/slave_framework.html 947bab12eec8c3be5c3893b873b4b6378c8dcbbb
> src/webui/master/static/slaves.html ef5b66290e65408312dcf1e59221ee9517b37203
>
> Diff: https://reviews.apache.org/r/16798/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Thomas Rampelberg
>
>
Re: Review Request 16798: Updated to bootstrap-3.0.3.
Posted by Thomas Rampelberg <th...@saunter.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16798/
-----------------------------------------------------------
(Updated Jan. 13, 2014, 6:31 p.m.)
Review request for mesos and Ross Allen.
Repository: mesos-git
Description
-------
Updated to bootstrap-3.0.3.
Review: http://reviews.apache.org/r/16798
Diffs (updated)
-----
src/Makefile.am ef707706315911c73e12c024b8bb38bbf5487621
src/webui/master/static/browse.html fe8be009fc548d7b0ff62032ab284fc19e3ea2c7
src/webui/master/static/css/bootstrap-2.3.2.min.css b6428e695860151f82076e87810fe2d133339c2a
src/webui/master/static/css/bootstrap-3.0.3.min.css PRE-CREATION
src/webui/master/static/css/bootstrap-responsive-2.3.2.min.css f4ede63f32e2ec803876a38efac05dd49acc4684
src/webui/master/static/framework.html 72e14dfb58895e43a10f10c139a983a78b3e8878
src/webui/master/static/frameworks.html 39e7883ffe001ff33ed1b35108c893fa8ff1f92d
src/webui/master/static/home.html fb3a38e94c30487c9b7e50c65c73b7af29999c3f
src/webui/master/static/index.html 7133ecdc77650cd31f9a80edfe2d190935f94846
src/webui/master/static/js/ui-bootstrap-tpls-0.7.0.js 08c2b78cb5177cded00f742eb7f35aa0f9e37baf
src/webui/master/static/js/ui-bootstrap-tpls-0.7.0.min.js d2da4e20ebd5bb5b6f70fc785ff42cf3c2e7e32c
src/webui/master/static/js/ui-bootstrap-tpls-0.9.0.min.js PRE-CREATION
src/webui/master/static/offers.html 215d65e1ad30fb0df06bcf05cec797d60672ec66
src/webui/master/static/slave.html f30d914e4b43b5d4579c52053f9c0e04089a3adf
src/webui/master/static/slave_executor.html 519847c0de077717c88c4d35804ad40d339d4246
src/webui/master/static/slave_framework.html 947bab12eec8c3be5c3893b873b4b6378c8dcbbb
src/webui/master/static/slaves.html ef5b66290e65408312dcf1e59221ee9517b37203
Diff: https://reviews.apache.org/r/16798/diff/
Testing
-------
Thanks,
Thomas Rampelberg
Re: Review Request 16798: Updated to bootstrap-3.0.3.
Posted by Thomas Rampelberg <th...@saunter.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16798/
-----------------------------------------------------------
(Updated Jan. 13, 2014, 6:07 p.m.)
Review request for mesos and Ross Allen.
Repository: mesos-git
Description
-------
Updated to bootstrap-3.0.3.
Review: http://reviews.apache.org/r/16798
Diffs (updated)
-----
configure.ac 18d9730394d6f1b2f1006d1db0ab814c595801d9
src/Makefile.am ef707706315911c73e12c024b8bb38bbf5487621
src/slave/paths.hpp b1a56a346ca84e7e71c31386602264c5097ef1cf
src/webui/master/static/browse.html fe8be009fc548d7b0ff62032ab284fc19e3ea2c7
src/webui/master/static/css/bootstrap-2.3.2.min.css b6428e695860151f82076e87810fe2d133339c2a
src/webui/master/static/css/bootstrap-3.0.3.min.css PRE-CREATION
src/webui/master/static/css/bootstrap-responsive-2.3.2.min.css f4ede63f32e2ec803876a38efac05dd49acc4684
src/webui/master/static/framework.html 72e14dfb58895e43a10f10c139a983a78b3e8878
src/webui/master/static/frameworks.html 39e7883ffe001ff33ed1b35108c893fa8ff1f92d
src/webui/master/static/home.html fb3a38e94c30487c9b7e50c65c73b7af29999c3f
src/webui/master/static/index.html 7133ecdc77650cd31f9a80edfe2d190935f94846
src/webui/master/static/js/ui-bootstrap-tpls-0.7.0.js 08c2b78cb5177cded00f742eb7f35aa0f9e37baf
src/webui/master/static/js/ui-bootstrap-tpls-0.7.0.min.js d2da4e20ebd5bb5b6f70fc785ff42cf3c2e7e32c
src/webui/master/static/js/ui-bootstrap-tpls-0.9.0.min.js PRE-CREATION
src/webui/master/static/offers.html 215d65e1ad30fb0df06bcf05cec797d60672ec66
src/webui/master/static/slave.html f30d914e4b43b5d4579c52053f9c0e04089a3adf
src/webui/master/static/slave_executor.html 519847c0de077717c88c4d35804ad40d339d4246
src/webui/master/static/slave_framework.html 947bab12eec8c3be5c3893b873b4b6378c8dcbbb
src/webui/master/static/slaves.html ef5b66290e65408312dcf1e59221ee9517b37203
Diff: https://reviews.apache.org/r/16798/diff/
Testing
-------
Thanks,
Thomas Rampelberg
Re: Review Request 16798: Updated to bootstrap-3.0.3.
Posted by Thomas Rampelberg <th...@saunter.org>.
> On Jan. 11, 2014, 1:15 a.m., Thomas Rampelberg wrote:
> > src/webui/master/static/index.html, line 25
> > <https://reviews.apache.org/r/16798/diff/3/?file=420395#file420395line25>
> >
> > It looks right to me ... I'm not sure what container was doing previously.
Nope, I was wrong. Updated with a container div.
- Thomas
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16798/#review31575
-----------------------------------------------------------
On Jan. 13, 2014, 6:07 p.m., Thomas Rampelberg wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16798/
> -----------------------------------------------------------
>
> (Updated Jan. 13, 2014, 6:07 p.m.)
>
>
> Review request for mesos and Ross Allen.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Updated to bootstrap-3.0.3.
>
> Review: http://reviews.apache.org/r/16798
>
>
> Diffs
> -----
>
> configure.ac 18d9730394d6f1b2f1006d1db0ab814c595801d9
> src/Makefile.am ef707706315911c73e12c024b8bb38bbf5487621
> src/slave/paths.hpp b1a56a346ca84e7e71c31386602264c5097ef1cf
> src/webui/master/static/browse.html fe8be009fc548d7b0ff62032ab284fc19e3ea2c7
> src/webui/master/static/css/bootstrap-2.3.2.min.css b6428e695860151f82076e87810fe2d133339c2a
> src/webui/master/static/css/bootstrap-3.0.3.min.css PRE-CREATION
> src/webui/master/static/css/bootstrap-responsive-2.3.2.min.css f4ede63f32e2ec803876a38efac05dd49acc4684
> src/webui/master/static/framework.html 72e14dfb58895e43a10f10c139a983a78b3e8878
> src/webui/master/static/frameworks.html 39e7883ffe001ff33ed1b35108c893fa8ff1f92d
> src/webui/master/static/home.html fb3a38e94c30487c9b7e50c65c73b7af29999c3f
> src/webui/master/static/index.html 7133ecdc77650cd31f9a80edfe2d190935f94846
> src/webui/master/static/js/ui-bootstrap-tpls-0.7.0.js 08c2b78cb5177cded00f742eb7f35aa0f9e37baf
> src/webui/master/static/js/ui-bootstrap-tpls-0.7.0.min.js d2da4e20ebd5bb5b6f70fc785ff42cf3c2e7e32c
> src/webui/master/static/js/ui-bootstrap-tpls-0.9.0.min.js PRE-CREATION
> src/webui/master/static/offers.html 215d65e1ad30fb0df06bcf05cec797d60672ec66
> src/webui/master/static/slave.html f30d914e4b43b5d4579c52053f9c0e04089a3adf
> src/webui/master/static/slave_executor.html 519847c0de077717c88c4d35804ad40d339d4246
> src/webui/master/static/slave_framework.html 947bab12eec8c3be5c3893b873b4b6378c8dcbbb
> src/webui/master/static/slaves.html ef5b66290e65408312dcf1e59221ee9517b37203
>
> Diff: https://reviews.apache.org/r/16798/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Thomas Rampelberg
>
>
Re: Review Request 16798: Updated to bootstrap-3.0.3.
Posted by Thomas Rampelberg <th...@saunter.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16798/#review31575
-----------------------------------------------------------
src/webui/master/static/index.html
<https://reviews.apache.org/r/16798/#comment60091>
It looks right to me ... I'm not sure what container was doing previously.
- Thomas Rampelberg
On Jan. 11, 2014, 1:14 a.m., Thomas Rampelberg wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16798/
> -----------------------------------------------------------
>
> (Updated Jan. 11, 2014, 1:14 a.m.)
>
>
> Review request for mesos and Ross Allen.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Updated to bootstrap-3.0.3.
>
> Review: http://reviews.apache.org/r/16798
>
>
> Diffs
> -----
>
> src/Makefile.am ef707706315911c73e12c024b8bb38bbf5487621
> src/webui/master/static/browse.html fe8be009fc548d7b0ff62032ab284fc19e3ea2c7
> src/webui/master/static/css/bootstrap-2.3.2.min.css b6428e695860151f82076e87810fe2d133339c2a
> src/webui/master/static/css/bootstrap-3.0.3.min.css PRE-CREATION
> src/webui/master/static/css/bootstrap-responsive-2.3.2.min.css f4ede63f32e2ec803876a38efac05dd49acc4684
> src/webui/master/static/framework.html 72e14dfb58895e43a10f10c139a983a78b3e8878
> src/webui/master/static/frameworks.html 39e7883ffe001ff33ed1b35108c893fa8ff1f92d
> src/webui/master/static/home.html fb3a38e94c30487c9b7e50c65c73b7af29999c3f
> src/webui/master/static/index.html 7133ecdc77650cd31f9a80edfe2d190935f94846
> src/webui/master/static/js/ui-bootstrap-tpls-0.7.0.js 08c2b78cb5177cded00f742eb7f35aa0f9e37baf
> src/webui/master/static/js/ui-bootstrap-tpls-0.7.0.min.js d2da4e20ebd5bb5b6f70fc785ff42cf3c2e7e32c
> src/webui/master/static/js/ui-bootstrap-tpls-0.9.0.min.js PRE-CREATION
> src/webui/master/static/offers.html 215d65e1ad30fb0df06bcf05cec797d60672ec66
> src/webui/master/static/slave.html f30d914e4b43b5d4579c52053f9c0e04089a3adf
> src/webui/master/static/slave_executor.html 519847c0de077717c88c4d35804ad40d339d4246
> src/webui/master/static/slave_framework.html 947bab12eec8c3be5c3893b873b4b6378c8dcbbb
> src/webui/master/static/slaves.html ef5b66290e65408312dcf1e59221ee9517b37203
>
> Diff: https://reviews.apache.org/r/16798/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Thomas Rampelberg
>
>
Re: Review Request 16798: Updated to bootstrap-3.0.3.
Posted by Thomas Rampelberg <th...@saunter.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16798/
-----------------------------------------------------------
(Updated Jan. 11, 2014, 1:14 a.m.)
Review request for mesos and Ross Allen.
Repository: mesos-git
Description
-------
Updated to bootstrap-3.0.3.
Review: http://reviews.apache.org/r/16798
Diffs (updated)
-----
src/Makefile.am ef707706315911c73e12c024b8bb38bbf5487621
src/webui/master/static/browse.html fe8be009fc548d7b0ff62032ab284fc19e3ea2c7
src/webui/master/static/css/bootstrap-2.3.2.min.css b6428e695860151f82076e87810fe2d133339c2a
src/webui/master/static/css/bootstrap-3.0.3.min.css PRE-CREATION
src/webui/master/static/css/bootstrap-responsive-2.3.2.min.css f4ede63f32e2ec803876a38efac05dd49acc4684
src/webui/master/static/framework.html 72e14dfb58895e43a10f10c139a983a78b3e8878
src/webui/master/static/frameworks.html 39e7883ffe001ff33ed1b35108c893fa8ff1f92d
src/webui/master/static/home.html fb3a38e94c30487c9b7e50c65c73b7af29999c3f
src/webui/master/static/index.html 7133ecdc77650cd31f9a80edfe2d190935f94846
src/webui/master/static/js/ui-bootstrap-tpls-0.7.0.js 08c2b78cb5177cded00f742eb7f35aa0f9e37baf
src/webui/master/static/js/ui-bootstrap-tpls-0.7.0.min.js d2da4e20ebd5bb5b6f70fc785ff42cf3c2e7e32c
src/webui/master/static/js/ui-bootstrap-tpls-0.9.0.min.js PRE-CREATION
src/webui/master/static/offers.html 215d65e1ad30fb0df06bcf05cec797d60672ec66
src/webui/master/static/slave.html f30d914e4b43b5d4579c52053f9c0e04089a3adf
src/webui/master/static/slave_executor.html 519847c0de077717c88c4d35804ad40d339d4246
src/webui/master/static/slave_framework.html 947bab12eec8c3be5c3893b873b4b6378c8dcbbb
src/webui/master/static/slaves.html ef5b66290e65408312dcf1e59221ee9517b37203
Diff: https://reviews.apache.org/r/16798/diff/
Testing
-------
Thanks,
Thomas Rampelberg
Re: Review Request 16798: Updated to bootstrap-3.0.3.
Posted by Ross Allen <ro...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16798/#review31571
-----------------------------------------------------------
Don't forget to update Makefile.am with the added/removed files.
- Ross Allen
On Jan. 11, 2014, 12:18 a.m., Thomas Rampelberg wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16798/
> -----------------------------------------------------------
>
> (Updated Jan. 11, 2014, 12:18 a.m.)
>
>
> Review request for mesos and Ross Allen.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Updated to bootstrap-3.0.3.
>
> Review: http://reviews.apache.org/r/16798
>
>
> Diffs
> -----
>
> src/webui/master/static/browse.html fe8be009fc548d7b0ff62032ab284fc19e3ea2c7
> src/webui/master/static/css/bootstrap-2.3.2.min.css b6428e695860151f82076e87810fe2d133339c2a
> src/webui/master/static/css/bootstrap-3.0.3.min.css PRE-CREATION
> src/webui/master/static/css/bootstrap-responsive-2.3.2.min.css f4ede63f32e2ec803876a38efac05dd49acc4684
> src/webui/master/static/framework.html 72e14dfb58895e43a10f10c139a983a78b3e8878
> src/webui/master/static/frameworks.html 39e7883ffe001ff33ed1b35108c893fa8ff1f92d
> src/webui/master/static/home.html fb3a38e94c30487c9b7e50c65c73b7af29999c3f
> src/webui/master/static/index.html 7133ecdc77650cd31f9a80edfe2d190935f94846
> src/webui/master/static/js/ui-bootstrap-tpls-0.7.0.js 08c2b78cb5177cded00f742eb7f35aa0f9e37baf
> src/webui/master/static/js/ui-bootstrap-tpls-0.7.0.min.js d2da4e20ebd5bb5b6f70fc785ff42cf3c2e7e32c
> src/webui/master/static/js/ui-bootstrap-tpls-0.9.0.min.js PRE-CREATION
> src/webui/master/static/offers.html 215d65e1ad30fb0df06bcf05cec797d60672ec66
> src/webui/master/static/slave.html f30d914e4b43b5d4579c52053f9c0e04089a3adf
> src/webui/master/static/slave_executor.html 519847c0de077717c88c4d35804ad40d339d4246
> src/webui/master/static/slave_framework.html 947bab12eec8c3be5c3893b873b4b6378c8dcbbb
> src/webui/master/static/slaves.html ef5b66290e65408312dcf1e59221ee9517b37203
>
> Diff: https://reviews.apache.org/r/16798/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Thomas Rampelberg
>
>
Re: Review Request 16798: Updated to bootstrap-3.0.3.
Posted by Thomas Rampelberg <th...@saunter.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16798/
-----------------------------------------------------------
(Updated Jan. 11, 2014, 12:18 a.m.)
Review request for mesos and Ross Allen.
Repository: mesos-git
Description
-------
Updated to bootstrap-3.0.3.
Review: http://reviews.apache.org/r/16798
Diffs (updated)
-----
src/webui/master/static/browse.html fe8be009fc548d7b0ff62032ab284fc19e3ea2c7
src/webui/master/static/css/bootstrap-2.3.2.min.css b6428e695860151f82076e87810fe2d133339c2a
src/webui/master/static/css/bootstrap-3.0.3.min.css PRE-CREATION
src/webui/master/static/css/bootstrap-responsive-2.3.2.min.css f4ede63f32e2ec803876a38efac05dd49acc4684
src/webui/master/static/framework.html 72e14dfb58895e43a10f10c139a983a78b3e8878
src/webui/master/static/frameworks.html 39e7883ffe001ff33ed1b35108c893fa8ff1f92d
src/webui/master/static/home.html fb3a38e94c30487c9b7e50c65c73b7af29999c3f
src/webui/master/static/index.html 7133ecdc77650cd31f9a80edfe2d190935f94846
src/webui/master/static/js/ui-bootstrap-tpls-0.7.0.js 08c2b78cb5177cded00f742eb7f35aa0f9e37baf
src/webui/master/static/js/ui-bootstrap-tpls-0.7.0.min.js d2da4e20ebd5bb5b6f70fc785ff42cf3c2e7e32c
src/webui/master/static/js/ui-bootstrap-tpls-0.9.0.min.js PRE-CREATION
src/webui/master/static/offers.html 215d65e1ad30fb0df06bcf05cec797d60672ec66
src/webui/master/static/slave.html f30d914e4b43b5d4579c52053f9c0e04089a3adf
src/webui/master/static/slave_executor.html 519847c0de077717c88c4d35804ad40d339d4246
src/webui/master/static/slave_framework.html 947bab12eec8c3be5c3893b873b4b6378c8dcbbb
src/webui/master/static/slaves.html ef5b66290e65408312dcf1e59221ee9517b37203
Diff: https://reviews.apache.org/r/16798/diff/
Testing
-------
Thanks,
Thomas Rampelberg
Re: Review Request 16798: Updated to bootstrap-3.0.3.
Posted by Thomas Rampelberg <th...@saunter.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16798/
-----------------------------------------------------------
(Updated Jan. 11, 2014, 12:17 a.m.)
Review request for mesos and Ross Allen.
Repository: mesos-git
Description (updated)
-------
Updated to bootstrap-3.0.3.
Review: http://reviews.apache.org/r/16798
Diffs (updated)
-----
src/webui/master/static/browse.html fe8be009fc548d7b0ff62032ab284fc19e3ea2c7
src/webui/master/static/css/bootstrap-2.3.2.min.css b6428e695860151f82076e87810fe2d133339c2a
src/webui/master/static/css/bootstrap-3.0.3.min.css PRE-CREATION
src/webui/master/static/css/bootstrap-responsive-2.3.2.min.css f4ede63f32e2ec803876a38efac05dd49acc4684
src/webui/master/static/framework.html 72e14dfb58895e43a10f10c139a983a78b3e8878
src/webui/master/static/frameworks.html 39e7883ffe001ff33ed1b35108c893fa8ff1f92d
src/webui/master/static/home.html fb3a38e94c30487c9b7e50c65c73b7af29999c3f
src/webui/master/static/index.html 7133ecdc77650cd31f9a80edfe2d190935f94846
src/webui/master/static/js/ui-bootstrap-tpls-0.7.0.js 08c2b78cb5177cded00f742eb7f35aa0f9e37baf
src/webui/master/static/js/ui-bootstrap-tpls-0.7.0.min.js d2da4e20ebd5bb5b6f70fc785ff42cf3c2e7e32c
src/webui/master/static/js/ui-bootstrap-tpls-0.9.0.min.js PRE-CREATION
src/webui/master/static/offers.html 215d65e1ad30fb0df06bcf05cec797d60672ec66
src/webui/master/static/slave.html f30d914e4b43b5d4579c52053f9c0e04089a3adf
src/webui/master/static/slave_executor.html 519847c0de077717c88c4d35804ad40d339d4246
src/webui/master/static/slave_framework.html 947bab12eec8c3be5c3893b873b4b6378c8dcbbb
src/webui/master/static/slaves.html ef5b66290e65408312dcf1e59221ee9517b37203
Diff: https://reviews.apache.org/r/16798/diff/
Testing
-------
Thanks,
Thomas Rampelberg
Re: Review Request 16798: Updated to bootstrap-3.0.3.
Posted by Thomas Rampelberg <th...@saunter.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16798/
-----------------------------------------------------------
(Updated Jan. 10, 2014, 11:52 p.m.)
Review request for mesos and Ross Allen.
Repository: mesos-git
Description
-------
Updated to bootstrap-3.0.3.
Diffs
-----
src/webui/master/static/browse.html fe8be009fc548d7b0ff62032ab284fc19e3ea2c7
src/webui/master/static/css/bootstrap-2.3.2.min.css b6428e695860151f82076e87810fe2d133339c2a
src/webui/master/static/css/bootstrap-3.0.3.min.css PRE-CREATION
src/webui/master/static/css/bootstrap-responsive-2.3.2.min.css f4ede63f32e2ec803876a38efac05dd49acc4684
src/webui/master/static/framework.html 72e14dfb58895e43a10f10c139a983a78b3e8878
src/webui/master/static/frameworks.html 39e7883ffe001ff33ed1b35108c893fa8ff1f92d
src/webui/master/static/home.html fb3a38e94c30487c9b7e50c65c73b7af29999c3f
src/webui/master/static/index.html 7133ecdc77650cd31f9a80edfe2d190935f94846
src/webui/master/static/js/ui-bootstrap-tpls-0.7.0.js 08c2b78cb5177cded00f742eb7f35aa0f9e37baf
src/webui/master/static/js/ui-bootstrap-tpls-0.7.0.min.js d2da4e20ebd5bb5b6f70fc785ff42cf3c2e7e32c
src/webui/master/static/js/ui-bootstrap-tpls-0.9.0.min.js PRE-CREATION
src/webui/master/static/offers.html 215d65e1ad30fb0df06bcf05cec797d60672ec66
src/webui/master/static/slave.html f30d914e4b43b5d4579c52053f9c0e04089a3adf
src/webui/master/static/slave_executor.html 519847c0de077717c88c4d35804ad40d339d4246
src/webui/master/static/slave_framework.html 947bab12eec8c3be5c3893b873b4b6378c8dcbbb
src/webui/master/static/slaves.html ef5b66290e65408312dcf1e59221ee9517b37203
Diff: https://reviews.apache.org/r/16798/diff/
Testing
-------
Thanks,
Thomas Rampelberg