You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/05/23 00:48:02 UTC
[GitHub] [spark] panbingkun opened a new pull request, #36631: [MINOR] Remove redundant collection conversion toMap
panbingkun opened a new pull request, #36631:
URL: https://github.com/apache/spark/pull/36631
### What changes were proposed in this pull request?
Remove redundant collection conversion toMap.
### Why are the changes needed?
Cleanup
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
N/A
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #36631: [MINOR] Remove redundant collection conversion toMap
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on PR #36631:
URL: https://github.com/apache/spark/pull/36631#issuecomment-1134069884
Can one of the admins verify this patch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] panbingkun commented on a diff in pull request #36631: [MINOR] Remove redundant collection conversion toMap
Posted by GitBox <gi...@apache.org>.
panbingkun commented on code in PR #36631:
URL: https://github.com/apache/spark/pull/36631#discussion_r878980880
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala:
##########
@@ -1229,7 +1229,7 @@ class Analyzer(override val catalogManager: CatalogManager)
val partCols = partitionColumnNames(r.table)
validatePartitionSpec(partCols, i.partitionSpec)
- val staticPartitions = i.partitionSpec.filter(_._2.isDefined).mapValues(_.get).toMap
+ val staticPartitions = i.partitionSpec.filter(_._2.isDefined).mapValues(_.get)
Review Comment:
i will close it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a diff in pull request #36631: [MINOR] Remove redundant collection conversion toMap
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on code in PR #36631:
URL: https://github.com/apache/spark/pull/36631#discussion_r878971236
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala:
##########
@@ -1229,7 +1229,7 @@ class Analyzer(override val catalogManager: CatalogManager)
val partCols = partitionColumnNames(r.table)
validatePartitionSpec(partCols, i.partitionSpec)
- val staticPartitions = i.partitionSpec.filter(_._2.isDefined).mapValues(_.get).toMap
+ val staticPartitions = i.partitionSpec.filter(_._2.isDefined).mapValues(_.get)
Review Comment:
I remember this was for Scala 2.13 compliance. Does it work with Scala 2.13?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] panbingkun closed pull request #36631: [MINOR] Remove redundant collection conversion toMap
Posted by GitBox <gi...@apache.org>.
panbingkun closed pull request #36631: [MINOR] Remove redundant collection conversion toMap
URL: https://github.com/apache/spark/pull/36631
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org