PATCH: Regression tests: wrong order of arguments to compare_trees

[Julian Foad <ju...@btopenworld.com>]

[[[
In the regression tests, fix the order of arguments to compare_trees and
display_trees where it was wrong.  This only affects the sense of the error
message that is produced when a test fails: sometimes the "expected output" and
"actual output" were transposed.

* subversion/tests/clients/cmdline/prop_tests.py
  (make_local_props): Fix order of args to compare_trees.
* subversion/tests/clients/cmdline/svntest/actions.py
  (run_and_verify_merge): Fix order of args to compare_trees.
  (run_and_verify_commit): Change misleading variable name 'expected_tree'
    to 'mytree'.  Fix order of args to display_trees.
]]]

Patch attached for review.

Note that the order of arguments is different between compare_trees(actual, expected, ...) and display_trees(..., expected, actual).  It would be good to make them the same.  Changing compare_trees to the other way would be best in terms of matching the desired order of output messages, but would be a much more extensive change.  Changing display_trees would be relatively easy and localised.  I don't have the will to do either of these right now.

- Julian

Re: PATCH: Regression tests: wrong order of arguments to compare_trees

[Julian Foad <ju...@btopenworld.com>]

Julian Foad wrote:
> [[[
> In the regression tests, fix the order of arguments to compare_trees and
> display_trees where it was wrong.  This only affects the sense of the error
> message that is produced when a test fails: sometimes the "expected output" and
> "actual output" were transposed.

Committed in r7742.  (I am fairly confident of it, so have not waited for comments.)

- Julian


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org