You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@commons.apache.org by si...@apache.org on 2011/04/21 07:52:09 UTC

svn commit: r1095599 - /commons/proper/cli/trunk/src/main/java/org/apache/commons/cli/Options.java

Author: simonetripodi
Date: Thu Apr 21 05:52:09 2011
New Revision: 1095599

URL: http://svn.apache.org/viewvc?rev=1095599&view=rev
Log:
OptionGroup.getOptions() already returns a Collection<Option> so there's no need to involve type cast

Modified:
    commons/proper/cli/trunk/src/main/java/org/apache/commons/cli/Options.java

Modified: commons/proper/cli/trunk/src/main/java/org/apache/commons/cli/Options.java
URL: http://svn.apache.org/viewvc/commons/proper/cli/trunk/src/main/java/org/apache/commons/cli/Options.java?rev=1095599&r1=1095598&r2=1095599&view=diff
==============================================================================
--- commons/proper/cli/trunk/src/main/java/org/apache/commons/cli/Options.java (original)
+++ commons/proper/cli/trunk/src/main/java/org/apache/commons/cli/Options.java Thu Apr 21 05:52:09 2011
@@ -69,7 +69,7 @@ public class Options implements Serializ
      */
     public Options addOptionGroup(OptionGroup group)
     {
-        Iterator options = group.getOptions().iterator();
+        Iterator<Option> options = group.getOptions().iterator();
 
         if (group.isRequired())
         {
@@ -78,7 +78,7 @@ public class Options implements Serializ
 
         while (options.hasNext())
         {
-            Option option = (Option) options.next();
+            Option option = options.next();
 
             // an Option cannot be required if it is in an
             // OptionGroup, either the group is required or