You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/02/09 12:43:00 UTC
[GitHub] [spark] cloud-fan commented on a change in pull request #35265: [WIP][SPARK-37888][SQL][TESTS] Unify v1 and v2 DESCRIBE TABLE tests
cloud-fan commented on a change in pull request #35265:
URL: https://github.com/apache/spark/pull/35265#discussion_r802621258
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveSessionCatalog.scala
##########
@@ -122,7 +122,8 @@ class ResolveSessionCatalog(val catalogManager: CatalogManager)
// Use v1 command to describe (temp) view, as v2 catalog doesn't support view yet.
case DescribeRelation(
- ResolvedV1TableOrViewIdentifier(ident), partitionSpec, isExtended, output) =>
+ ResolvedV1TableOrViewIdentifier(ident), partitionSpec, isExtended, output)
+ if conf.useV1Command =>
Review comment:
I think we should still use v1 command for views.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org