geronimo-health provides by detault /health endpoint without application(endpoint) prefix

[Cesar Hernandez <ce...@gmail.com>]

Hi list,

I created the ticket https://issues.apache.org/jira/browse/GERONIMO-6736 to
gather feedback about this proposal about making geronimo-health to be
aligned with rest of implementation with the http://HOST:PORT/health format
instead of http://localhost:8080/<yourapp>/health.

Notice that even the TCK doesn't cover this scenario I think common
agreement among implementation was already done in order to expose the
http://HOST:PORT/health format.

What do you think?

-- 
Atentamente:
César Hernández.

Re: geronimo-health provides by detault /health endpoint without application(endpoint) prefix

[Romain Manni-Bucau <rm...@gmail.com>]

Hello Cesar,

To align on jaxrs - the solid base of the frontend of microprofile - all
implementations respect jaxrs config for their endpoints and we try to
respect webapp context as well to ensure we support multiple apps in the
same jvm.

Tck and mp as a general rule tend to assume application path is empty and
webapp context is root which is compatible with both statements.

On an impl point of view, replacing jaxrs endpoints by servlet - configured
by default to current setup since we are already in the wild/prod since a
long time - has the impact to require a manual integration of all spec
altogether (take openapi for instance which works ootb being jaxrs aligned
and does not being servlet based since endpoints are not seen).

Finally microprofile has jaxrs as lowest transport layer so we would reduce
our portability or we would go with filters to replace our endpoints and
therefore the customizations (all jaxrs extensions oike body writers,
filters etc) would then be harder.

So at the end we can surely add a config to refine the endpoint but im not
sure changing it will benefit to the user sufficiently to be worth it, in
particular since it does not help much in the main microprofile
environments (k8s and friends).

Hope it makes sense.

Le ven. 28 juin 2019 à 20:54, Cesar Hernandez <ce...@gmail.com> a
écrit :

> Hi list,
>
> I created the ticket https://issues.apache.org/jira/browse/GERONIMO-6736
> to gather feedback about this proposal about making geronimo-health to be
> aligned with rest of implementation with the http://HOST:PORT/health
> format instead of http://localhost:8080/<yourapp>/health.
>
> Notice that even the TCK doesn't cover this scenario I think common
> agreement among implementation was already done in order to expose the
> http://HOST:PORT/health format.
>
> What do you think?
>
> --
> Atentamente:
> César Hernández.
>