You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2021/03/02 18:59:33 UTC

[GitHub] [tvm] d-smirnov edited a comment on pull request #7564: [BYOC] Exclude external params from Graph Runtime

d-smirnov edited a comment on pull request #7564:
URL: https://github.com/apache/tvm/pull/7564#issuecomment-789136074


   I noticed that there is a check implemented for demanding codegen_name to be placed first ([utils.h](https://github.com/apache/tvm/blob/633ee118efecd04efb4be9bf6053deae6e8fac3b/src/relay/backend/utils.h#L89)) in case of external codegen uses its own implementation of ConstUpdater. Looks to me now that I am on a safe side with current patch


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org