You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@kyuubi.apache.org by GitBox <gi...@apache.org> on 2022/06/08 15:15:34 UTC

[GitHub] [incubator-kyuubi] pan3793 commented on a diff in pull request #2827: [BUILD][TEST] Move Hive integration test from kyuubi-server to kyuubi-hive-it

pan3793 commented on code in PR #2827:
URL: https://github.com/apache/incubator-kyuubi/pull/2827#discussion_r892516820


##########
integration-tests/kyuubi-flink-it/src/test/scala/org/apache/kyuubi/it/flink/operation/FlinkOperationSuite.scala:
##########
@@ -17,33 +17,20 @@
 
 package org.apache.kyuubi.it.flink.operation
 
-import java.io.File
-import java.nio.file.Paths
-
-import org.apache.kyuubi.{HADOOP_COMPILE_VERSION, SCALA_COMPILE_VERSION, Utils}
 import org.apache.kyuubi.config.KyuubiConf
-import org.apache.kyuubi.config.KyuubiConf.{ENGINE_TYPE, KYUUBI_ENGINE_ENV_PREFIX}
+import org.apache.kyuubi.config.KyuubiConf.{ENGINE_TYPE, KYUUBI_HOME}
 import org.apache.kyuubi.it.flink.WithKyuubiServerAndFlinkMiniCluster
 import org.apache.kyuubi.operation.HiveJDBCTestHelper
 import org.apache.kyuubi.operation.meta.ResultSetSchemaConstant.TABLE_CAT
 
-class FlinkOperationSuite extends WithKyuubiServerAndFlinkMiniCluster with HiveJDBCTestHelper {
-  val kyuubiHome: String = Utils.getCodeSourceLocation(getClass).split("integration-tests")(0)
-  val hadoopClasspath: String = Paths.get(
-    kyuubiHome,
-    "externals",
-    "kyuubi-flink-sql-engine",
-    "target",
-    s"scala-$SCALA_COMPILE_VERSION",
-    "jars").toAbsolutePath.toString
+class FlinkOperationSuite extends WithKyuubiServerAndFlinkMiniCluster
+  with HiveJDBCTestHelper {
+
   override val conf: KyuubiConf = KyuubiConf()
+    .set(KYUUBI_HOME, kyuubiHome)
     .set(ENGINE_TYPE, "FLINK_SQL")
     .set("flink.parallelism.default", "6")
-    .set(
-      s"$KYUUBI_ENGINE_ENV_PREFIX.FLINK_HADOOP_CLASSPATH",
-      s"$hadoopClasspath${File.separator}" +
-        s"hadoop-client-api-$HADOOP_COMPILE_VERSION.jar${File.pathSeparator}" +
-        s"$hadoopClasspath${File.separator}hadoop-client-runtime-$HADOOP_COMPILE_VERSION.jar")
+  // .set(s"$KYUUBI_ENGINE_ENV_PREFIX.FLINK_HADOOP_CLASSPATH", hadoopClasspath)

Review Comment:
   Still WIP



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org