You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@thrift.apache.org by dc...@apache.org on 2019/10/18 21:25:41 UTC

[thrift] branch master updated: Update Java dependencies

This is an automated email from the ASF dual-hosted git repository.

dcelasun pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/thrift.git


The following commit(s) were added to refs/heads/master by this push:
     new 76fa8c9  Update Java dependencies
76fa8c9 is described below

commit 76fa8c9a81621aae254e10c19c68b31b41f5b4b7
Author: D. Can Celasun <ca...@dcc.im>
AuthorDate: Fri Oct 18 15:15:45 2019 +0100

    Update Java dependencies
    
    Update most dependencies to their latest versions, replace findbugs with
    spotbugs as the former is dead and was replaced with the latter.
    
    Fixes THRIFT-4937.
    
    Client: java
---
 lib/java/build.gradle                    |  6 ++++++
 lib/java/gradle.properties               |  8 ++++----
 lib/java/gradle/codeQualityChecks.gradle | 13 +++++++++----
 3 files changed, 19 insertions(+), 8 deletions(-)

diff --git a/lib/java/build.gradle b/lib/java/build.gradle
index 5f0d278..9184f7b 100644
--- a/lib/java/build.gradle
+++ b/lib/java/build.gradle
@@ -36,6 +36,12 @@ plugins {
     id 'maven'
     id 'signing'
     id 'com.github.johnrengelman.shadow' version '4.0.4'
+    id "com.github.spotbugs" version "2.0.0"
+}
+
+ext {
+    // https://github.com/spotbugs/spotbugs-gradle-plugin/issues/32#issuecomment-409951172
+    SpotBugsTask = com.github.spotbugs.SpotBugsTask
 }
 
 description = 'Apache Thrift Java Library'
diff --git a/lib/java/gradle.properties b/lib/java/gradle.properties
index c5d2a1b..8559464 100644
--- a/lib/java/gradle.properties
+++ b/lib/java/gradle.properties
@@ -25,10 +25,10 @@ maven-repository-url=https://repository.apache.org/service/local/staging/deploy/
 maven-repository-id=apache.releases.https
 
 # Dependency versions
-httpclient.version=4.5.6
-httpcore.version=4.4.1
-slf4j.version=1.7.25
+httpclient.version=4.5.10
+httpcore.version=4.4.12
+slf4j.version=1.7.28
 servlet.version=2.5
 junit.version=4.12
-mockito.version=1.9.5
+mockito.version=1.10.19
 javax.annotation.version=1.3.2
diff --git a/lib/java/gradle/codeQualityChecks.gradle b/lib/java/gradle/codeQualityChecks.gradle
index 1ff1c29..b066287 100644
--- a/lib/java/gradle/codeQualityChecks.gradle
+++ b/lib/java/gradle/codeQualityChecks.gradle
@@ -3,18 +3,23 @@
 // Configure the Gradle code quality plugins here.
 //
 
-apply plugin: 'findbugs'
+dependencies {
+    spotbugs configurations.spotbugsPlugins.dependencies
+    spotbugsPlugins 'com.h3xstream.findsecbugs:findsecbugs-plugin:1.8.0'
+}
+
+apply plugin: 'com.github.spotbugs'
 
-findbugs {
+spotbugs{
     ignoreFailures = true
-    toolVersion = '3.0.1'
+    toolVersion = '3.1.12'
     sourceSets = [ sourceSets.main ]
     effort = 'max'
     reportLevel = 'low'
     excludeFilter = file('code_quality_tools/findbugs-filter.xml')
 }
 
-tasks.withType(FindBugs) {
+tasks.withType(SpotBugsTask) {
     reports {
         text.enabled = false
         html.enabled = true