You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by "rtucker85 (via GitHub)" <gi...@apache.org> on 2024/06/17 01:56:53 UTC

[PR] drivers/can/sja1000: fix Rx buffer pointer issue [nuttx]

rtucker85 opened a new pull request, #12507:
URL: https://github.com/apache/nuttx/pull/12507

   ## Summary
   Fix SJA1000 Rx buffer pointer issue.
   
   On the SJA1000_FDTOL IP implementation of this controller, if a buffer release is performed with nothing in the Rx FIFO, the internal FIFO pointers wrap around and the controller never recovers.
   
   This patch removes the call to release the buffer on initialisation which fixes this issue and should also be safe for all other implementations of this controller as a reset of the controller clears the FIFO. 
   
   ## Impact
   Any system using this common SJA1000 driver.
   
   ## Testing
   Built and tested on the [Digilent ARTY_A7](https://digilent.com/shop/arty-a7-artix-7-fpga-development-board/) development board with an [SJA1000_FDTOL](https://gitlab.fel.cvut.cz/canbus/zynq/sja1000-fdtol) IP core integrated.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] drivers/can/sja1000: fix Rx buffer pointer issue [nuttx]

Posted by "xiaoxiang781216 (via GitHub)" <gi...@apache.org>.
xiaoxiang781216 merged PR #12507:
URL: https://github.com/apache/nuttx/pull/12507


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org