You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2022/08/12 10:34:26 UTC
[GitHub] [rocketmq-mqtt] wangzhiwei1314 opened a new pull request, #138: add MqttMessageFactory and optimize codes.
wangzhiwei1314 opened a new pull request, #138:
URL: https://github.com/apache/rocketmq-mqtt/pull/138
add MqttMessageFactory and optimize codes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-mqtt] wangzhiwei1314 commented on a diff in pull request #138: add MqttMessageFactory and optimize codes.
Posted by GitBox <gi...@apache.org>.
wangzhiwei1314 commented on code in PR #138:
URL: https://github.com/apache/rocketmq-mqtt/pull/138#discussion_r978238343
##########
mqtt-cs/src/main/java/org/apache/rocketmq/mqtt/cs/protocol/mqtt/facotry/MqttMessageFactory.java:
##########
@@ -0,0 +1,78 @@
+package org.apache.rocketmq.mqtt.cs.protocol.mqtt.facotry;
Review Comment:
> lack of license header.
Thanks,I have fixed this problem.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-mqtt] wangzhiwei1314 commented on pull request #138: add MqttMessageFactory and optimize codes.
Posted by GitBox <gi...@apache.org>.
wangzhiwei1314 commented on PR #138:
URL: https://github.com/apache/rocketmq-mqtt/pull/138#issuecomment-1255760696
Thanks for your review. Now I have fixed these problems.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-mqtt] ShannonDing commented on a diff in pull request #138: add MqttMessageFactory and optimize codes.
Posted by GitBox <gi...@apache.org>.
ShannonDing commented on code in PR #138:
URL: https://github.com/apache/rocketmq-mqtt/pull/138#discussion_r951327673
##########
mqtt-cs/src/main/java/org/apache/rocketmq/mqtt/cs/protocol/mqtt/facotry/MqttMessageFactory.java:
##########
@@ -0,0 +1,78 @@
+package org.apache.rocketmq.mqtt.cs.protocol.mqtt.facotry;
+
+import io.netty.buffer.ByteBuf;
+import io.netty.buffer.Unpooled;
+import io.netty.handler.codec.mqtt.*;
Review Comment:
import what used in detail.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-mqtt] DongyuanPan commented on pull request #138: add MqttMessageFactory and optimize codes.
Posted by GitBox <gi...@apache.org>.
DongyuanPan commented on PR #138:
URL: https://github.com/apache/rocketmq-mqtt/pull/138#issuecomment-1216066357
Please open a new issue to explain why you want to do this, and associate this PR with the issue
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-mqtt] wangzhiwei1314 commented on a diff in pull request #138: add MqttMessageFactory and optimize codes.
Posted by GitBox <gi...@apache.org>.
wangzhiwei1314 commented on code in PR #138:
URL: https://github.com/apache/rocketmq-mqtt/pull/138#discussion_r978238410
##########
mqtt-cs/src/main/java/org/apache/rocketmq/mqtt/cs/protocol/mqtt/facotry/MqttMessageFactory.java:
##########
@@ -0,0 +1,78 @@
+package org.apache.rocketmq.mqtt.cs.protocol.mqtt.facotry;
+
+import io.netty.buffer.ByteBuf;
+import io.netty.buffer.Unpooled;
+import io.netty.handler.codec.mqtt.*;
Review Comment:
Thanks,I have fixed this problem.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-mqtt] wangzhiwei1314 commented on pull request #138: add MqttMessageFactory and optimize codes.
Posted by GitBox <gi...@apache.org>.
wangzhiwei1314 commented on PR #138:
URL: https://github.com/apache/rocketmq-mqtt/pull/138#issuecomment-1255983726
> please fix CI
I fixed CI errors.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-mqtt] ShannonDing commented on a diff in pull request #138: add MqttMessageFactory and optimize codes.
Posted by GitBox <gi...@apache.org>.
ShannonDing commented on code in PR #138:
URL: https://github.com/apache/rocketmq-mqtt/pull/138#discussion_r951327213
##########
mqtt-cs/src/main/java/org/apache/rocketmq/mqtt/cs/protocol/mqtt/facotry/MqttMessageFactory.java:
##########
@@ -0,0 +1,78 @@
+package org.apache.rocketmq.mqtt.cs.protocol.mqtt.facotry;
Review Comment:
lack of license header.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-mqtt] DongyuanPan commented on pull request #138: add MqttMessageFactory and optimize codes.
Posted by GitBox <gi...@apache.org>.
DongyuanPan commented on PR #138:
URL: https://github.com/apache/rocketmq-mqtt/pull/138#issuecomment-1255793878
please fix CI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-mqtt] DongyuanPan commented on pull request #138: add MqttMessageFactory and optimize codes.
Posted by GitBox <gi...@apache.org>.
DongyuanPan commented on PR #138:
URL: https://github.com/apache/rocketmq-mqtt/pull/138#issuecomment-1257407122
LGTM
@ShannonDing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-mqtt] pingww merged pull request #138: add MqttMessageFactory and optimize codes.
Posted by GitBox <gi...@apache.org>.
pingww merged PR #138:
URL: https://github.com/apache/rocketmq-mqtt/pull/138
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org