You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-dev@hadoop.apache.org by "stack (JIRA)" <ji...@apache.org> on 2007/10/11 07:52:50 UTC

[jira] Created: (HADOOP-2029) [hbase] TestLogRolling fails too often in patch and nightlies

[hbase] TestLogRolling fails too often in patch and nightlies
-------------------------------------------------------------

                 Key: HADOOP-2029
                 URL: https://issues.apache.org/jira/browse/HADOOP-2029
             Project: Hadoop
          Issue Type: Bug
          Components: contrib/hbase
            Reporter: stack
            Priority: Minor


Looks like we fixed TestRegionServerAbort yesterday.  Now TestLogRolling has been acting up of late.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-2029) [hbase] TestLogRolling fails too often in patch and nightlies

Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-2029?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12534420 ] 

Hadoop QA commented on HADOOP-2029:
-----------------------------------

+1 overall.  Here are the results of testing the latest attachment 
http://issues.apache.org/jira/secure/attachment/12367658/logrolling-v3.patch
against trunk revision r584212.

    @author +1.  The patch does not contain any @author tags.

    javadoc +1.  The javadoc tool did not generate any warning messages.

    javac +1.  The applied patch does not generate any new compiler warnings.

    findbugs +1.  The patch does not introduce any new Findbugs warnings.

    core tests +1.  The patch passed core unit tests.

    contrib tests +1.  The patch passed contrib unit tests.

Test results: http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/937/testReport/
Findbugs warnings: http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/937/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/937/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/937/console

This message is automatically generated.

> [hbase] TestLogRolling fails too often in patch and nightlies
> -------------------------------------------------------------
>
>                 Key: HADOOP-2029
>                 URL: https://issues.apache.org/jira/browse/HADOOP-2029
>             Project: Hadoop
>          Issue Type: Bug
>          Components: contrib/hbase
>            Reporter: stack
>            Assignee: stack
>            Priority: Minor
>             Fix For: 0.15.0
>
>         Attachments: hlogrolling.patch, logrolling-v2.patch, logrolling-v3.patch
>
>
> Looks like we fixed TestRegionServerAbort yesterday.  Now TestLogRolling has been acting up of late.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-2029) [hbase] TestLogRolling fails too often in patch and nightlies

Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-2029?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12534166 ] 

Hadoop QA commented on HADOOP-2029:
-----------------------------------

+1 overall.  Here are the results of testing the latest attachment 
http://issues.apache.org/jira/secure/attachment/12367597/logrolling-v2.patch
against trunk revision r583945.

    @author +1.  The patch does not contain any @author tags.

    javadoc +1.  The javadoc tool did not generate any warning messages.

    javac +1.  The applied patch does not generate any new compiler warnings.

    findbugs +1.  The patch does not introduce any new Findbugs warnings.

    core tests +1.  The patch passed core unit tests.

    contrib tests +1.  The patch passed contrib unit tests.

Test results: http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/928/testReport/
Findbugs warnings: http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/928/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/928/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/928/console

This message is automatically generated.

> [hbase] TestLogRolling fails too often in patch and nightlies
> -------------------------------------------------------------
>
>                 Key: HADOOP-2029
>                 URL: https://issues.apache.org/jira/browse/HADOOP-2029
>             Project: Hadoop
>          Issue Type: Bug
>          Components: contrib/hbase
>            Reporter: stack
>            Assignee: stack
>            Priority: Minor
>             Fix For: 0.15.0
>
>         Attachments: hlogrolling.patch, logrolling-v2.patch
>
>
> Looks like we fixed TestRegionServerAbort yesterday.  Now TestLogRolling has been acting up of late.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-2029) [hbase] TestLogRolling fails too often in patch and nightlies

Posted by "stack (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-2029?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

stack updated HADOOP-2029:
--------------------------

    Status: Patch Available  (was: Open)

Builds and passes tests locally.  Trying hudson.

> [hbase] TestLogRolling fails too often in patch and nightlies
> -------------------------------------------------------------
>
>                 Key: HADOOP-2029
>                 URL: https://issues.apache.org/jira/browse/HADOOP-2029
>             Project: Hadoop
>          Issue Type: Bug
>          Components: contrib/hbase
>            Reporter: stack
>            Priority: Minor
>         Attachments: hlogrolling.patch
>
>
> Looks like we fixed TestRegionServerAbort yesterday.  Now TestLogRolling has been acting up of late.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-2029) [hbase] TestLogRolling fails too often in patch and nightlies

Posted by "stack (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-2029?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

stack updated HADOOP-2029:
--------------------------

    Resolution: Fixed
        Status: Resolved  (was: Patch Available)

Resolving for second time.

> [hbase] TestLogRolling fails too often in patch and nightlies
> -------------------------------------------------------------
>
>                 Key: HADOOP-2029
>                 URL: https://issues.apache.org/jira/browse/HADOOP-2029
>             Project: Hadoop
>          Issue Type: Bug
>          Components: contrib/hbase
>            Reporter: stack
>            Assignee: stack
>            Priority: Minor
>             Fix For: 0.15.0
>
>         Attachments: hlogrolling.patch, logrolling-v2.patch
>
>
> Looks like we fixed TestRegionServerAbort yesterday.  Now TestLogRolling has been acting up of late.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-2029) [hbase] TestLogRolling fails too often in patch and nightlies

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-2029?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12534326 ] 

Hudson commented on HADOOP-2029:
--------------------------------

Integrated in Hadoop-Nightly #269 (See [http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Nightly/269/])

> [hbase] TestLogRolling fails too often in patch and nightlies
> -------------------------------------------------------------
>
>                 Key: HADOOP-2029
>                 URL: https://issues.apache.org/jira/browse/HADOOP-2029
>             Project: Hadoop
>          Issue Type: Bug
>          Components: contrib/hbase
>            Reporter: stack
>            Assignee: stack
>            Priority: Minor
>             Fix For: 0.15.0
>
>         Attachments: hlogrolling.patch, logrolling-v2.patch
>
>
> Looks like we fixed TestRegionServerAbort yesterday.  Now TestLogRolling has been acting up of late.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-2029) [hbase] TestLogRolling fails too often in patch and nightlies

Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-2029?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12533984 ] 

Hadoop QA commented on HADOOP-2029:
-----------------------------------

+1 overall.  Here are the results of testing the latest attachment 
http://issues.apache.org/jira/secure/attachment/12367549/hlogrolling.patch
against trunk revision r583424.

    @author +1.  The patch does not contain any @author tags.

    javadoc +1.  The javadoc tool did not generate any warning messages.

    javac +1.  The applied patch does not generate any new compiler warnings.

    findbugs +1.  The patch does not introduce any new Findbugs warnings.

    core tests +1.  The patch passed core unit tests.

    contrib tests +1.  The patch passed contrib unit tests.

Test results: http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/920/testReport/
Findbugs warnings: http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/920/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/920/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/920/console

This message is automatically generated.

> [hbase] TestLogRolling fails too often in patch and nightlies
> -------------------------------------------------------------
>
>                 Key: HADOOP-2029
>                 URL: https://issues.apache.org/jira/browse/HADOOP-2029
>             Project: Hadoop
>          Issue Type: Bug
>          Components: contrib/hbase
>            Reporter: stack
>            Priority: Minor
>         Attachments: hlogrolling.patch
>
>
> Looks like we fixed TestRegionServerAbort yesterday.  Now TestLogRolling has been acting up of late.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Reopened: (HADOOP-2029) [hbase] TestLogRolling fails too often in patch and nightlies

Posted by "stack (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-2029?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

stack reopened HADOOP-2029:
---------------------------


Reopening for 3rd time.  Patch build #932 failed in TestSplitLog

> [hbase] TestLogRolling fails too often in patch and nightlies
> -------------------------------------------------------------
>
>                 Key: HADOOP-2029
>                 URL: https://issues.apache.org/jira/browse/HADOOP-2029
>             Project: Hadoop
>          Issue Type: Bug
>          Components: contrib/hbase
>            Reporter: stack
>            Assignee: stack
>            Priority: Minor
>             Fix For: 0.15.0
>
>         Attachments: hlogrolling.patch, logrolling-v2.patch
>
>
> Looks like we fixed TestRegionServerAbort yesterday.  Now TestLogRolling has been acting up of late.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-2029) [hbase] TestLogRolling fails too often in patch and nightlies

Posted by "stack (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-2029?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

stack updated HADOOP-2029:
--------------------------

    Attachment: logrolling-v3.patch

Add logging.  New supposition is that an updating client thread got a region before it was moved to retiring queue inside of HRegionServer#batchUpdate.  Thread then moves into HRegion#startUpdate and blocks on a read lock while concurrently region is being shut down.  Moved check on whether region is closed inside the read lock rather than check before.

> [hbase] TestLogRolling fails too often in patch and nightlies
> -------------------------------------------------------------
>
>                 Key: HADOOP-2029
>                 URL: https://issues.apache.org/jira/browse/HADOOP-2029
>             Project: Hadoop
>          Issue Type: Bug
>          Components: contrib/hbase
>            Reporter: stack
>            Assignee: stack
>            Priority: Minor
>             Fix For: 0.15.0
>
>         Attachments: hlogrolling.patch, logrolling-v2.patch, logrolling-v3.patch
>
>
> Looks like we fixed TestRegionServerAbort yesterday.  Now TestLogRolling has been acting up of late.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-2029) [hbase] TestLogRolling fails too often in patch and nightlies

Posted by "stack (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-2029?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

stack updated HADOOP-2029:
--------------------------

       Resolution: Fixed
    Fix Version/s: 0.15.0
         Assignee: stack
           Status: Resolved  (was: Patch Available)

Committed.  Resolving.

> [hbase] TestLogRolling fails too often in patch and nightlies
> -------------------------------------------------------------
>
>                 Key: HADOOP-2029
>                 URL: https://issues.apache.org/jira/browse/HADOOP-2029
>             Project: Hadoop
>          Issue Type: Bug
>          Components: contrib/hbase
>            Reporter: stack
>            Assignee: stack
>            Priority: Minor
>             Fix For: 0.15.0
>
>         Attachments: hlogrolling.patch
>
>
> Looks like we fixed TestRegionServerAbort yesterday.  Now TestLogRolling has been acting up of late.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-2029) [hbase] TestLogRolling fails too often in patch and nightlies

Posted by "stack (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-2029?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

stack updated HADOOP-2029:
--------------------------

    Attachment: hlogrolling.patch

HADOOP-2029 TestLogRolling fails too often in patch and nightlies builds.

M  src/contrib/hbase/src/test/org/apache/hadoop/hbase/TestLogRolling.java
    Emit count before loop and on a period so we can see what work remains.
M  src/contrib/hbase/src/java/org/apache/hadoop/hbase/HLog.java
    (rollWriter): Added handling of case where there are no elements in
    the map of lastSeqWritten (This happens if all regions have flushed
    but no writes have come in since).  
    (deleteLogFile): Added.
    (append): Changed it so that rather than record latest edit id,
    it only records the first.  Otherwise, could lose edits between
    oldest and latest since we were comparing latest figuring which
    log file to remove.

> [hbase] TestLogRolling fails too often in patch and nightlies
> -------------------------------------------------------------
>
>                 Key: HADOOP-2029
>                 URL: https://issues.apache.org/jira/browse/HADOOP-2029
>             Project: Hadoop
>          Issue Type: Bug
>          Components: contrib/hbase
>            Reporter: stack
>            Priority: Minor
>         Attachments: hlogrolling.patch
>
>
> Looks like we fixed TestRegionServerAbort yesterday.  Now TestLogRolling has been acting up of late.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-2029) [hbase] TestLogRolling fails too often in patch and nightlies

Posted by "stack (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-2029?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

stack updated HADOOP-2029:
--------------------------

       Resolution: Fixed
    Fix Version/s:     (was: 0.15.0)
                   0.16.0
           Status: Resolved  (was: Patch Available)

Haven't seen this issue in last few days.  Resolving.  Will reopen if happens again.

> [hbase] TestLogRolling fails too often in patch and nightlies
> -------------------------------------------------------------
>
>                 Key: HADOOP-2029
>                 URL: https://issues.apache.org/jira/browse/HADOOP-2029
>             Project: Hadoop
>          Issue Type: Bug
>          Components: contrib/hbase
>            Reporter: stack
>            Assignee: stack
>            Priority: Minor
>             Fix For: 0.16.0
>
>         Attachments: hlogrolling.patch, logrolling-v2.patch, logrolling-v3.patch
>
>
> Looks like we fixed TestRegionServerAbort yesterday.  Now TestLogRolling has been acting up of late.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-2029) [hbase] TestLogRolling fails too often in patch and nightlies

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-2029?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12534524 ] 

Hudson commented on HADOOP-2029:
--------------------------------

Integrated in Hadoop-Nightly #270 (See [http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Nightly/270/])

> [hbase] TestLogRolling fails too often in patch and nightlies
> -------------------------------------------------------------
>
>                 Key: HADOOP-2029
>                 URL: https://issues.apache.org/jira/browse/HADOOP-2029
>             Project: Hadoop
>          Issue Type: Bug
>          Components: contrib/hbase
>            Reporter: stack
>            Assignee: stack
>            Priority: Minor
>             Fix For: 0.15.0
>
>         Attachments: hlogrolling.patch, logrolling-v2.patch, logrolling-v3.patch
>
>
> Looks like we fixed TestRegionServerAbort yesterday.  Now TestLogRolling has been acting up of late.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Reopened: (HADOOP-2029) [hbase] TestLogRolling fails too often in patch and nightlies

Posted by "stack (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-2029?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

stack reopened HADOOP-2029:
---------------------------


Patch build #926 failed in log rolling test.  On examination, extra logging has uncovered our writing a region after it has closed.  This post-close write was lost but it was adding an entry in the lastSeqWrite map inside in HLog which was never going to be cleaned up.  Subsequent log rolls would not be cleaned because of the presence of htis entry.

> [hbase] TestLogRolling fails too often in patch and nightlies
> -------------------------------------------------------------
>
>                 Key: HADOOP-2029
>                 URL: https://issues.apache.org/jira/browse/HADOOP-2029
>             Project: Hadoop
>          Issue Type: Bug
>          Components: contrib/hbase
>            Reporter: stack
>            Assignee: stack
>            Priority: Minor
>             Fix For: 0.15.0
>
>         Attachments: hlogrolling.patch
>
>
> Looks like we fixed TestRegionServerAbort yesterday.  Now TestLogRolling has been acting up of late.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-2029) [hbase] TestLogRolling fails too often in patch and nightlies

Posted by "stack (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-2029?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

stack updated HADOOP-2029:
--------------------------

    Status: Patch Available  (was: Reopened)

Going to hudson again w/ patch version 3.

> [hbase] TestLogRolling fails too often in patch and nightlies
> -------------------------------------------------------------
>
>                 Key: HADOOP-2029
>                 URL: https://issues.apache.org/jira/browse/HADOOP-2029
>             Project: Hadoop
>          Issue Type: Bug
>          Components: contrib/hbase
>            Reporter: stack
>            Assignee: stack
>            Priority: Minor
>             Fix For: 0.15.0
>
>         Attachments: hlogrolling.patch, logrolling-v2.patch, logrolling-v3.patch
>
>
> Looks like we fixed TestRegionServerAbort yesterday.  Now TestLogRolling has been acting up of late.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-2029) [hbase] TestLogRolling fails too often in patch and nightlies

Posted by "stack (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-2029?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

stack updated HADOOP-2029:
--------------------------

    Status: Patch Available  (was: Reopened)

Trying hudson.

> [hbase] TestLogRolling fails too often in patch and nightlies
> -------------------------------------------------------------
>
>                 Key: HADOOP-2029
>                 URL: https://issues.apache.org/jira/browse/HADOOP-2029
>             Project: Hadoop
>          Issue Type: Bug
>          Components: contrib/hbase
>            Reporter: stack
>            Assignee: stack
>            Priority: Minor
>             Fix For: 0.15.0
>
>         Attachments: hlogrolling.patch, logrolling-v2.patch
>
>
> Looks like we fixed TestRegionServerAbort yesterday.  Now TestLogRolling has been acting up of late.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-2029) [hbase] TestLogRolling fails too often in patch and nightlies

Posted by "stack (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-2029?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

stack updated HADOOP-2029:
--------------------------

    Attachment: logrolling-v2.patch

Patch that prevents new writes after a close has started (Changes how startUpdate gets its regions.  Now it just checkes online regions.  Before it was checking online and retiring regions).

> [hbase] TestLogRolling fails too often in patch and nightlies
> -------------------------------------------------------------
>
>                 Key: HADOOP-2029
>                 URL: https://issues.apache.org/jira/browse/HADOOP-2029
>             Project: Hadoop
>          Issue Type: Bug
>          Components: contrib/hbase
>            Reporter: stack
>            Assignee: stack
>            Priority: Minor
>             Fix For: 0.15.0
>
>         Attachments: hlogrolling.patch, logrolling-v2.patch
>
>
> Looks like we fixed TestRegionServerAbort yesterday.  Now TestLogRolling has been acting up of late.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.