You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jclouds.apache.org by Richard Downer <no...@github.com> on 2013/11/11 15:14:05 UTC
[jclouds-labs-google] JCLOUDS-367: GCE nodes n>1 ignoring inboundPort
(#13)
The inboundPort settings of the first node in the group dictated the firewall configuration. Subsequent nodes added to the group had their inboundPort settings ignored.
GCE firewalls specify their "target" (VM instances) by means of tags - if a targetTag on a firewall matches the tag on an instance, the firewall's rules are allowed for the instance. This commit applies a tag for each requested inboundPort to new instances. Then, a firewall is created for each tag (if one does not already exist) which has 'allow' rules for the port.
You can merge this Pull Request by running:
git pull https://github.com/richardcloudsoft/jclouds-labs-google JCLOUDS-367
Or you can view, comment on it, or merge it online at:
https://github.com/jclouds/jclouds-labs-google/pull/13
-- Commit Summary --
* JCLOUDS-367: GCE nodes n>1 ignoring inboundPort
-- File Changes --
M google-compute-engine/src/main/java/org/jclouds/googlecomputeengine/compute/GoogleComputeEngineService.java (37)
M google-compute-engine/src/main/java/org/jclouds/googlecomputeengine/compute/GoogleComputeEngineServiceAdapter.java (40)
M google-compute-engine/src/main/java/org/jclouds/googlecomputeengine/compute/config/GoogleComputeEngineServiceContextModule.java (3)
A google-compute-engine/src/main/java/org/jclouds/googlecomputeengine/compute/functions/FirewallTagNamingConvention.java (64)
M google-compute-engine/src/main/java/org/jclouds/googlecomputeengine/compute/functions/InstanceInZoneToNodeMetadata.java (15)
M google-compute-engine/src/main/java/org/jclouds/googlecomputeengine/compute/strategy/CreateNodesWithGroupEncodedIntoNameThenAddToSet.java (80)
M google-compute-engine/src/main/java/org/jclouds/googlecomputeengine/domain/Firewall.java (5)
M google-compute-engine/src/test/java/org/jclouds/googlecomputeengine/compute/GoogleComputeEngineServiceExpectTest.java (64)
A google-compute-engine/src/test/resources/GoogleComputeEngineServiceExpectTest/firewall_list.json (37)
A google-compute-engine/src/test/resources/GoogleComputeEngineServiceExpectTest/network_get.json (10)
-- Patch Links --
https://github.com/jclouds/jclouds-labs-google/pull/13.patch
https://github.com/jclouds/jclouds-labs-google/pull/13.diff
Re: [jclouds-labs-google] JCLOUDS-367: GCE nodes n>1 ignoring
inboundPort (#13)
Posted by Andrew Phillips <no...@github.com>.
Closed #13.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/13
Re: [jclouds-labs-google] JCLOUDS-367: GCE nodes n>1 ignoring
inboundPort (#13)
Posted by Richard Downer <no...@github.com>.
Hi, can we get this reviewed and merged so that the Jira can be closed? It's the exact same fix that was done on the 1.6.x branch in https://github.com/jclouds/jclouds-labs/pull/33
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/13#issuecomment-28385871
Re: [jclouds-labs-google] JCLOUDS-367: GCE nodes n>1 ignoring
inboundPort (#13)
Posted by Andrew Phillips <no...@github.com>.
Committed to [master](https://git-wip-us.apache.org/repos/asf?p=jclouds-labs-google.git;a=commit;h=69756496bdb9e49fb69e802d97eadc1c17bc2af5). Thanks, @richardcloudsoft!
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/13#issuecomment-28390733
Re: [jclouds-labs-google] JCLOUDS-367: GCE nodes n>1 ignoring
inboundPort (#13)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-labs-google-pull-requests #19](https://jclouds.ci.cloudbees.com/job/jclouds-labs-google-pull-requests/19/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/13#issuecomment-28202781