[jira] [Commented] (HBASE-22781) Not suitable params of StoreScanner in the test case TestStoreScanner.testScanSameTimestamp

["Duo Zhang (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-22781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16899457#comment-16899457 ] 

Duo Zhang commented on HBASE-22781:
-----------------------------------

I think this is what we expect? For different timestamps obviously we will return the one with greater timestamp, as the default maxVersions is 1. Here we just want to confirm that even if we have same timestamps, we will still return only one kv.

> Not suitable params of StoreScanner in the test case TestStoreScanner.testScanSameTimestamp
> -------------------------------------------------------------------------------------------
>
>                 Key: HBASE-22781
>                 URL: https://issues.apache.org/jira/browse/HBASE-22781
>             Project: HBase
>          Issue Type: Bug
>          Components: test
>    Affects Versions: 2.0.0
>            Reporter: Zheng Wang
>            Assignee: Zheng Wang
>            Priority: Minor
>
> {code:java}
> public void testScanSameTimestamp() throws IOException {
>   // returns only 1 of these 2 even though same timestamp
>   KeyValue [] kvs = new KeyValue[] {
>       create("R1", "cf", "a", 1, KeyValue.Type.Put, "dont-care"),
>       create("R1", "cf", "a", 1, KeyValue.Type.Put, "dont-care"),
>   };
>   List<KeyValueScanner> scanners = Arrays.asList(
>       new KeyValueScanner[] {
>           new KeyValueScanFixture(CellComparator.getInstance(), kvs)
>       });
>   Scan scanSpec = new Scan().withStartRow(Bytes.toBytes("R1"));
>   // this only uses maxVersions (default=1) and TimeRange (default=all)
>   try (StoreScanner scan = new StoreScanner(scanSpec, scanInfo, getCols("a"), scanners)) {
>     List<Cell> results = new ArrayList<>();
>     assertEquals(true, scan.next(results));
>     assertEquals(1, results.size());
>     assertEquals(kvs[0], results.get(0));
>   }
> }
> {code}
>  
>  It will not to compare the timestamp of the two cells,because of the 'getCols("a")' limit only one column and one version(default).
> For example,modify the timestamp of the first cell to 2 can also pass.



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)