Re: [PR] [SPARK-53796][SDP] Add `extension` field to a few pipeline protos to support forward compatibility [spark]

["AnishMahto (via GitHub)" <gi...@apache.org>]

AnishMahto commented on code in PR #52514:
URL: https://github.com/apache/spark/pull/52514#discussion_r2417996244


##########
sql/connect/common/src/main/protobuf/spark/connect/pipelines.proto:
##########
@@ -235,6 +241,12 @@ message SourceCodeLocation {
   optional string file_name = 1;
   // The specific line number that this pipeline source code is located at, if applicable.
   optional int32 line_number = 2;
+
+  // Reserved field for protocol extensions.
+  // Used to support forward-compatibility by carrying additional fields
+  // that are not yet defined in this version of the proto. During planning, the
+  // engine will resolve and dispatch the concrete command contained in this field.
+  repeated google.protobuf.Any extension = 999;

Review Comment:
   Is this intentionally repeated, and if so why?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org