You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by sv...@apache.org on 2019/05/17 09:35:58 UTC

[wicket] branch master updated: WICKET-6667 change 'inputchange' to 'input' and log warning

This is an automated email from the ASF dual-hosted git repository.

svenmeier pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/wicket.git


The following commit(s) were added to refs/heads/master by this push:
     new 832ba30  WICKET-6667 change 'inputchange' to 'input' and log warning
832ba30 is described below

commit 832ba308d0d041436cc12a2099237a28cabd642a
Author: Sven Meier <sv...@apache.org>
AuthorDate: Fri May 17 11:32:35 2019 +0200

    WICKET-6667 change 'inputchange' to 'input' and log warning
---
 .../main/java/org/apache/wicket/ajax/AjaxEventBehavior.java   | 11 +++++++++++
 1 file changed, 11 insertions(+)

diff --git a/wicket-core/src/main/java/org/apache/wicket/ajax/AjaxEventBehavior.java b/wicket-core/src/main/java/org/apache/wicket/ajax/AjaxEventBehavior.java
index 23d8a4b..6fc040e 100644
--- a/wicket-core/src/main/java/org/apache/wicket/ajax/AjaxEventBehavior.java
+++ b/wicket-core/src/main/java/org/apache/wicket/ajax/AjaxEventBehavior.java
@@ -27,6 +27,8 @@ import org.apache.wicket.util.lang.Args;
 import org.apache.wicket.util.lang.Checks;
 import org.apache.wicket.util.string.Strings;
 import org.danekja.java.util.function.serializable.SerializableConsumer;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
 
 /**
  * An ajax behavior that is attached to a certain client-side (usually javascript) event, such as
@@ -62,6 +64,8 @@ import org.danekja.java.util.function.serializable.SerializableConsumer;
  */
 public abstract class AjaxEventBehavior extends AbstractDefaultAjaxBehavior
 {
+	private static final Logger LOGGER = LoggerFactory.getLogger(AjaxEventBehavior.class);
+
 	private static final long serialVersionUID = 1L;
 
 	private final String event;
@@ -76,6 +80,13 @@ public abstract class AjaxEventBehavior extends AbstractDefaultAjaxBehavior
 	{
 		Args.notEmpty(event, "event");
 
+		if ("inputchange".equals(event))
+		{
+			// TODO Wicket 10 remove (see WICKET-6667)
+			event = "input";
+			LOGGER.warn("Since version 9.0.0 Wicket no longer supports 'inputchange' events, please use 'input' instead");
+		}
+
 		this.event = event;
 	}