[GitHub] [flink] xintongsong opened a new pull request #10141: [FLINK-13986][runtime] Clean up legacy code for FLIP-49.

[GitBox <gi...@apache.org>]

xintongsong opened a new pull request #10141: [FLINK-13986][runtime] Clean up legacy code for FLIP-49.
URL: https://github.com/apache/flink/pull/10141
 
 
   ## What is the purpose of the change
   
   This PR switches on FLIP-49 task executor resource configurations, and cleans up codes for the legacy mode.
   
   This PR is based on #9801.
   
   ## Brief change log
   - 8f633ca0096ea14ff885025ab6e62115e5529992..52f8bc1e2ebbad5c4fab62ac20e8450f89743f9b: Commits of previous PR #9801.
   - 2f5f815c2ab2c097f97e64fa4530307dff537bcb..d76ecdb1bfac9a5863a757859b692af6ac434c1f: Hotfixes of code style clean-up and minor refactor.
   - 790d8ab58ce3a2e94e37b80961e317b3db774125..e2fe987c1e7224b103530d7a6de371a7cbc65680: Fix problems for FLIP-49 code path.
     - 790d8ab58ce3a2e94e37b80961e317b3db774125: Map deprecated config option `taskmanager.heap.size` and `taskmanager.heap.mb` to total process memory rather than total flink memory. This is more aligned with previous behaviors.
     - 6fc351c539c2ab12a0f30555e916107cd6c92086: Fix backwards compatibility for the legacy config option number of network buffers.
     - 961b783bc995d3d443cf05ff125b95d863dfcec2: Automatically set total flink memory size for local executions on `MiniCluster`.
     - 5e90cc61ca75db3065d2aa9595cb3edee71138a0: Use FLIP-49 configured managed memory size when creating resource manager.
     - 004b8dd99b0ab5d654a5e3020348acc65a6d0c1c: Map `ClusterSpecification#taskManagerMemoryMB` to task executor total process memory.
     - 90db245245c8baf83d94e542dd3bdfd968a52286: Use mesos task executor memory size configuration to overwrite FLIP-49 total process memory configuration.
     - 81dba41753e1dd41a93c75514af4124cd410b2cf: Fix task executor start-up script argument format problem.
     - e2fe987c1e7224b103530d7a6de371a7cbc65680: Set default value of task off-heap memory size to 1MB, to account for flink framework off-heap memory usage and avoid JVM direct OOM. **This commit should be reverted once framework off-heap memory is introduced.**
   - 0d1ce14b80f91cad8af268a564f8ce35b496225d: Set FLIP-49 configuration to default.
   - 0ab68d7ed8576eea0d6f2f69ee5188a1102a0168..94b02522c7255e6868c4eb5cd0712a2f2e86425b: Fix test cases failed due to switching to the new mode.
   - 00c04ca1e143dc0398af2c1d3a3530defaa95232..b8c5150651a760103e0ac9cfbfc3a1bb46f1e8ab: Remove legacy codes.
   
   ## Verifying this change
   
   - Fixes of FLIP-49 code path are already covered by existing test.
   - Legacy codes clean-ups do not require tests.
   - Overall verified with e2e tests.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (no)
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes)
     - The serializers: (no)
     - The runtime per-record code paths (performance sensitive): (no)
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes)
     - The S3 file system connector: (no)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (no)
     - If yes, how is the feature documented? (not applicable)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services