You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/02/04 08:14:57 UTC
[GitHub] [flink] Thesharing opened a new pull request #14864: [FLINK-21110] Optimize Scheduler Performance for Large-Scale Jobs
Thesharing opened a new pull request #14864:
URL: https://github.com/apache/flink/pull/14864
## What is the purpose of the change
*This PR introduces several optimizations on scheduler performance for running large-scale jobs. The optimizations are involved with the following procedures:*
* *Building topology when initializing ExecutionGraph*
* *Building DefaultExecutionTopology*
* *Initializing PipelinedRegionSchedulingStrategy*
* *Scheduling downstream tasks when a task finishes*
* *Calculating tasks to restart when a failover occurs*
* *Releasing result partitions*
*The main idea is to put all the vertices that consumed the same result partitions into one group, and put all the result partitions that have the same consumer vertices into one consumer group.*
*For more details please check [FLINK-21110](https://issues.apache.org/jira/browse/FLINK-21110).*
## Brief change log
- *Introduced EdgeManager, ConsumerVertexGroup and ConsumedPartitionGroup to store the topology in ExecutionGraph*
- *Introduced several optimizations on the procedures we mentioned above based on EdgeManager*
- *Removed ExecutionEdge and fixed related tests*
## Verifying this change
*Since these optimizations do not change the original logic of the target procedures, we believe that this change is already covered by existing tests, such as ExecutionVertexDeploymentTest, DefaultExecutionTopologyTest, PipelinedRegionSchedulingStrategyTest, and etc.*
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (yes / **no**)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**)
- The serializers: (yes / **no** / don't know)
- The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (**yes** / no / don't know)
- The S3 file system connector: (yes / **no** / don't know)
## Documentation
- Does this pull request introduce a new feature? (yes / **no**)
- If yes, how is the feature documented? (**not applicable** / docs / JavaDocs / not documented)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] Thesharing closed pull request #14864: [FLINK-21110] Optimize scheduler performance for large-scale jobs
Posted by GitBox <gi...@apache.org>.
Thesharing closed pull request #14864:
URL: https://github.com/apache/flink/pull/14864
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] Thesharing closed pull request #14864: [FLINK-21110] Optimize scheduler performance for large-scale jobs
Posted by GitBox <gi...@apache.org>.
Thesharing closed pull request #14864:
URL: https://github.com/apache/flink/pull/14864
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] Thesharing commented on pull request #14864: [FLINK-21110] Optimize scheduler performance for large-scale jobs
Posted by GitBox <gi...@apache.org>.
Thesharing commented on pull request #14864:
URL: https://github.com/apache/flink/pull/14864#issuecomment-773135662
After discussing with @zhuzhurk, I'm going to break this PR into several sub pull requests.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14864: [FLINK-21110] Optimize scheduler performance for large-scale jobs
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14864:
URL: https://github.com/apache/flink/pull/14864#issuecomment-773120426
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 8da3d3521a32bcfcfd7c66545feb417440b0ea82 (Fri May 28 08:17:23 UTC 2021)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] Thesharing commented on pull request #14864: [FLINK-21110] Optimize scheduler performance for large-scale jobs
Posted by GitBox <gi...@apache.org>.
Thesharing commented on pull request #14864:
URL: https://github.com/apache/flink/pull/14864#issuecomment-773135662
After discussing with @zhuzhurk, I'm going to break this PR into several sub pull requests.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #14864: [FLINK-21110] Optimize Scheduler Performance for Large-Scale Jobs
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #14864:
URL: https://github.com/apache/flink/pull/14864#issuecomment-773120426
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 8da3d3521a32bcfcfd7c66545feb417440b0ea82 (Thu Feb 04 08:16:42 UTC 2021)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #14864: [FLINK-21110] Optimize scheduler performance for large-scale jobs
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #14864:
URL: https://github.com/apache/flink/pull/14864#issuecomment-773128140
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "8da3d3521a32bcfcfd7c66545feb417440b0ea82",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "8da3d3521a32bcfcfd7c66545feb417440b0ea82",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 8da3d3521a32bcfcfd7c66545feb417440b0ea82 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #14864: [FLINK-21110] Optimize Scheduler Performance for Large-Scale Jobs
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #14864:
URL: https://github.com/apache/flink/pull/14864#issuecomment-773120426
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org