You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/11/27 17:21:00 UTC

[GitHub] [beam] eantyshev commented on pull request #24287: [Tour Of Beam] persistence_key for Pg::SaveSnippet

eantyshev commented on PR #24287:
URL: https://github.com/apache/beam/pull/24287#issuecomment-1328298891

   After some thought, decided to get rid of service-wide secret completely
   First, having a system-wide secret is not a good practice [owasp guidelines for storing passwords](https://cheatsheetseries.owasp.org/cheatsheets/Password_Storage_Cheat_Sheet.html#salting)
   
   Second, we don't have to re-caclulate persistence_key every call: we can calculate it once and store in tb_user_progress entity.
   This removes over-complication in `generatePersistenceKey`, as it doesn't need to depend on (SDK, unitID, userID), if we choose a secure random source.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org