You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Jie Yu <yu...@gmail.com> on 2017/09/14 05:31:29 UTC
Review Request 62322: Added initial doc for container volumes.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62322/
-----------------------------------------------------------
Review request for mesos, Gilbert Song and James Peach.
Repository: mesos
Description
-------
Added initial doc for container volumes.
Diffs
-----
docs/container-volume.md PRE-CREATION
docs/home.md dcb6235fdb12593fe8e9416c862ee547c0d77242
docs/mesos-containerizer.md feaaa556c9646435c6c9d677569962576ebf4c74
Diff: https://reviews.apache.org/r/62322/diff/1/
Testing
-------
Thanks,
Jie Yu
Re: Review Request 62322: Added initial doc for container volumes.
Posted by Gilbert Song <so...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62322/#review185602
-----------------------------------------------------------
Ship it!
Ship It!
- Gilbert Song
On Sept. 15, 2017, 6:50 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62322/
> -----------------------------------------------------------
>
> (Updated Sept. 15, 2017, 6:50 p.m.)
>
>
> Review request for mesos, Gilbert Song and James Peach.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added initial doc for container volumes.
>
>
> Diffs
> -----
>
> docs/container-volume.md PRE-CREATION
> docs/home.md dcb6235fdb12593fe8e9416c862ee547c0d77242
> docs/mesos-containerizer.md feaaa556c9646435c6c9d677569962576ebf4c74
>
>
> Diff: https://reviews.apache.org/r/62322/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 62322: Added initial doc for container volumes.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62322/
-----------------------------------------------------------
(Updated Sept. 16, 2017, 1:50 a.m.)
Review request for mesos, Gilbert Song and James Peach.
Changes
-------
Addressed comments.
Repository: mesos
Description
-------
Added initial doc for container volumes.
Diffs (updated)
-----
docs/container-volume.md PRE-CREATION
docs/home.md dcb6235fdb12593fe8e9416c862ee547c0d77242
docs/mesos-containerizer.md feaaa556c9646435c6c9d677569962576ebf4c74
Diff: https://reviews.apache.org/r/62322/diff/2/
Changes: https://reviews.apache.org/r/62322/diff/1-2/
Testing
-------
Thanks,
Jie Yu
Re: Review Request 62322: Added initial doc for container volumes.
Posted by Jie Yu <yu...@gmail.com>.
> On Sept. 15, 2017, 12:05 a.m., James Peach wrote:
> > docs/container-volume.md
> > Lines 97 (patched)
> > <https://reviews.apache.org/r/62322/diff/1/?file=1821447#file1821447line97>
> >
> > This explanation was not very clear to me. What is the problem you could solve with a symlink?
Added more explanation.
- Jie
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62322/#review185456
-----------------------------------------------------------
On Sept. 14, 2017, 5:31 a.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62322/
> -----------------------------------------------------------
>
> (Updated Sept. 14, 2017, 5:31 a.m.)
>
>
> Review request for mesos, Gilbert Song and James Peach.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added initial doc for container volumes.
>
>
> Diffs
> -----
>
> docs/container-volume.md PRE-CREATION
> docs/home.md dcb6235fdb12593fe8e9416c862ee547c0d77242
> docs/mesos-containerizer.md feaaa556c9646435c6c9d677569962576ebf4c74
>
>
> Diff: https://reviews.apache.org/r/62322/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 62322: Added initial doc for container volumes.
Posted by James Peach <jp...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62322/#review185456
-----------------------------------------------------------
docs/container-volume.md
Lines 23 (patched)
<https://reviews.apache.org/r/62322/#comment261751>
s/points/point/
docs/container-volume.md
Lines 26 (patched)
<https://reviews.apache.org/r/62322/#comment261752>
s/mount/mounts/
docs/container-volume.md
Lines 46 (patched)
<https://reviews.apache.org/r/62322/#comment261753>
"the Mesos containerizer"
docs/container-volume.md
Lines 60 (patched)
<https://reviews.apache.org/r/62322/#comment261754>
"the Mesos containerizer"
docs/container-volume.md
Lines 65 (patched)
<https://reviews.apache.org/r/62322/#comment261755>
"The Docker containerizer"
docs/container-volume.md
Lines 97 (patched)
<https://reviews.apache.org/r/62322/#comment261757>
This explanation was not very clear to me. What is the problem you could solve with a symlink?
docs/container-volume.md
Lines 110 (patched)
<https://reviews.apache.org/r/62322/#comment261759>
sw/mount/mounts/
- James Peach
On Sept. 14, 2017, 5:31 a.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62322/
> -----------------------------------------------------------
>
> (Updated Sept. 14, 2017, 5:31 a.m.)
>
>
> Review request for mesos, Gilbert Song and James Peach.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added initial doc for container volumes.
>
>
> Diffs
> -----
>
> docs/container-volume.md PRE-CREATION
> docs/home.md dcb6235fdb12593fe8e9416c862ee547c0d77242
> docs/mesos-containerizer.md feaaa556c9646435c6c9d677569962576ebf4c74
>
>
> Diff: https://reviews.apache.org/r/62322/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 62322: Added initial doc for container volumes.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62322/#review185491
-----------------------------------------------------------
Patch looks great!
Reviews applied: [62295, 62296, 62297, 62298, 62299, 62300, 62301, 62302, 62303, 62304, 62305, 62306, 62307, 62308, 62322]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On Sept. 14, 2017, 1:31 a.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62322/
> -----------------------------------------------------------
>
> (Updated Sept. 14, 2017, 1:31 a.m.)
>
>
> Review request for mesos, Gilbert Song and James Peach.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added initial doc for container volumes.
>
>
> Diffs
> -----
>
> docs/container-volume.md PRE-CREATION
> docs/home.md dcb6235fdb12593fe8e9416c862ee547c0d77242
> docs/mesos-containerizer.md feaaa556c9646435c6c9d677569962576ebf4c74
>
>
> Diff: https://reviews.apache.org/r/62322/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 62322: Added initial doc for container volumes.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62322/#review185382
-----------------------------------------------------------
FAIL: The filename, directory name, or volume label syntax is incorrect.
Reviews applied: `['62295', '62296', '62297', '62298', '62299', '62300', '62301', '62302', '62303', '62304', '62305', '62306', '62307', '62308', '62322']`
Failed command: ``
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/62322
- Mesos Reviewbot Windows
On Sept. 13, 2017, 10:31 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62322/
> -----------------------------------------------------------
>
> (Updated Sept. 13, 2017, 10:31 p.m.)
>
>
> Review request for mesos, Gilbert Song and James Peach.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added initial doc for container volumes.
>
>
> Diffs
> -----
>
> docs/container-volume.md PRE-CREATION
> docs/home.md dcb6235fdb12593fe8e9416c862ee547c0d77242
> docs/mesos-containerizer.md feaaa556c9646435c6c9d677569962576ebf4c74
>
>
> Diff: https://reviews.apache.org/r/62322/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 62322: Added initial doc for container volumes.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62322/#review185421
-----------------------------------------------------------
FAIL: Some Mesos tests failed.
Reviews applied: `['62295', '62296', '62297', '62298', '62299', '62300', '62301', '62302', '62303', '62304', '62305', '62306', '62307', '62308', '62322']`
Failed command: `C:\mesos\src\mesos-tests.exe --verbose`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/62322
Relevant logs:
- [mesos-tests-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/62322/logs/mesos-tests-stdout.log):
```
[ RUN ] ContentType/SchedulerTest.SchedulerReconnect/0
[ OK ] ContentType/SchedulerTest.SchedulerReconnect/0 (238 ms)
[ RUN ] ContentType/SchedulerTest.SchedulerReconnect/1
[ OK ] ContentType/SchedulerTest.SchedulerReconnect/1 (253 ms)
[----------] 30 tests from ContentType/SchedulerTest (24921 ms total)
[----------] 2 tests from ContentTypeAndSSLConfig/SchedulerSSLTest
[ RUN ] ContentTypeAndSSLConfig/SchedulerSSLTest.RunTaskAndTeardown/0
[ OK ] ContentTypeAndSSLConfig/SchedulerSSLTest.RunTaskAndTeardown/0 (891 ms)
[ RUN ] ContentTypeAndSSLConfig/SchedulerSSLTest.RunTaskAndTeardown/1
[ OK ] ContentTypeAndSSLConfig/SchedulerSSLTest.RunTaskAndTeardown/1 (1034 ms)
[----------] 2 tests from ContentTypeAndSSLConfig/SchedulerSSLTest (2011 ms total)
[----------] 2 tests from ContainerizerType/DefaultContainerDNSFlagTest
[ RUN ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/0
[ OK ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/0 (142 ms)
[ RUN ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/1
[ OK ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/1 (153 ms)
[----------] 2 tests from ContainerizerType/DefaultContainerDNSFlagTest (330 ms total)
[----------] Global test environment tear-down
[==========] 627 tests from 66 test cases ran. (343253 ms total)
[ PASSED ] 626 tests.
[ FAILED ] 1 test, listed below:
[ FAILED ] ContentType/MasterAPITest.EventAuthorizationFiltering/1, where GetParam() = application/json
1 FAILED TEST
YOU HAVE 174 DISABLED TESTS
```
- [mesos-tests-stderr.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/62322/logs/mesos-tests-stderr.log):
```
I0914 16:22:44.530659 14456 master.cpp:8418] Removing framework 8a22644c-151b-4f8c-9641-ce89ee4e6eb4-0000 (default)
I0914 16:22:44.530659 14456 master.cpp:3267] Deactivating framework 8a22644c-151b-4f8c-9641-ce89ee4e6eb4-0000 (default)
I0914 16:22:44.531659 15072 hierarchical.cpp:412] Deactivated framework 8a22644c-151b-4f8c-9641-ce89ee4e6eb4-0000
I0914 16:22:44.531659 14196 slave.cpp:3235] Shutting down framework 8a22644c-151b-4f8c-9641-ce89ee4e6eb4-0000
I0914 16:22:44.535668 14456 master.cpp:8993] Updating the state of task 2e3b96b8-7333-49eb-b836-7bc5e365e85f of framework 8a22644c-151b-4f8c-9641-ce89ee4e6eb4-0000 (latest state: TASK_KILLED, status update state: TASK_KILLED)
I0914 16:22:44.540877 14196 slave.cpp:5731] Shutting down executor 'default' of framework 8a22644c-151b-4f8c-9641-ce89ee4e6eb4-0000 (via HTTP)
I0914 16:22:44.545482 14456 master.cpp:9087] Removing task 2e3b96b8-7333-49eb-b836-7bc5e365e85f with resources [{"allocation_info":{"role":"*"},"name":"cpus","scalar":{"value":2.0},"type":"SCALAR"},{"allocation_info":{"role":"*"},"name":"mem","scalar":{"value":1024.0},"type":"SCALAR"},{"allocation_info":{"role":"*"},"name":"disk","scalar":{"value":1024.0},"type":"SCALAR"},{"allocation_info":{"role":"*"},"name":"ports","ranges":{"range":[{"begin":31000,"end":32000}]},"type":"RANGES"}] of framework 8a22644c-151b-4f8c-9641-ce89ee4e6eb4-0000 on agent 8a22644c-151b-4f8c-9641-ce89ee4e6eb4-S0 at slave(254)@10.3.1.5:54282 (mesos-bld-s1.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
I0914 16:22:44.562484 14456 master.cpp:9116] Removing executor 'default' with resources [] of framework 8a22644c-151b-4f8c-9641-ce89ee4e6eb4-0000 on agent 8a22644c-151b-4f8c-9641-ce89ee4e6eb4-S0 at slave(254)@10.3.1.5:54282 (mesos-bld-s1.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
I0914 16:22:44.565482 13444 hierarchical.cpp:355] Removed framework 8a22644c-151b-4f8c-9641-ce89ee4e6eb4-0000
E0914 16:22:44.566483 12724 scheduler.cpp:649] End-Of-File received from master. The master closed the event stream
I0914 16:22:44.567482 15072 scheduler.cpp:444] Re-detecting master
I0914 16:22:44.570483 15072 scheduler.cpp:470] New master detected at master@10.3.1.5:54282
I0914 16:22:44.586483 13852 slave.cpp:5407] Executor 'default' of framework 8a22644c-151b-4f8c-9641-ce89ee4e6eb4-0000 exited with status 0
I0914 16:22:44.587486 13852 slave.cpp:5511] Cleaning up executor 'default' of framework 8a22644c-151b-4f8c-9641-ce89ee4e6eb4-0000 (via HTTP)
W0914 16:22:44.587486 12724 master.cpp:7021] Ignoring unknown exited executor 'default' of framework 8a22644c-151b-4f8c-9641-ce89ee4e6eb4-0000 on agent 8a22644c-151b-4f8c-9641-ce89ee4e6eb4-S0 at slave(254)@10.3.1.5:54282 (mesos-bld-s1.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
I0914 16:22:44.596947 13444 gc.cpp:91] Scheduling 'C:\Users\mesos\AppData\Local\Temp\2\empPMM\slaves\8a22644c-151b-4f8c-9641-ce89ee4e6eb4-S0\frameworks\8a22644c-151b-4f8c-9641-ce89ee4e6eb4-0000\executors\default\runs\c14b3cb5-2cc8-41c7-a12d-459df4eb1ef7' for gc 6.99999309088days in the future
I0914 16:22:44.598947 13852 slave.cpp:5607] Cleaning up framework 8a22644c-151b-4f8c-9641-ce89ee4e6eb4-0000
I0914 16:22:44.598947 13276 gc.cpp:91] Scheduling 'C:\Users\mesos\AppData\Local\Temp\2\empPMM\slaves\8a22644c-151b-4f8c-9641-ce89ee4e6eb4-S0\frameworks\8a22644c-151b-4f8c-9641-ce89ee4e6eb4-0000\executors\default' for gc 6.99999307930667days in the future
I0914 16:22:44.598947 7980 status_update_manager.cpp:285] Closing status update streams for framework 8a22644c-151b-4f8c-9641-ce89ee4e6eb4-0000
I0914 16:22:44.599946 14196 gc.cpp:91] Scheduling 'C:\Users\mesos\AppData\Local\Temp\2\empPMM\slaves\8a22644c-151b-4f8c-9641-ce89ee4e6eb4-S0\frameworks\8a22644c-151b-4f8c-9641-ce89ee4e6eb4-0000' for gc 6.99999305616889days in the future
I0914 16:22:44.599946 13852 slave.cpp:861] Agent terminating
I0914 16:22:44.607952 14456 master.cpp:1321] Agent 8a22644c-151b-4f8c-9641-ce89ee4e6eb4-S0 at slave(254)@10.3.1.5:54282 (mesos-bld-s1.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net) disconnected
I0914 16:22:44.608947 14456 master.cpp:3304] Disconnecting agent 8a22644c-151b-4f8c-9641-ce89ee4e6eb4-S0 at slave(254)@10.3.1.5:54282 (mesos-bld-s1.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
I0914 16:22:44.608947 14456 master.cpp:3323] Deactivating agent 8a22644c-151b-4f8c-9641-ce89ee4e6eb4-S0 at slave(254)@10.3.1.5:54282 (mesos-bld-s1.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
I0914 16:22:44.609949 12724 hierarchical.cpp:690] Agent 8a22644c-151b-4f8c-9641-ce89ee4e6eb4-S0 deactivated
I0914 16:22:44.637948 14196 master.cpp:1163] Master terminating
I0914 16:22:44.642947 14456 hierarchical.cpp:626] Removed agent 8a22644c-151b-4f8c-9641-ce89ee4e6eb4-S0
W0914 16:22:44.654088 13700 master.hpp:2761] Failed to close HTTP pipe for 8a22644c-151b-4f8c-9641-ce89ee4e6eb4-0000 (default)
I0914 16:22:45.321107 12604 process.cpp:1068] Failed to accept socket: future discarded
```
- Mesos Reviewbot Windows
On Sept. 14, 2017, 5:31 a.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62322/
> -----------------------------------------------------------
>
> (Updated Sept. 14, 2017, 5:31 a.m.)
>
>
> Review request for mesos, Gilbert Song and James Peach.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added initial doc for container volumes.
>
>
> Diffs
> -----
>
> docs/container-volume.md PRE-CREATION
> docs/home.md dcb6235fdb12593fe8e9416c862ee547c0d77242
> docs/mesos-containerizer.md feaaa556c9646435c6c9d677569962576ebf4c74
>
>
> Diff: https://reviews.apache.org/r/62322/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jie Yu
>
>