You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@ignite.apache.org by "nizhikov (via GitHub)" <gi...@apache.org> on 2026/10/21 11:11:21 UTC

[PR] IGNITE-29185 Fix reading of cpMapSnapshot.bin written by previous versions [ignite]

nizhikov opened a new pull request, #13721:
URL: https://github.com/apache/ignite/pull/13721

   Thank you for submitting the pull request to the Apache Ignite.
   
   In order to streamline the review of the contribution 
   we ask you to ensure the following steps have been taken:
   
   ### The Contribution Checklist
   - [ ] There is a single JIRA ticket related to the pull request. 
   - [ ] The web-link to the pull request is attached to the JIRA ticket.
   - [ ] The JIRA ticket has the _Patch Available_ state.
   - [ ] The pull request body describes changes that have been made. 
   The description explains _WHAT_ and _WHY_ was made instead of _HOW_.
   - [ ] The pull request title is treated as the final commit message. 
   The following pattern must be used: `IGNITE-XXXX Change summary` where `XXXX` - number of JIRA issue.
   - [ ] A reviewer has been mentioned through the JIRA comments 
   (see [the Maintainers list](https://cwiki.apache.org/confluence/display/IGNITE/How+to+Contribute#HowtoContribute-ReviewProcessandMaintainers)) 
   - [ ] The pull request has been checked by the Teamcity Bot and 
   the `green visa` attached to the JIRA ticket (see tab `PR Check` at [TC.Bot - Instance 1](https://tcbot2.sbt-ignite-dev.ru/prs.html) or [TC.Bot - Instance 2](https://mtcga.gridgain.com/prs.html))
   
   ### Notes
   - [How to Contribute](https://cwiki.apache.org/confluence/display/IGNITE/How+to+Contribute)
   - [Coding abbreviation rules](https://cwiki.apache.org/confluence/display/IGNITE/Abbreviation+Rules)
   - [Coding Guidelines](https://cwiki.apache.org/confluence/display/IGNITE/Coding+Guidelines)
   - [Apache Ignite Teamcity Bot](https://cwiki.apache.org/confluence/display/IGNITE/Apache+Ignite+Teamcity+Bot)
   
   If you need any help, please email dev@ignite.apache.org or ask any advice on https://the-asf.slack.com _#ignite_ channel.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] IGNITE-29185 Fix reading of cpMapSnapshot.bin written by previous versions [ignite]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.

github-actions[bot] commented on PR #13721:
URL: https://github.com/apache/ignite/pull/13721#issuecomment-6324483522

   <!-- ignite-rolling-upgrade-check -->
   ## Possible compatibility issues. Please, check rolling upgrade cases
   
   This PR modifies protected classes (with **Order** annotation).
   Changes to these classes can break rolling upgrade compatibility.
   
   **Affected files:**
   - `modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/checkpoint/EarliestCheckpointMapSnapshot.java`
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] IGNITE-29185 Fix reading of cpMapSnapshot.bin written by previous versions [ignite]

Posted by "nizhikov (via GitHub)" <gi...@apache.org>.

nizhikov commented on PR #13721:
URL: https://github.com/apache/ignite/pull/13721#issuecomment-6314876385

   /run-all


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] IGNITE-29185 Fix reading of cpMapSnapshot.bin written by previous versions [ignite]

Posted by "alex-plekhanov (via GitHub)" <gi...@apache.org>.

alex-plekhanov commented on code in PR #13721:
URL: https://github.com/apache/ignite/pull/13721#discussion_r4336214880


##########
modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/checkpoint/EarliestCheckpointMapSnapshot.java:
##########
@@ -17,30 +17,39 @@
 
 package org.apache.ignite.internal.processors.cache.persistence.checkpoint;
 
+import java.io.Externalizable;
+import java.io.IOException;
+import java.io.ObjectInput;
+import java.io.ObjectOutput;
 import java.util.HashMap;
 import java.util.HashSet;
 import java.util.Map;
 import java.util.Set;
 import java.util.UUID;
-import org.apache.ignite.internal.Order;
-import org.apache.ignite.internal.dto.IgniteDataTransferObject;
+import org.apache.ignite.internal.dto.IgniteDataTransferObjectInput;
+import org.apache.ignite.internal.dto.IgniteDataTransferObjectOutput;
+import org.apache.ignite.internal.util.typedef.internal.U;
 import org.jetbrains.annotations.Nullable;
 
 /**
  * Earliest checkpoint map snapshot.
  * Speeds up construction of the earliestCp map in the {@link CheckpointHistory}.
+ *
+ * <b>The snapshot is stored on disk ({@link CheckpointMarkersStorage#EARLIEST_CP_SNAPSHOT_FILE}),
+ * so its binary format must stay readable across versions.</b>
  */
-public class EarliestCheckpointMapSnapshot extends IgniteDataTransferObject {
+public class EarliestCheckpointMapSnapshot implements Externalizable {
     /** Serial version UUID. */
     private static final long serialVersionUID = 0L;
 
+    /** Header magic number. */

Review Comment:
   Let's comment here, that MAGIC is the same as IDTO to provide backward compatibility.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] IGNITE-29185 Fix reading of cpMapSnapshot.bin written by previous versions [ignite]

Posted by "nizhikov (via GitHub)" <gi...@apache.org>.

nizhikov merged PR #13721:
URL: https://github.com/apache/ignite/pull/13721


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] IGNITE-29185 Fix reading of cpMapSnapshot.bin written by previous versions [ignite]

Posted by "ignite-pr-checker (via GitHub)" <gi...@apache.org>.

ignite-pr-checker commented on PR #13721:
URL: https://github.com/apache/ignite/pull/13721#issuecomment-6316417485

   @nizhikov the verdict of your `/run-all` is ready: RunAll [9429301](https://ci2.ignite.apache.org/build/9429301) — [see the verdict](https://ignite-pr-checker.is-a.dev/?pr=13721).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] IGNITE-29185 Fix reading of cpMapSnapshot.bin written by previous versions [ignite]

Posted by "ignite-pr-checker (via GitHub)" <gi...@apache.org>.

ignite-pr-checker commented on PR #13721:
URL: https://github.com/apache/ignite/pull/13721#issuecomment-6314884491

   @nizhikov 🚀 **RunAll queued** — [build 9429301](https://ci2.ignite.apache.org/build/9429301) · live progress & verdict: [Ignite PR Checker](https://ignite-pr-checker.is-a.dev/?pr=13721). When the run finishes, a new comment brings you the verdict, and this story goes.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org