You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/11/11 15:51:17 UTC
[GitHub] [beam] eantyshev opened a new pull request, #24121: [Playground] temporarily disable Playground Examples CI
eantyshev opened a new pull request, #24121:
URL: https://github.com/apache/beam/pull/24121
It got broken after #23879 was merged
Task to fix it: TBD
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] [**Choose reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and mention them in a comment (`R: @username`).
- [ ] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/get-started-contributing/#make-the-reviewers-job-easier).
To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] olehborysevych commented on pull request #24121: [Playground] temporarily disable Playground Examples CI
Posted by GitBox <gi...@apache.org>.
olehborysevych commented on PR #24121:
URL: https://github.com/apache/beam/pull/24121#issuecomment-1311875023
R: @damccorm
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] damccorm commented on a diff in pull request #24121: [Playground] temporarily disable Playground Examples CI
Posted by GitBox <gi...@apache.org>.
damccorm commented on code in PR #24121:
URL: https://github.com/apache/beam/pull/24121#discussion_r1020363561
##########
.github/workflows/playground_examples_ci.yml:
##########
@@ -16,15 +16,7 @@
name: Playground Examples CI
on:
- push:
- paths:
- - .github/workflows/playground_examples_ci_reusable.yml
- - .github/workflows/playground_examples_ci.yml
- - playground/backend/**
- - playground/infrastructure/**
- - learning/katas/**
- - examples/**
- - sdks/**
+ workflow_dispatch:
Review Comment:
As discussed offline, this is because the workflow doesn't fully exercise all functionality for all PRs/master runs, it only does that when there are potentially breaking changes.
The underlying issue here is that we're attaching to the last published sdk docker image (2.42 in this case).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] damccorm commented on a diff in pull request #24121: [Playground] temporarily disable Playground Examples CI
Posted by GitBox <gi...@apache.org>.
damccorm commented on code in PR #24121:
URL: https://github.com/apache/beam/pull/24121#discussion_r1020351756
##########
.github/workflows/playground_examples_ci.yml:
##########
@@ -16,15 +16,7 @@
name: Playground Examples CI
on:
- push:
- paths:
- - .github/workflows/playground_examples_ci_reusable.yml
- - .github/workflows/playground_examples_ci.yml
- - playground/backend/**
- - playground/infrastructure/**
- - learning/katas/**
- - examples/**
- - sdks/**
+ workflow_dispatch:
Review Comment:
I'm a little confused - isn't this still working fine? https://github.com/apache/beam/actions/workflows/playground_examples_ci.yml?query=branch%3Amaster
Am I looking at the wrong thing?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #24121: [Playground] temporarily disable Playground Examples CI
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #24121:
URL: https://github.com/apache/beam/pull/24121#issuecomment-1311876226
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] damccorm merged pull request #24121: [Playground] temporarily disable Playground Examples CI
Posted by GitBox <gi...@apache.org>.
damccorm merged PR #24121:
URL: https://github.com/apache/beam/pull/24121
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] olehborysevych commented on pull request #24121: [Playground] temporarily disable Playground Examples CI
Posted by GitBox <gi...@apache.org>.
olehborysevych commented on PR #24121:
URL: https://github.com/apache/beam/pull/24121#issuecomment-1311874623
LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org