You are viewing a plain text version of this content. The canonical link for it is here.
Posted to codereview@trafodion.apache.org by anoopsharma00 <gi...@git.apache.org> on 2016/03/21 16:45:02 UTC
[GitHub] incubator-trafodion pull request: JIRA TRAFODION-1901 Default clau...
GitHub user anoopsharma00 opened a pull request:
https://github.com/apache/incubator-trafodion/pull/398
JIRA TRAFODION-1901 Default clause can appear in any order during create
Default clause can now appear in any order during column definition of
a create table or alter table statement.
One can specify any mix of "not null", "default", "constraint..." and other
column attributes.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/anoopsharma00/incubator-trafodion defclause_br
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-trafodion/pull/398.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #398
----
commit 59b3d03d2a7878caad396d3d9b2bbee6a3b86bce
Author: Anoop Sharma <an...@edev06.esgyn.local>
Date: 2016-03-21T15:36:30Z
JIRA TRAFODION-1901 Default clause can appear in any order during create.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafodion pull request: JIRA TRAFODION-1901 Default clau...
Posted by DaveBirdsall <gi...@git.apache.org>.
Github user DaveBirdsall commented on a diff in the pull request:
https://github.com/apache/incubator-trafodion/pull/398#discussion_r56858053
--- Diff: core/sql/parser/sqlparser.y ---
@@ -25040,14 +25036,6 @@ column_definition : qualified_name
column_name : identifier
/* type pElemDDL */
-optional_col_def_default_clause : empty
- {
- $$ = NULL;
- }
-
- | col_def_default_clause
-
-/* type pElemDDL */
col_def_default_clause : TOK_DEFAULT enableCharsetInferenceInColDefaultVal col_def_default_clause_argument
--- End diff --
Our parser actually got smaller!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafodion pull request: JIRA TRAFODION-1901 Default clau...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-trafodion/pull/398
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---