You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@ofbiz.apache.org by ja...@apache.org on 2007/04/28 17:30:05 UTC

svn commit: r533357 - /ofbiz/trunk/applications/order/src/org/ofbiz/order/order/OrderReadHelper.java

Author: jacopoc
Date: Sat Apr 28 08:30:04 2007
New Revision: 533357

URL: http://svn.apache.org/viewvc?view=rev&rev=533357
Log:
Small change to prevent NPE under some circumstances.

Modified:
    ofbiz/trunk/applications/order/src/org/ofbiz/order/order/OrderReadHelper.java

Modified: ofbiz/trunk/applications/order/src/org/ofbiz/order/order/OrderReadHelper.java
URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/order/src/org/ofbiz/order/order/OrderReadHelper.java?view=diff&rev=533357&r1=533356&r2=533357
==============================================================================
--- ofbiz/trunk/applications/order/src/org/ofbiz/order/order/OrderReadHelper.java (original)
+++ ofbiz/trunk/applications/order/src/org/ofbiz/order/order/OrderReadHelper.java Sat Apr 28 08:30:04 2007
@@ -2579,7 +2579,7 @@
             if (Debug.verboseOn()) Debug.logVerbose("Unit Price : " + unitPrice + " / " + "Quantity : " + quantity, module);
             result = unitPrice.multiply(quantity);
 
-            if (orderItem.getString("orderItemTypeId").compareTo("RENTAL_ORDER_ITEM") == 0)    { // retrieve related work effort when required.
+            if ("RENTAL_ORDER_ITEM".equals(orderItem.getString("orderItemTypeId")))    { // retrieve related work effort when required.
                 List WorkOrderItemFulfillments = null;
                 try {
                     WorkOrderItemFulfillments = orderItem.getRelatedCache("WorkOrderItemFulfillment");