You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hbase.apache.org by md...@apache.org on 2018/05/23 18:26:07 UTC

[07/14] hbase git commit: HBASE-20488 Fix PE command help message

HBASE-20488 Fix PE command help message

checkstyle fix

Signed-off-by: Peter Somogyi <ps...@apache.org>


Project: http://git-wip-us.apache.org/repos/asf/hbase/repo
Commit: http://git-wip-us.apache.org/repos/asf/hbase/commit/cf529f18
Tree: http://git-wip-us.apache.org/repos/asf/hbase/tree/cf529f18
Diff: http://git-wip-us.apache.org/repos/asf/hbase/diff/cf529f18

Branch: refs/heads/HBASE-20478
Commit: cf529f18a9959589fa635f78df4840472526ea2c
Parents: 60bdaf7
Author: Xu Cang <xc...@salesforce.com>
Authored: Wed May 16 10:30:21 2018 -0700
Committer: Peter Somogyi <ps...@apache.org>
Committed: Thu May 17 11:56:04 2018 +0200

----------------------------------------------------------------------
 .../org/apache/hadoop/hbase/PerformanceEvaluation.java | 13 +++++++------
 1 file changed, 7 insertions(+), 6 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/hbase/blob/cf529f18/hbase-mapreduce/src/test/java/org/apache/hadoop/hbase/PerformanceEvaluation.java
----------------------------------------------------------------------
diff --git a/hbase-mapreduce/src/test/java/org/apache/hadoop/hbase/PerformanceEvaluation.java b/hbase-mapreduce/src/test/java/org/apache/hadoop/hbase/PerformanceEvaluation.java
index 33267e0..42acb5c 100644
--- a/hbase-mapreduce/src/test/java/org/apache/hadoop/hbase/PerformanceEvaluation.java
+++ b/hbase-mapreduce/src/test/java/org/apache/hadoop/hbase/PerformanceEvaluation.java
@@ -132,6 +132,7 @@ import org.apache.hbase.thirdparty.com.google.common.util.concurrent.ThreadFacto
 public class PerformanceEvaluation extends Configured implements Tool {
   static final String RANDOM_SEEK_SCAN = "randomSeekScan";
   static final String RANDOM_READ = "randomRead";
+  static final String PE_COMMAND_SHORTNAME = "pe";
   private static final Logger LOG = LoggerFactory.getLogger(PerformanceEvaluation.class.getName());
   private static final ObjectMapper MAPPER = new ObjectMapper();
   static {
@@ -2356,11 +2357,11 @@ public class PerformanceEvaluation extends Configured implements Tool {
   }
 
   protected void printUsage() {
-    printUsage(this.getClass().getName(), null);
+    printUsage(PE_COMMAND_SHORTNAME, null);
   }
 
   protected static void printUsage(final String message) {
-    printUsage(PerformanceEvaluation.class.getName(), message);
+    printUsage(PE_COMMAND_SHORTNAME, message);
   }
 
   protected static void printUsageAndExit(final String message, final int exitCode) {
@@ -2368,11 +2369,11 @@ public class PerformanceEvaluation extends Configured implements Tool {
     System.exit(exitCode);
   }
 
-  protected static void printUsage(final String className, final String message) {
+  protected static void printUsage(final String shortName, final String message) {
     if (message != null && message.length() > 0) {
       System.err.println(message);
     }
-    System.err.println("Usage: java " + className + " \\");
+    System.err.print("Usage: hbase " + shortName);
     System.err.println("  <OPTIONS> [-D<property=value>]* <command> <nclients>");
     System.err.println();
     System.err.println("General Options:");
@@ -2464,9 +2465,9 @@ public class PerformanceEvaluation extends Configured implements Tool {
         + "(and HRegionServers) running. 1 <= value <= 500");
     System.err.println("Examples:");
     System.err.println(" To run a single client doing the default 1M sequentialWrites:");
-    System.err.println(" $ hbase " + className + " sequentialWrite 1");
+    System.err.println(" $ hbase " + shortName + " sequentialWrite 1");
     System.err.println(" To run 10 clients doing increments over ten rows:");
-    System.err.println(" $ hbase " + className + " --rows=10 --nomapred increment 10");
+    System.err.println(" $ hbase " + shortName + " --rows=10 --nomapred increment 10");
   }
 
   /**