You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@texera.apache.org by "mengw15 (via GitHub)" <gi...@apache.org> on 2026/07/29 05:24:54 UTC
[PR] refactor(storage): return named VFSUriComponents from decodeURI [texera]
mengw15 opened a new pull request, #7020:
URL: https://github.com/apache/texera/pull/7020
### What changes were proposed in this PR?
`VFSURIFactory.decodeURI` returned a positional 4-tuple `(WorkflowIdentity, ExecutionIdentity, Option[GlobalPortIdentity], VFSResourceType)` in both Scala and Python, so its nine production call sites destructured positionally — mostly binding a single field through patterns like `val (_, _, _, resourceType) = decodeURI(uri)` — where nothing catches a swapped `_` position, and adding a field means touching every site. The Scala doc already advertised `@return A VFSUriComponents object`, but no such type existed.
- **Scala**: introduce `case class VFSUriComponents(workflowId, executionId, globalPortId, resourceType)` in `VFSURIFactory.scala`; `decodeURI` now returns it. All six production call sites (`DocumentFactory` ×3, `ExecutionResultService` ×2, `WorkflowExecutionsResource` ×1) read named fields; the compiler forced every site to be updated, so none can be missed.
- **Python**: introduce a matching `VFSUriComponents(NamedTuple)` in `vfs_uri_factory.py`; `decode_uri` returns it. A `NamedTuple` keeps positional unpacking working alongside named access, so this is non-breaking for any external unpacking. The three `document_factory.py` sites read `.resource_type`.
- **Tests**: the Scala and Python suites' destructurings updated to named access; `test_document_factory`'s mocked `decode_uri` now returns a real `VFSUriComponents` (production accesses the result by name, so a bare tuple would no longer satisfy it).
Pure refactor, no behavior change, symmetric across both languages.
### Any related issues, documentation, discussions?
Closes #6979.
### How was this PR tested?
- No new tests — the existing round-trip suites pin the decoded values in both languages, and the refactor is validated by them:
- Scala: `VFSURIFactorySpec` 8/8, `WorkflowExecutionsResourceSpec` 22/22, `scalafmtCheck` (WorkflowCore + WorkflowExecutionService, main + Test) all pass locally.
- Python: the two storage suites pass 21/21 locally; `ruff check` and `ruff format --check` clean.
- The Scala side is additionally compile-verified: a tuple destructure of a case class does not compile, so every call site was necessarily updated.
### Was this PR authored or co-authored using generative AI tooling?
Generated-by: Claude Code (claude-opus-4-8)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] refactor(storage): return named VFSUriComponents from decodeURI [texera]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #7020:
URL: https://github.com/apache/texera/pull/7020#issuecomment-5113616926
## [Codecov](https://app.codecov.io/gh/apache/texera/pull/7020?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 79.08%. Comparing base ([`ab58d47`](https://app.codecov.io/gh/apache/texera/commit/ab58d477ba77d1f42cbe56f888dda96fe3fffad0?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`cefaa11`](https://app.codecov.io/gh/apache/texera/commit/cefaa11c083efb105ee5f52c78b228ab129324fc?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 1 commits behind head on main.
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## main #7020 +/- ##
=========================================
Coverage 79.07% 79.08%
Complexity 3784 3784
=========================================
Files 1160 1160
Lines 46105 46104 -1
Branches 5115 5111 -4
=========================================
+ Hits 36457 36460 +3
Misses 8025 8025
+ Partials 1623 1619 -4
```
| [Flag](https://app.codecov.io/gh/apache/texera/pull/7020/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | *Carryforward flag |
|---|---|---|---|
| [access-control-service](https://app.codecov.io/gh/apache/texera/pull/7020/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `70.00% <ø> (ø)` | | |
| [agent-service](https://app.codecov.io/gh/apache/texera/pull/7020/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `76.76% <ø> (ø)` | | Carriedforward from [ab58d47](https://app.codecov.io/gh/apache/texera/commit/ab58d477ba77d1f42cbe56f888dda96fe3fffad0?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [amber](https://app.codecov.io/gh/apache/texera/pull/7020/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `72.19% <ø> (+0.01%)` | :arrow_up: | Carriedforward from [ab58d47](https://app.codecov.io/gh/apache/texera/commit/ab58d477ba77d1f42cbe56f888dda96fe3fffad0?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [computing-unit-managing-service](https://app.codecov.io/gh/apache/texera/pull/7020/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `20.49% <ø> (ø)` | | |
| [config-service](https://app.codecov.io/gh/apache/texera/pull/7020/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `66.66% <ø> (ø)` | | |
| [file-service](https://app.codecov.io/gh/apache/texera/pull/7020/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `67.21% <ø> (ø)` | | Carriedforward from [ab58d47](https://app.codecov.io/gh/apache/texera/commit/ab58d477ba77d1f42cbe56f888dda96fe3fffad0?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [frontend](https://app.codecov.io/gh/apache/texera/pull/7020/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `82.99% <ø> (ø)` | | Carriedforward from [ab58d47](https://app.codecov.io/gh/apache/texera/commit/ab58d477ba77d1f42cbe56f888dda96fe3fffad0?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [notebook-migration-service](https://app.codecov.io/gh/apache/texera/pull/7020/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `78.94% <ø> (ø)` | | |
| [pyamber](https://app.codecov.io/gh/apache/texera/pull/7020/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `96.34% <100.00%> (+<0.01%)` | :arrow_up: | |
| [workflow-compiling-service](https://app.codecov.io/gh/apache/texera/pull/7020/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `26.31% <ø> (ø)` | | |
*This pull request uses carry forward flags. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to find out more.
</details>
[:umbrella: View full report in Codecov by Harness](https://app.codecov.io/gh/apache/texera/pull/7020?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] refactor(storage): return named VFSUriComponents from decodeURI [texera]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #7020:
URL: https://github.com/apache/texera/pull/7020#issuecomment-5113593428
<!-- texera-reviewer-suggestion -->
### Automated Reviewer Suggestions
Based on the `git blame` history of the changed files, we recommend the following reviewers:
- **Contributors with relevant context:** `@aglinxinyuan`, `@Yicong-Huang`, `@Ma77Ball`
You can notify them by mentioning `@aglinxinyuan`, `@Yicong-Huang`, `@Ma77Ball` in a comment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] refactor(storage): return named VFSUriComponents from decodeURI [texera]
Posted by "aglinxinyuan (via GitHub)" <gi...@apache.org>.
aglinxinyuan merged PR #7020:
URL: https://github.com/apache/texera/pull/7020
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] refactor(storage): return named VFSUriComponents from decodeURI [texera]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #7020:
URL: https://github.com/apache/texera/pull/7020#issuecomment-5113631791
<!-- texera-benchmarks-comment -->
## ⚠️ Benchmark changes need a look
🟢 0 better · 🔴 3 worse · ⚪ 12 noise (<±5%) · 0 without baseline
> Compared against main `ab58d47` benchmarked on **this same runner**, so the delta is largely free of cross-runner hardware noise. The "7d avg" column still reflects the gh-pages dashboard. Treat <±5% as noise unless repeated.
[Dashboard](https://apache.github.io/texera/dev/bench/) · [Run](https://github.com/apache/texera/actions/runs/30425000513)
| | config | throughput | MB/s | latency | max Δ latest / 7d |
|---|---|---:|---:|---:|---:|
| 🔴 | bs=10 sw=10 sl=64 | 398 | 0.243 | 26,004/36,623/36,623 us | 🔴 +12.0% / 🔴 +131.8% |
| 🔴 | bs=100 sw=10 sl=64 | 808 | 0.493 | 119,152/153,962/153,962 us | 🔴 +15.0% / 🔴 +43.5% |
| ⚪ | bs=1000 sw=10 sl=64 | 917 | 0.56 | 1,095,369/1,145,696/1,145,696 us | ⚪ within ±5% / 🔴 +11.6% |
<details><summary>Baseline details</summary>
Latest main `ab58d47` from same runner
| config | metric | PR | latest main | 7d avg | Δ latest | Δ 7d |
|---|---|---:|---:|---:|---:|---:|
| bs=10 sw=10 sl=64 | throughput | 398 tuples/sec | 384 tuples/sec | 787.55 tuples/sec | +3.6% | -49.5% |
| bs=10 sw=10 sl=64 | MB/s | 0.243 MB/s | 0.235 MB/s | 0.481 MB/s | +3.4% | -49.4% |
| bs=10 sw=10 sl=64 | p50 | 26,004 us | 23,227 us | 12,255 us | +12.0% | +112.2% |
| bs=10 sw=10 sl=64 | p95 | 36,623 us | 37,205 us | 15,802 us | -1.6% | +131.8% |
| bs=10 sw=10 sl=64 | p99 | 36,623 us | 37,205 us | 19,008 us | -1.6% | +92.7% |
| bs=100 sw=10 sl=64 | throughput | 808 tuples/sec | 828 tuples/sec | 997.81 tuples/sec | -2.4% | -19.0% |
| bs=100 sw=10 sl=64 | MB/s | 0.493 MB/s | 0.506 MB/s | 0.609 MB/s | -2.6% | -19.0% |
| bs=100 sw=10 sl=64 | p50 | 119,152 us | 120,854 us | 100,690 us | -1.4% | +18.3% |
| bs=100 sw=10 sl=64 | p95 | 153,962 us | 133,915 us | 107,316 us | +15.0% | +43.5% |
| bs=100 sw=10 sl=64 | p99 | 153,962 us | 133,915 us | 113,823 us | +15.0% | +35.3% |
| bs=1000 sw=10 sl=64 | throughput | 917 tuples/sec | 927 tuples/sec | 1,030 tuples/sec | -1.1% | -11.0% |
| bs=1000 sw=10 sl=64 | MB/s | 0.56 MB/s | 0.566 MB/s | 0.629 MB/s | -1.1% | -11.0% |
| bs=1000 sw=10 sl=64 | p50 | 1,095,369 us | 1,084,301 us | 981,213 us | +1.0% | +11.6% |
| bs=1000 sw=10 sl=64 | p95 | 1,145,696 us | 1,117,705 us | 1,027,605 us | +2.5% | +11.5% |
| bs=1000 sw=10 sl=64 | p99 | 1,145,696 us | 1,117,705 us | 1,055,466 us | +2.5% | +8.5% |
</details>
<details><summary>Raw CSV</summary>
```csv
config_idx,batch_size,schema_width,string_len,num_batches,total_ms,total_tuples,total_bytes,tuples_per_sec,mb_per_sec,lat_p50_us,lat_p95_us,lat_p99_us
0,10,10,64,20,502.02,200,128000,398,0.243,26003.78,36622.99,36622.99
1,100,10,64,20,2475.85,2000,1280000,808,0.493,119151.89,153961.62,153961.62
2,1000,10,64,20,21815.69,20000,12800000,917,0.560,1095369.46,1145696.11,1145696.11
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org