You are viewing a plain text version of this content. The canonical link for it is here.

Posted to jira@kafka.apache.org by "Sagar Rao (Jira)" <ji...@apache.org> on 2022/06/18 08:11:00 UTC

[jira] [Assigned] (KAFKA-14007) Connect header converters are never closed

     [ https://issues.apache.org/jira/browse/KAFKA-14007?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Sagar Rao reassigned KAFKA-14007:
---------------------------------

    Assignee: Sagar Rao

> Connect header converters are never closed
> ------------------------------------------
>
>                 Key: KAFKA-14007
>                 URL: https://issues.apache.org/jira/browse/KAFKA-14007
>             Project: Kafka
>          Issue Type: Bug
>          Components: KafkaConnect
>            Reporter: Chris Egerton
>            Assignee: Sagar Rao
>            Priority: Major
>
> The [HeaderConverter interface|https://github.com/apache/kafka/blob/1e21201ea24389bdaccb8a462f3a53e356b58a58/connect/api/src/main/java/org/apache/kafka/connect/storage/HeaderConverter.java#L27] extends {{Closeable}}, but {{HeaderConverter::close}} is never actually invoked anywhere. We can and should start invoking it, probably wrapped in [Utils::closeQuietly|https://github.com/apache/kafka/blob/1e21201ea24389bdaccb8a462f3a53e356b58a58/clients/src/main/java/org/apache/kafka/common/utils/Utils.java#L999-L1010] so that any invalid logic in that method for custom header converters that has to date gone undetected will not cause new task failures.



--
This message was sent by Atlassian Jira
(v8.20.7#820007)