[jira] [Assigned] (HDFS-14994) Optimize LowRedundancyBlocks#chooseLowRedundancyBlocks()

["Lisheng Sun (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/HDFS-14994?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Lisheng Sun reassigned HDFS-14994:
----------------------------------

    Assignee: Lisheng Sun

> Optimize LowRedundancyBlocks#chooseLowRedundancyBlocks()
> --------------------------------------------------------
>
>                 Key: HDFS-14994
>                 URL: https://issues.apache.org/jira/browse/HDFS-14994
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>            Reporter: Lisheng Sun
>            Assignee: Lisheng Sun
>            Priority: Major
>         Attachments: HDFS-14994.001.patch, HDFS-14994.002.patch
>
>
> when priority=QUEUE_WITH_CORRUPT_BLOCKS, it mean no block in needreplication need replica. 
> in current code if use continue, there is one more invalid judgment (priority ==QUEUE_WITH_CORRUPT_BLOCKS).
> i think it should use break instread of continue.
> {code:java}
>  */
> synchronized List<List<BlockInfo>> chooseLowRedundancyBlocks(
>     int blocksToProcess) {
>   final List<List<BlockInfo>> blocksToReconstruct = new ArrayList<>(LEVEL);
>   int count = 0;
>   int priority = 0;
>   for (; count < blocksToProcess && priority < LEVEL; priority++) {
>     if (priority == QUEUE_WITH_CORRUPT_BLOCKS) {
>       // do not choose corrupted blocks.
>       continue;
>     }
> ...
>    
> }
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org