[GitHub] [skywalking] wu-sheng commented on a diff in pull request #10616: Support isEmptyValue flag for metrics query.

["wu-sheng (via GitHub)" <gi...@apache.org>]

wu-sheng commented on code in PR #10616:
URL: https://github.com/apache/skywalking/pull/10616#discussion_r1152710104


##########
test/e2e-v2/cases/php/expected/metrics-has-value.yml:
##########
@@ -15,5 +15,11 @@
 
 {{- contains . }}
 - key: {{ notEmpty .key }}
-  value: {{ ge .value 2 }}
+  value:
+    value: 0
+    isemptyvalue: true

Review Comment:
   I think the point is, from a test perspective, the initial query should cover the time range from no telenmetry data to having data.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org