You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/08/06 21:40:06 UTC
[GitHub] [airflow] potiuk opened a new pull request #10208: Improves stability of reported coverage and makes it nicer
potiuk opened a new pull request #10208:
URL: https://github.com/apache/airflow/pull/10208
With this change we only upload coverage report in the case
when all tests were successuful and actually executed. This means
that coverage report will not be run when the job gets canceled.
Currently a lof of coverage reports gathered contain far less
coverage because when static check fails or docs some test jobs
could already submit their coverage - resulting in partial coverage
reports.
With this change we also remove comment from coverage report
and replace it with (for now) informational status message published
to github. If we see that it works, we can change it to a
PR-failing status if coverage drops for a given PR.
This way we might get our coverage monotonously increasing :).
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] feluelle commented on a change in pull request #10208: Improves stability of reported coverage and makes it nicer
Posted by GitBox <gi...@apache.org>.
feluelle commented on a change in pull request #10208:
URL: https://github.com/apache/airflow/pull/10208#discussion_r466893247
##########
File path: .github/workflows/ci.yml
##########
@@ -325,11 +325,95 @@ jobs:
with:
name: airflow-logs-${{matrix.test-type}}-${{matrix.python-version}}
path: './files/airflow_logs*'
+ - uses: actions/upload-artifact@v2
+ name: Upload artifact for coverage
+ with:
+ name: coverage-sqlite-${{matrix.test-type}}-${{matrix.python-version}}
+ path: ./files/coverage.xml
+
+ tests-quarantined:
+ timeout-minutes: 80
+ name: "Quarantined tests"
+ runs-on: ubuntu-latest
+ continue-on-error: true
+ needs: [trigger-tests]
+ strategy:
+ matrix:
+ python-version: [3.6]
+ postgres-version: [9.6]
+ fail-fast: false
+ env:
+ BACKEND: postgres
+ PYTHON_MAJOR_MINOR_VERSION: ${{ matrix.python-version }}
+ POSTGRES_VERSION: ${{ matrix.postgres-version }}
+ RUN_TESTS: "true"
+ TEST_TYPE: Quarantined
+ NUM_RUNS: 10
+ GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+ if: needs.trigger-tests.outputs.run-tests == 'true' || github.event_name != 'pull_request'
+ steps:
+ - uses: actions/checkout@v2
+ - uses: actions/setup-python@v2
+ with:
+ python-version: '3.7'
+ - name: "Set issue id for master"
+ if: github.ref == 'refs/heads/master'
+ run: |
+ echo "::set-env name=ISSUE_ID::10118"
+ - name: "Set issue id for v1-10-stable"
+ if: github.ref == 'refs/heads/v1-10-stable'
+ run: |
+ echo "::set-env name=ISSUE_ID::10127"
+ - name: "Set issue id for v1-10-test"
+ if: github.ref == 'refs/heads/v1-10-test'
+ run: |
+ echo "::set-env name=ISSUE_ID::10128"
+ - name: "Free space"
+ run: ./scripts/ci/tools/ci_free_space_on_ci.sh
+ - name: "Build CI image ${{ matrix.python-version }}"
+ run: ./scripts/ci/images/ci_prepare_ci_image_on_ci.sh
+ - name: "Tests"
+ run: ./scripts/ci/testing/ci_run_airflow_testing.sh
+ - uses: actions/upload-artifact@v2
+ name: Upload Quarantine test results
+ if: always()
+ with:
+ name: 'quarantined_tests'
+ path: 'files/test_result.xml'
+ - uses: actions/upload-artifact@v2
+ name: Upload airflow logs
+ if: always()
+ with:
+ name: airflow-logs-quarantined-${{matrix.python-version}}-${{ matrix.postgres-version }}
+ path: './files/airflow_logs*'
+ - uses: actions/upload-artifact@v2
+ name: Upload artifact for coverage
+ with:
+ name: coveragage-quarantined-${{matrix.test-type}}-${{matrix.python-version}}
Review comment:
```suggestion
name: coverage-quarantined-${{matrix.test-type}}-${{matrix.python-version}}
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #10208: Improves stability of reported coverage and makes it nicer
Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #10208:
URL: https://github.com/apache/airflow/pull/10208
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org