You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/11/05 22:30:41 UTC
[GitHub] [incubator-superset] betodealmeida opened a new issue #11586: Improve selection of LIMIT in SQL Lab
betodealmeida opened a new issue #11586:
URL: https://github.com/apache/incubator-superset/issues/11586
**Is your feature request related to a problem? Please describe.**
In SQL Lab, to change the current limit the user needs to:
1. Click the LIMIT button
2. Click the input field
3. Delete the current value
4. Type in the new value
5. Press OK
This is a lot.
**Describe the solution you'd like**
In SQL Lab, after clicking the "LIMIT" button the input element in the dialog that pops should be focused and the current value selected. Pressing enter should apply and close the dialog, equivalent to clicking OK.
1. Click LIMIT button
2. Type in the new value
3. Press ENTER
**Describe alternatives you've considered**
N/A
**Additional context**
N/A
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] mistercrunch commented on issue #11586: Improve selection of LIMIT in SQL Lab
Posted by GitBox <gi...@apache.org>.
mistercrunch commented on issue #11586:
URL: https://github.com/apache/incubator-superset/issues/11586#issuecomment-723710469
We have an internal design to improve the SQL Lab toolbar, and that includes improvement to the LIMIT control, it'd be great if we can share the design here in the open.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] Giphyn-nehboh-5qonhu commented on issue #11586: Improve selection of LIMIT in SQL Lab
Posted by GitBox <gi...@apache.org>.
Giphyn-nehboh-5qonhu commented on issue #11586:
URL: https://github.com/apache/incubator-superset/issues/11586#issuecomment-722737949
https://t.me/Hos_144
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] issue-label-bot[bot] commented on issue #11586: Improve selection of LIMIT in SQL Lab
Posted by GitBox <gi...@apache.org>.
issue-label-bot[bot] commented on issue #11586:
URL: https://github.com/apache/incubator-superset/issues/11586#issuecomment-722683378
Issue-Label Bot is automatically applying the label `#enhancement` to this issue, with a confidence of 0.97. Please mark this comment with :thumbsup: or :thumbsdown: to give our bot feedback!
Links: [app homepage](https://github.com/marketplace/issue-label-bot), [dashboard](https://mlbot.net/data/apache/incubator-superset) and [code](https://github.com/hamelsmu/MLapp) for this bot.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] Steejay commented on issue #11586: Improve selection of LIMIT in SQL Lab
Posted by GitBox <gi...@apache.org>.
Steejay commented on issue #11586:
URL: https://github.com/apache/incubator-superset/issues/11586#issuecomment-724872046
hey @betodealmeida ! We're exploring this new limit design shown in the screenshot here. I agree that the current limit interaction should be simplified. We also saw an opportunity to eliminate some of the annoying error states a user might encounter (empty text field and integer over max limit). We believe that this dropdown of pre defined limits can help assuage some of these pain points. If a user wants to define a custom limit they still have the ability to do so in SQL Editor.
cc @yousoph @mistercrunch
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org