You are viewing a plain text version of this content. The canonical link for it is here.
Posted to oak-issues@jackrabbit.apache.org by "Julian Reschke (Jira)" <ji...@apache.org> on 2019/08/23 14:23:00 UTC
[jira] [Updated] (OAK-7473) [BlobGC] MarkSweepGarbageCollector does
not always use the blobGcMaxAgeInSecs config
[ https://issues.apache.org/jira/browse/OAK-7473?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Julian Reschke updated OAK-7473:
--------------------------------
Description:
I wanted to use the _blobGcMaxAgeInSecs_ config of the SegmentNodeStoreService to reduce the max age of the blobs for GC. It looks like the MarkSweepGarbageCollector[1] does no longer support the blobGcMaxAgeInSecs configuration of the SegmentNodeStoreService[3]. Instead a max age of 24h is hardcoded (added with OAK-5546 and revision r1811532 [3]) in the constructor used by the SegmentNodeStoreService.
Looks like a regression from OAK-5546, or is there a specific reason for no longer supporting _blobGcMaxAgeInSecs_ config?
[1] [https://github.com/apache/jackrabbit-oak/blob/trunk/oak-blob-plugins/src/main/java/org/apache/jackrabbit/oak/plugins/blob/MarkSweepGarbageCollector.java#L188]
[2] [https://github.com/apache/jackrabbit-oak/blob/trunk/oak-segment-tar/src/main/java/org/apache/jackrabbit/oak/segment/SegmentNodeStoreService.java#L690]
[3] http://svn.apache.org/viewvc?rev=1811532&view=rev
was:
I wanted to use the _blobGcMaxAgeInSecs_ config of the SegmentNodeStoreService to reduce the max age of the blobs for GC. It looks like the MarkSweepGarbageCollector[1] does no longer support the blobGcMaxAgeInSecs configuration of the SegmentNodeStoreService[3]. Instead a max age of 24h is hardcoded (added with OAK-5546 and revision r1811532 [3]) in the custructor used by the SegmentNodeStoreService.
Looks like a regression from OAK-5546, or is there a specific reason for no longer supporting _blobGcMaxAgeInSecs_ config?
[1] [https://github.com/apache/jackrabbit-oak/blob/trunk/oak-blob-plugins/src/main/java/org/apache/jackrabbit/oak/plugins/blob/MarkSweepGarbageCollector.java#L188]
[2] [https://github.com/apache/jackrabbit-oak/blob/trunk/oak-segment-tar/src/main/java/org/apache/jackrabbit/oak/segment/SegmentNodeStoreService.java#L690]
[3] http://svn.apache.org/viewvc?rev=1811532&view=rev
> [BlobGC] MarkSweepGarbageCollector does not always use the blobGcMaxAgeInSecs config
> ------------------------------------------------------------------------------------
>
> Key: OAK-7473
> URL: https://issues.apache.org/jira/browse/OAK-7473
> Project: Jackrabbit Oak
> Issue Type: Bug
> Components: blob
> Affects Versions: 1.9.0
> Reporter: Marc Pfaff
> Assignee: Francesco Mari
> Priority: Major
> Fix For: 1.10.0, 1.9.1
>
>
> I wanted to use the _blobGcMaxAgeInSecs_ config of the SegmentNodeStoreService to reduce the max age of the blobs for GC. It looks like the MarkSweepGarbageCollector[1] does no longer support the blobGcMaxAgeInSecs configuration of the SegmentNodeStoreService[3]. Instead a max age of 24h is hardcoded (added with OAK-5546 and revision r1811532 [3]) in the constructor used by the SegmentNodeStoreService.
> Looks like a regression from OAK-5546, or is there a specific reason for no longer supporting _blobGcMaxAgeInSecs_ config?
> [1] [https://github.com/apache/jackrabbit-oak/blob/trunk/oak-blob-plugins/src/main/java/org/apache/jackrabbit/oak/plugins/blob/MarkSweepGarbageCollector.java#L188]
> [2] [https://github.com/apache/jackrabbit-oak/blob/trunk/oak-segment-tar/src/main/java/org/apache/jackrabbit/oak/segment/SegmentNodeStoreService.java#L690]
> [3] http://svn.apache.org/viewvc?rev=1811532&view=rev
>
--
This message was sent by Atlassian Jira
(v8.3.2#803003)