You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Benjamin Hindman <be...@berkeley.edu> on 2013/03/15 23:24:29 UTC

Review Request: Changed cleanup of processes to ensure arbitrary code outside of libprocess does not get executed when holding the ProcessManager's processes lock. In particular:

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9966/
-----------------------------------------------------------

Review request for mesos and Vinod Kone.


Description
-------

See summary.


Diffs
-----

  third_party/libprocess/src/process.cpp 49fb8a135f97c30c3b74c3a6b862a050d8edebf2 

Diff: https://reviews.apache.org/r/9966/diff/


Testing
-------

make check


Thanks,

Benjamin Hindman


Re: Review Request: Changed cleanup of processes to ensure arbitrary code outside of libprocess does not get executed when holding the ProcessManager's processes lock. In particular:

Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9966/#review18006
-----------------------------------------------------------

Ship it!



third_party/libprocess/src/process.cpp
<https://reviews.apache.org/r/9966/#comment38036>

    s/al/all/



third_party/libprocess/src/process.cpp
<https://reviews.apache.org/r/9966/#comment38039>

    ws
    


- Vinod Kone


On March 15, 2013, 10:24 p.m., Benjamin Hindman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9966/
> -----------------------------------------------------------
> 
> (Updated March 15, 2013, 10:24 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   third_party/libprocess/src/process.cpp 49fb8a135f97c30c3b74c3a6b862a050d8edebf2 
> 
> Diff: https://reviews.apache.org/r/9966/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Benjamin Hindman
> 
>