You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2020/07/29 07:17:38 UTC

[GitHub] [incubator-mxnet] Zha0q1 commented on a change in pull request #18813: [WIP ]Add Large Dim Checks for linalg Operators

Zha0q1 commented on a change in pull request #18813:
URL: https://github.com/apache/incubator-mxnet/pull/18813#discussion_r461933289



##########
File path: src/operator/linalg_impl.h
##########
@@ -39,6 +39,40 @@ inline void linalg_check_batch_size(int A, int B, int C) {
   CHECK_GT(A, 0) << "Zero batch size for arguments to linear algebra operator";
 }
 
+
+// this is int 32 max

Review comment:
       TODO: change to int_max in climit in next version




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org