You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by lshmouse <gi...@git.apache.org> on 2017/01/16 09:44:09 UTC
[GitHub] spark pull request #16602: SPARK-19238: Ignore sorting the edges if edges ar...
GitHub user lshmouse opened a pull request:
https://github.com/apache/spark/pull/16602
SPARK-19238: Ignore sorting the edges if edges are sorted when building edge partition
## What changes were proposed in this pull request?
Ignore sorting the edges if edges are sorted when building edge partition
Usually the graph edges generated by upstream application and saved by other graphs are sorted. So the sorting is not necessary.
## How was this patch tested?
unit tests
Please review http://spark.apache.org/contributing.html before opening a pull request.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/lshmouse/spark SPARK-19238
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/16602.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #16602
----
commit 12448e9bbe62b8b82280b2b0754997c1187a7851
Author: Liu Shaohui <li...@xiaomi.com>
Date: 2017-01-16T09:38:40Z
SPARK-19238: Ignore sorting the edges if edges are sorted when building edge partition
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #16602: [SPARK-19238][GRAPHX] Ignore sorting the edges if...
Posted by lshmouse <gi...@git.apache.org>.
Github user lshmouse closed the pull request at:
https://github.com/apache/spark/pull/16602
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #16602: [SPARK-19238][GRAPHX] Ignore sorting the edges if edges ...
Posted by lshmouse <gi...@git.apache.org>.
Github user lshmouse commented on the issue:
https://github.com/apache/spark/pull/16602
@srowen
After checking the implements of timsort, it has been optimized for sorted array.
Just ignore this PR. Thanks for your time.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #16602: [SPARK-19238][GRAPHX] Ignore sorting the edges if edges ...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16602
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #16602: [SPARK-19238][GRAPHX] Ignore sorting the edges if edges ...
Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/16602
Why is this faster than letting timsort figure out the array is sorted already? that's the key question. Because this adds an extra pass for any non-sorted data.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org