You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by je...@apache.org on 2022/09/26 22:29:28 UTC

[airflow] 02/03: Fix scroll overflow for ConfirmDialog (#26681)

This is an automated email from the ASF dual-hosted git repository.

jedcunningham pushed a commit to branch v2-4-test
in repository https://gitbox.apache.org/repos/asf/airflow.git

commit 2a320f1a6654c31569d860d994543ae4c05be4dc
Author: pierrejeambrun <pi...@gmail.com>
AuthorDate: Tue Sep 27 00:07:33 2022 +0200

    Fix scroll overflow for ConfirmDialog (#26681)
    
    (cherry picked from commit a83689935867b02fe1502e263f7dd1febff732ed)
---
 airflow/www/static/js/dag/details/ConfirmDialog.tsx | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/airflow/www/static/js/dag/details/ConfirmDialog.tsx b/airflow/www/static/js/dag/details/ConfirmDialog.tsx
index c2533579ff..b0a7441f99 100644
--- a/airflow/www/static/js/dag/details/ConfirmDialog.tsx
+++ b/airflow/www/static/js/dag/details/ConfirmDialog.tsx
@@ -47,6 +47,7 @@ const ConfirmDialog = ({
 }: Props) => {
   const initialFocusRef = useRef<HTMLButtonElement>(null);
   const containerRef = useContainerRef();
+
   return (
     <AlertDialog
       isOpen={isOpen}
@@ -58,12 +59,12 @@ const ConfirmDialog = ({
       blockScrollOnMount={false}
     >
       <AlertDialogOverlay>
-        <AlertDialogContent>
+        <AlertDialogContent maxHeight="90vh">
           <AlertDialogHeader fontSize="4xl" fontWeight="bold">
             {title}
           </AlertDialogHeader>
 
-          <AlertDialogBody>
+          <AlertDialogBody overflowY="auto">
             <Text mb={2}>{description}</Text>
             {Array.isArray(body) && body.map((ti) => (<Code key={ti} fontSize="lg">{ti}</Code>))}
           </AlertDialogBody>