You are viewing a plain text version of this content. The canonical link for it is here.
Posted to fop-commits@xmlgraphics.apache.org by je...@apache.org on 2005/01/17 19:59:50 UTC
cvs commit: xml-fop/src/java/org/apache/fop/layoutmgr BlockLayoutManager.java
jeremias 2005/01/17 10:59:50
Modified: src/java/org/apache/fop/layoutmgr BlockLayoutManager.java
Log:
Adding todo item for a static variable.
Revision Changes Path
1.37 +1 -4 xml-fop/src/java/org/apache/fop/layoutmgr/BlockLayoutManager.java
Index: BlockLayoutManager.java
===================================================================
RCS file: /home/cvs/xml-fop/src/java/org/apache/fop/layoutmgr/BlockLayoutManager.java,v
retrieving revision 1.36
retrieving revision 1.37
diff -u -r1.36 -r1.37
--- BlockLayoutManager.java 12 Jan 2005 12:03:00 -0000 1.36
+++ BlockLayoutManager.java 17 Jan 2005 18:59:50 -0000 1.37
@@ -22,13 +22,9 @@
import java.util.List;
import org.apache.fop.datatypes.PercentBase;
-import org.apache.fop.fo.FONode;
-import org.apache.fop.fo.FObj;
-import org.apache.fop.fo.properties.CommonMarginBlock;
import org.apache.fop.fonts.Font;
import org.apache.fop.area.Area;
import org.apache.fop.area.Block;
-import org.apache.fop.area.BlockParent;
import org.apache.fop.area.LineArea;
import org.apache.fop.traits.SpaceVal;
import org.apache.fop.traits.MinOptMax;
@@ -54,6 +50,7 @@
*/
private MinOptMax foBlockSpaceBefore = null;
// need to retain foBlockSpaceAfter from previous instantiation
+ //TODO this is very bad for multi-threading. fix me!
private static MinOptMax foBlockSpaceAfter = null;
private MinOptMax prevFoBlockSpaceAfter = null;
---------------------------------------------------------------------
To unsubscribe, e-mail: fop-cvs-unsubscribe@xml.apache.org
For additional commands, e-mail: fop-cvs-help@xml.apache.org
Re: cvs commit: xml-fop/src/java/org/apache/fop/layoutmgr BlockLayoutManager.java
Posted by Jeremias Maerki <de...@greenmail.ch>.
No problem. I stumbled upon it when I realized that I wasn't handling
space-before|after correctly in in-flow block-containers. I'll see if I
can do something about it.
On 17.01.2005 20:17:35 Glen Mazza wrote:
> Yes, I think that's my fault. I believe that was
> related to the space-before and space-after properties
> which I was trying (unsuccessfully) to fix. This is a
> very complex portion of the code.
Jeremias Maerki
Re: cvs commit: xml-fop/src/java/org/apache/fop/layoutmgr BlockLayoutManager.java
Posted by Glen Mazza <gr...@yahoo.com>.
Yes, I think that's my fault. I believe that was
related to the space-before and space-after properties
which I was trying (unsuccessfully) to fix. This is a
very complex portion of the code.
Glen
--- jeremias@apache.org wrote:
> jeremias 2005/01/17 10:59:50
>
> Modified: src/java/org/apache/fop/layoutmgr
> BlockLayoutManager.java
> Log:
> Adding todo item for a static variable.
>
> Revision Changes Path
> 1.37 +1 -4
>
xml-fop/src/java/org/apache/fop/layoutmgr/BlockLayoutManager.java
>
> Index: BlockLayoutManager.java
>
>
===================================================================
> RCS file:
>
/home/cvs/xml-fop/src/java/org/apache/fop/layoutmgr/BlockLayoutManager.java,v
> retrieving revision 1.36
> retrieving revision 1.37
> diff -u -r1.36 -r1.37
> --- BlockLayoutManager.java 12 Jan 2005 12:03:00
> -0000 1.36
> +++ BlockLayoutManager.java 17 Jan 2005 18:59:50
> -0000 1.37
> @@ -22,13 +22,9 @@
> import java.util.List;
>
> import org.apache.fop.datatypes.PercentBase;
> -import org.apache.fop.fo.FONode;
> -import org.apache.fop.fo.FObj;
> -import
> org.apache.fop.fo.properties.CommonMarginBlock;
> import org.apache.fop.fonts.Font;
> import org.apache.fop.area.Area;
> import org.apache.fop.area.Block;
> -import org.apache.fop.area.BlockParent;
> import org.apache.fop.area.LineArea;
> import org.apache.fop.traits.SpaceVal;
> import org.apache.fop.traits.MinOptMax;
> @@ -54,6 +50,7 @@
> */
> private MinOptMax foBlockSpaceBefore = null;
> // need to retain foBlockSpaceAfter from
> previous instantiation
> + //TODO this is very bad for multi-threading.
> fix me!
> private static MinOptMax foBlockSpaceAfter =
> null;
> private MinOptMax prevFoBlockSpaceAfter =
> null;
>
>
>
>
>
>
---------------------------------------------------------------------
> To unsubscribe, e-mail:
> fop-cvs-unsubscribe@xml.apache.org
> For additional commands, e-mail:
> fop-cvs-help@xml.apache.org
>
>