You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/04/09 11:03:54 UTC

[GitHub] [spark] HyukjinKwon commented on a change in pull request #28165: [SPARK-31392][SQL] Support CalendarInterval to be reflect to CalendarntervalType

HyukjinKwon commented on a change in pull request #28165: [SPARK-31392][SQL] Support CalendarInterval to be reflect to CalendarntervalType
URL: https://github.com/apache/spark/pull/28165#discussion_r406126976
 
 

 ##########
 File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/ScalaReflection.scala
 ##########
 @@ -700,6 +700,8 @@ object ScalaReflection extends ScalaReflection {
         Schema(TimestampType, nullable = true)
       case t if isSubtype(t, localTypeOf[java.time.LocalDate]) => Schema(DateType, nullable = true)
       case t if isSubtype(t, localTypeOf[java.sql.Date]) => Schema(DateType, nullable = true)
+      case t if isSubtype(t, localTypeOf[CalendarInterval]) =>
+        Schema(CalendarIntervalType, nullable = true)
 
 Review comment:
   Hey,
   
   > Since 3.0.0, we make CalendarInterval public ...
   
   Can we clarify which scope we want to change? According to your PR description, we should support read and write paths too, which I think we decided to don't implement.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org