You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by da...@apache.org on 2026/07/18 15:24:25 UTC

(camel) branch main updated: CAMEL-23959: camel-openai - Honor storeFullResponse in embeddings producer

This is an automated email from the ASF dual-hosted git repository.

davsclaus pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/camel.git


The following commit(s) were added to refs/heads/main by this push:
     new f969c46f57f0 CAMEL-23959: camel-openai - Honor storeFullResponse in embeddings producer
f969c46f57f0 is described below

commit f969c46f57f09e693f4d054cf1a801ae5184a332
Author: Claus Ibsen <cl...@gmail.com>
AuthorDate: Sat Jul 18 17:24:18 2026 +0200

    CAMEL-23959: camel-openai - Honor storeFullResponse in embeddings producer
    
    Co-Authored-By: Claude Opus 4.6 <no...@anthropic.com>
    
    The storeFullResponse option was silently ignored by the embeddings
    operation. Now stores the full CreateEmbeddingResponse in the
    CamelOpenAIResponse exchange property, consistent with the chat
    and audio transcription producers.
    
    Signed-off-by: Claus Ibsen <cl...@gmail.com>
    Co-authored-by: Claude Opus 4.6 <no...@anthropic.com>
---
 .../component/openai/OpenAIEmbeddingsProducer.java |  4 ++++
 .../component/openai/OpenAIEmbeddingsMockTest.java | 23 ++++++++++++++++++++++
 2 files changed, 27 insertions(+)

diff --git a/components/camel-ai/camel-openai/src/main/java/org/apache/camel/component/openai/OpenAIEmbeddingsProducer.java b/components/camel-ai/camel-openai/src/main/java/org/apache/camel/component/openai/OpenAIEmbeddingsProducer.java
index 26488e697f06..08035cae875f 100644
--- a/components/camel-ai/camel-openai/src/main/java/org/apache/camel/component/openai/OpenAIEmbeddingsProducer.java
+++ b/components/camel-ai/camel-openai/src/main/java/org/apache/camel/component/openai/OpenAIEmbeddingsProducer.java
@@ -103,6 +103,10 @@ public class OpenAIEmbeddingsProducer extends DefaultAsyncProducer {
         CreateEmbeddingResponse response = getEndpoint().getClient()
                 .embeddings().create(params);
 
+        if (config.isStoreFullResponse()) {
+            exchange.setProperty(OpenAIConstants.RESPONSE, response);
+        }
+
         // Extract embeddings
         List<List<Float>> embeddings = new ArrayList<>();
         for (Embedding embedding : response.data()) {
diff --git a/components/camel-ai/camel-openai/src/test/java/org/apache/camel/component/openai/OpenAIEmbeddingsMockTest.java b/components/camel-ai/camel-openai/src/test/java/org/apache/camel/component/openai/OpenAIEmbeddingsMockTest.java
index 6d2810e5bf90..2624517f3f2e 100644
--- a/components/camel-ai/camel-openai/src/test/java/org/apache/camel/component/openai/OpenAIEmbeddingsMockTest.java
+++ b/components/camel-ai/camel-openai/src/test/java/org/apache/camel/component/openai/OpenAIEmbeddingsMockTest.java
@@ -27,6 +27,7 @@ import org.junit.jupiter.api.extension.RegisterExtension;
 
 import static org.junit.jupiter.api.Assertions.assertEquals;
 import static org.junit.jupiter.api.Assertions.assertNotNull;
+import static org.junit.jupiter.api.Assertions.assertNull;
 import static org.junit.jupiter.api.Assertions.assertTrue;
 
 public class OpenAIEmbeddingsMockTest extends CamelTestSupport {
@@ -57,6 +58,10 @@ public class OpenAIEmbeddingsMockTest extends CamelTestSupport {
                 from("direct:embedding")
                         .to("openai:embeddings?embeddingModel=text-embedding-ada-002&apiKey=dummy&baseUrl="
                             + openAIMock.getBaseUrl() + "/v1");
+
+                from("direct:embedding-store-response")
+                        .to("openai:embeddings?embeddingModel=text-embedding-ada-002&apiKey=dummy&storeFullResponse=true&baseUrl="
+                            + openAIMock.getBaseUrl() + "/v1");
             }
         };
     }
@@ -173,4 +178,22 @@ public class OpenAIEmbeddingsMockTest extends CamelTestSupport {
         assertTrue(result.getMessage().getHeader(OpenAIConstants.PROMPT_TOKENS, Integer.class) > 0);
         assertTrue(result.getMessage().getHeader(OpenAIConstants.TOTAL_TOKENS, Integer.class) > 0);
     }
+
+    @Test
+    void storeFullResponseStoresEmbeddingResponse() {
+        Exchange result = template.request("direct:embedding-store-response",
+                e -> e.getIn().setBody("What is Apache Camel?"));
+
+        assertNotNull(result.getProperty(OpenAIConstants.RESPONSE),
+                "storeFullResponse=true must store the full response in the CamelOpenAIResponse exchange property");
+    }
+
+    @Test
+    void storeFullResponseDefaultDoesNotStoreResponse() {
+        Exchange result = template.request("direct:embedding",
+                e -> e.getIn().setBody("What is Apache Camel?"));
+
+        assertNull(result.getProperty(OpenAIConstants.RESPONSE),
+                "storeFullResponse defaults to false, so CamelOpenAIResponse should not be set");
+    }
 }