You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "ZhaoYang (JIRA)" <ji...@apache.org> on 2019/04/16 02:04:00 UTC
[jira] [Updated] (LUCENE-8765) OneDimensionBKDWriter valueCount
validation didn't include leafCount
[ https://issues.apache.org/jira/browse/LUCENE-8765?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
ZhaoYang updated LUCENE-8765:
-----------------------------
Description:
{{[OneDimensionBKDWriter#add|https://github.com/jasonstack/lucene-solr/blob/branch_7_5/lucene/core/src/java/org/apache/lucene/util/bkd/BKDWriter.java#L612]}} checks if {{valueCount}} exceeds predefined {{totalPointCount}}, but {{valueCount}} is only updated for every 1024({{DEFAULT_MAX_POINTS_IN_LEAF_NODE}}) points.
We should include {{leafCount}} for validation.
was:
{{OneDimensionBKDWriter#add}} checks if {{valueCount}} exceeds predefined {{totalPointCount}}, but {{valueCount}} is only updated for every 1024({{DEFAULT_MAX_POINTS_IN_LEAF_NODE}}) points.
We should include {{leafCount}} for validation.
> OneDimensionBKDWriter valueCount validation didn't include leafCount
> --------------------------------------------------------------------
>
> Key: LUCENE-8765
> URL: https://issues.apache.org/jira/browse/LUCENE-8765
> Project: Lucene - Core
> Issue Type: Bug
> Components: core/other
> Affects Versions: 7.5, master (9.0)
> Reporter: ZhaoYang
> Priority: Minor
> Attachments: 0001-Fix-OneDimensionBKDWriter-valueCount-validation.patch
>
>
> {{[OneDimensionBKDWriter#add|https://github.com/jasonstack/lucene-solr/blob/branch_7_5/lucene/core/src/java/org/apache/lucene/util/bkd/BKDWriter.java#L612]}} checks if {{valueCount}} exceeds predefined {{totalPointCount}}, but {{valueCount}} is only updated for every 1024({{DEFAULT_MAX_POINTS_IN_LEAF_NODE}}) points.
> We should include {{leafCount}} for validation.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org