You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Andrew Onischuk <ao...@hortonworks.com> on 2015/06/17 14:31:34 UTC

Review Request 35557: Recommended min and max for slider-config are equal

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35557/
-----------------------------------------------------------

Review request for Ambari and Srimanth Gunturi.


Bugs: AMBARI-11971
    https://issues.apache.org/jira/browse/AMBARI-11971


Repository: ambari


Description
-------

Change "Minimum Container Size (Memory)" to 2048 (maximum in my case)  
Result - "Map Memory" and "AppMaster Memory" changed to 2048. And their
attributes "min", "max" changed to the 2048 (both). So sliders become looks
like shown in the [^sliders.png].

See [^22.zip] - recommendations-log


Diffs
-----

  ambari-server/src/main/resources/stacks/HDP/2.2/services/stack_advisor.py 17ae78b 
  ambari-server/src/test/python/stacks/2.2/common/test_stack_advisor.py e242fce 

Diff: https://reviews.apache.org/r/35557/diff/


Testing
-------

mvn clean test


Thanks,

Andrew Onischuk


Re: Review Request 35557: Recommended min and max for slider-config are equal

Posted by Myroslav Papirkovskyy <mp...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35557/#review88994
-----------------------------------------------------------

Ship it!


Ship It!

- Myroslav Papirkovskyy


On Червень 23, 2015, 4:57 після полудня, Andrew Onischuk wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35557/
> -----------------------------------------------------------
> 
> (Updated Червень 23, 2015, 4:57 після полудня)
> 
> 
> Review request for Ambari and Srimanth Gunturi.
> 
> 
> Bugs: AMBARI-11971
>     https://issues.apache.org/jira/browse/AMBARI-11971
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Change "Minimum Container Size (Memory)" to 2048 (maximum in my case)  
> Result - "Map Memory" and "AppMaster Memory" changed to 2048. And their
> attributes "min", "max" changed to the 2048 (both). So sliders become looks
> like shown in the [^sliders.png].
> 
> See [^22.zip] - recommendations-log
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/stacks/HDP/2.2/services/stack_advisor.py e5b6adb 
>   ambari-server/src/test/python/stacks/2.2/common/test_stack_advisor.py 436d796 
> 
> Diff: https://reviews.apache.org/r/35557/diff/
> 
> 
> Testing
> -------
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Andrew Onischuk
> 
>


Re: Review Request 35557: Recommended min and max for slider-config are equal

Posted by Andrew Onischuk <ao...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35557/
-----------------------------------------------------------

(Updated June 23, 2015, 1:57 p.m.)


Review request for Ambari and Srimanth Gunturi.


Bugs: AMBARI-11971
    https://issues.apache.org/jira/browse/AMBARI-11971


Repository: ambari


Description
-------

Change "Minimum Container Size (Memory)" to 2048 (maximum in my case)  
Result - "Map Memory" and "AppMaster Memory" changed to 2048. And their
attributes "min", "max" changed to the 2048 (both). So sliders become looks
like shown in the [^sliders.png].

See [^22.zip] - recommendations-log


Diffs (updated)
-----

  ambari-server/src/main/resources/stacks/HDP/2.2/services/stack_advisor.py e5b6adb 
  ambari-server/src/test/python/stacks/2.2/common/test_stack_advisor.py 436d796 

Diff: https://reviews.apache.org/r/35557/diff/


Testing
-------

mvn clean test


Thanks,

Andrew Onischuk


Re: Review Request 35557: Recommended min and max for slider-config are equal

Posted by Andrew Onischuk <ao...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35557/#review88951
-----------------------------------------------------------

Ship it!


Ship It!

- Andrew Onischuk


On June 22, 2015, 4:40 p.m., Andrew Onischuk wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35557/
> -----------------------------------------------------------
> 
> (Updated June 22, 2015, 4:40 p.m.)
> 
> 
> Review request for Ambari and Srimanth Gunturi.
> 
> 
> Bugs: AMBARI-11971
>     https://issues.apache.org/jira/browse/AMBARI-11971
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Change "Minimum Container Size (Memory)" to 2048 (maximum in my case)  
> Result - "Map Memory" and "AppMaster Memory" changed to 2048. And their
> attributes "min", "max" changed to the 2048 (both). So sliders become looks
> like shown in the [^sliders.png].
> 
> See [^22.zip] - recommendations-log
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/stacks/HDP/2.2/services/stack_advisor.py 17ae78b 
>   ambari-server/src/test/python/stacks/2.2/common/test_stack_advisor.py e242fce 
> 
> Diff: https://reviews.apache.org/r/35557/diff/
> 
> 
> Testing
> -------
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Andrew Onischuk
> 
>


Re: Review Request 35557: Recommended min and max for slider-config are equal

Posted by Andrew Onischuk <ao...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35557/
-----------------------------------------------------------

(Updated June 22, 2015, 4:40 p.m.)


Review request for Ambari and Srimanth Gunturi.


Bugs: AMBARI-11971
    https://issues.apache.org/jira/browse/AMBARI-11971


Repository: ambari


Description
-------

Change "Minimum Container Size (Memory)" to 2048 (maximum in my case)  
Result - "Map Memory" and "AppMaster Memory" changed to 2048. And their
attributes "min", "max" changed to the 2048 (both). So sliders become looks
like shown in the [^sliders.png].

See [^22.zip] - recommendations-log


Diffs (updated)
-----

  ambari-server/src/main/resources/stacks/HDP/2.2/services/stack_advisor.py 17ae78b 
  ambari-server/src/test/python/stacks/2.2/common/test_stack_advisor.py e242fce 

Diff: https://reviews.apache.org/r/35557/diff/


Testing
-------

mvn clean test


Thanks,

Andrew Onischuk


Re: Review Request 35557: Recommended min and max for slider-config are equal

Posted by Srimanth Gunturi <sr...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35557/#review88258
-----------------------------------------------------------

Ship it!


Ship It!

- Srimanth Gunturi


On June 17, 2015, 12:31 p.m., Andrew Onischuk wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35557/
> -----------------------------------------------------------
> 
> (Updated June 17, 2015, 12:31 p.m.)
> 
> 
> Review request for Ambari and Srimanth Gunturi.
> 
> 
> Bugs: AMBARI-11971
>     https://issues.apache.org/jira/browse/AMBARI-11971
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Change "Minimum Container Size (Memory)" to 2048 (maximum in my case)  
> Result - "Map Memory" and "AppMaster Memory" changed to 2048. And their
> attributes "min", "max" changed to the 2048 (both). So sliders become looks
> like shown in the [^sliders.png].
> 
> See [^22.zip] - recommendations-log
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/stacks/HDP/2.2/services/stack_advisor.py 17ae78b 
>   ambari-server/src/test/python/stacks/2.2/common/test_stack_advisor.py e242fce 
> 
> Diff: https://reviews.apache.org/r/35557/diff/
> 
> 
> Testing
> -------
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Andrew Onischuk
> 
>


Re: Review Request 35557: Recommended min and max for slider-config are equal

Posted by Srimanth Gunturi <sr...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35557/#review88271
-----------------------------------------------------------


Please cancel my 'Shit It' vote.

Sorry, just realized that the following other configs also have to be capped by "yarn.scheduler.maximum-allocation-mb":
map.memory.mb, 
reduce.memory.mb, 
hive.tez.container.size, 
tez.am.resource.memory.mb, 
tez.task.resource.memory.mb

- Srimanth Gunturi


On June 17, 2015, 12:31 p.m., Andrew Onischuk wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35557/
> -----------------------------------------------------------
> 
> (Updated June 17, 2015, 12:31 p.m.)
> 
> 
> Review request for Ambari and Srimanth Gunturi.
> 
> 
> Bugs: AMBARI-11971
>     https://issues.apache.org/jira/browse/AMBARI-11971
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Change "Minimum Container Size (Memory)" to 2048 (maximum in my case)  
> Result - "Map Memory" and "AppMaster Memory" changed to 2048. And their
> attributes "min", "max" changed to the 2048 (both). So sliders become looks
> like shown in the [^sliders.png].
> 
> See [^22.zip] - recommendations-log
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/stacks/HDP/2.2/services/stack_advisor.py 17ae78b 
>   ambari-server/src/test/python/stacks/2.2/common/test_stack_advisor.py e242fce 
> 
> Diff: https://reviews.apache.org/r/35557/diff/
> 
> 
> Testing
> -------
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Andrew Onischuk
> 
>