You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@spamassassin.apache.org by jm...@apache.org on 2010/03/02 11:49:57 UTC

svn commit: r917952 - /spamassassin/trunk/lib/Mail/SpamAssassin/SpamdForkScaling.pm

Author: jm
Date: Tue Mar  2 10:49:56 2010
New Revision: 917952

URL: http://svn.apache.org/viewvc?rev=917952&view=rev
Log:
bug 6356: work around win32 perl bug with pack('N') by
switching to pack('l')

Modified:
    spamassassin/trunk/lib/Mail/SpamAssassin/SpamdForkScaling.pm

Modified: spamassassin/trunk/lib/Mail/SpamAssassin/SpamdForkScaling.pm
URL: http://svn.apache.org/viewvc/spamassassin/trunk/lib/Mail/SpamAssassin/SpamdForkScaling.pm?rev=917952&r1=917951&r2=917952&view=diff
==============================================================================
--- spamassassin/trunk/lib/Mail/SpamAssassin/SpamdForkScaling.pm (original)
+++ spamassassin/trunk/lib/Mail/SpamAssassin/SpamdForkScaling.pm Tue Mar  2 10:49:56 2010
@@ -447,12 +447,12 @@
 
   chomp $line;
   if ($line =~ s/^I//) {
-    my $pid = unpack("N1", $line);
+    my $pid = unpack("l1", $line);      # signed, as 'N' causes win32 bugs (bug 6356)
     $self->set_child_state ($pid, PFSTATE_IDLE);
     return PFSTATE_IDLE;
   }
   elsif ($line =~ s/^B//) {
-    my $pid = unpack("N1", $line);
+    my $pid = unpack("l1", $line);
     $self->set_child_state ($pid, PFSTATE_BUSY);
     return PFSTATE_BUSY;
   }
@@ -562,13 +562,13 @@
 sub update_child_status_idle {
   my ($self) = @_;
   # "I  b1 b2 b3 b4 \n "
-  $self->report_backchannel_socket("I".pack("N",$self->{pid})."\n");
+  $self->report_backchannel_socket("I".pack("l",$self->{pid})."\n");
 }
 
 sub update_child_status_busy {
   my ($self) = @_;
   # "B  b1 b2 b3 b4 \n "
-  $self->report_backchannel_socket("B".pack("N",$self->{pid})."\n");
+  $self->report_backchannel_socket("B".pack("l",$self->{pid})."\n");
 }
 
 sub report_backchannel_socket {