You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@isis.apache.org by ah...@apache.org on 2022/04/26 10:37:10 UTC
[isis] branch master updated: ISIS-3026: do not expose property-ids as css classes
This is an automated email from the ASF dual-hosted git repository.
ahuber pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/isis.git
The following commit(s) were added to refs/heads/master by this push:
new d9b078199c ISIS-3026: do not expose property-ids as css classes
d9b078199c is described below
commit d9b078199c47479fc4be7d35e486cc4a62667979
Author: Andi Huber <ah...@apache.org>
AuthorDate: Tue Apr 26 12:37:03 2022 +0200
ISIS-3026: do not expose property-ids as css classes
- CSS class name clashes are likely
---
.../wicket/ui/components/entity/fieldset/PropertyGroup.java | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/viewers/wicket/ui/src/main/java/org/apache/isis/viewer/wicket/ui/components/entity/fieldset/PropertyGroup.java b/viewers/wicket/ui/src/main/java/org/apache/isis/viewer/wicket/ui/components/entity/fieldset/PropertyGroup.java
index 2d651392d9..55684c3e54 100644
--- a/viewers/wicket/ui/src/main/java/org/apache/isis/viewer/wicket/ui/components/entity/fieldset/PropertyGroup.java
+++ b/viewers/wicket/ui/src/main/java/org/apache/isis/viewer/wicket/ui/components/entity/fieldset/PropertyGroup.java
@@ -22,7 +22,6 @@ import java.util.List;
import java.util.function.Consumer;
import org.apache.wicket.Component;
-import org.apache.wicket.MarkupContainer;
import org.apache.wicket.markup.html.WebMarkupContainer;
import org.apache.wicket.markup.repeater.RepeatingView;
@@ -191,9 +190,10 @@ public class PropertyGroup extends PanelAbstract<ManagedObject, EntityModel> imp
final Component scalarNameAndValueComponent = getComponentFactoryRegistry()
.addOrReplaceComponent(container, ID_PROPERTY, ComponentType.SCALAR_NAME_AND_VALUE, scalarModel);
- if(scalarNameAndValueComponent instanceof MarkupContainer) {
- Wkt.cssAppend(scalarNameAndValueComponent, scalarModel.getIdentifier());
- }
+//XXX[ISIS-3026] this is a bad idea
+// if(scalarNameAndValueComponent instanceof MarkupContainer) {
+// Wkt.cssAppend(scalarNameAndValueComponent, scalarModel.getIdentifier());
+// }
val entity = entityModel.getManagedObject();