You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@xtable.apache.org by "rangareddy (via GitHub)" <gi...@apache.org> on 2024/09/17 13:42:00 UTC

[PR] [532] Add DISCLAIMER file to META-INF folder in jars [incubator-xtable]

rangareddy opened a new pull request, #539:
URL: https://github.com/apache/incubator-xtable/pull/539

   ## *Important Read*
   
   This pull request aims to address issues [#532](https://github.com/apache/incubator-xtable/issues/532)
   
   ## What is the purpose of the pull request
   
   Adding the DISCLAIMER file to META-INF folders in all jars.
   
   ## Brief change log
   
   * Added the `<resourceBundles>` to the `maven-remote-resources-plugin` plugin in pom.xml file.
   
   ```xml
   <resourceBundles>
   	<resourceBundle>org.apache:apache-jar-resource-bundle:1.4</resourceBundle>
   	<resourceBundle>org.apache.apache.resources:apache-incubator-disclaimer-resource-bundle:1.2-SNAPSHOT</resourceBundle>
   </resourceBundles>
   ```
   
   * Added `DISCLAIMER` file
   
   ## Verify this pull request
   
   Run `$ mvn clean install -DskipTests -U` locally and extract the jars and verify `META-INF` folder.
   
   **META-INF folder before this PR:**
   
   ```sh
   % ls -ltr META-INF 
   total 48
   drwxr-xr-x  3 rangareddy  staff     96 Jul  4 18:52 maven
   -rw-r--r--  1 rangareddy  staff    176 Jul  4 18:52 NOTICE
   -rw-r--r--  1 rangareddy  staff    341 Jul  4 18:52 MANIFEST.MF
   -rw-r--r--  1 rangareddy  staff  11358 Jul  4 18:52 LICENSE
   -rw-r--r--  1 rangareddy  staff   1942 Jul  4 18:52 DEPENDENCIES
   ```
   
   **META-INF folder after this PR:**
   
   ```sh
   % ls -ltr META-INF
   total 56
   drwxr-xr-x  3 rangareddy  staff     96 Jul  4 18:52 maven
   -rw-r--r--  1 rangareddy  staff    179 Jul  4 18:52 NOTICE
   -rw-r--r--  1 rangareddy  staff    341 Jul  4 18:52 MANIFEST.MF
   -rw-r--r--  1 rangareddy  staff  11358 Jul  4 18:52 LICENSE
   -rw-r--r--  1 rangareddy  staff    559 Jul  4 18:52 DISCLAIMER
   -rw-r--r--  1 rangareddy  staff   1942 Jul  4 18:52 DEPENDENCIES
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@xtable.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [532] Add DISCLAIMER file to META-INF folder in jars [incubator-xtable]

Posted by "vinishjail97 (via GitHub)" <gi...@apache.org>.
vinishjail97 commented on PR #539:
URL: https://github.com/apache/incubator-xtable/pull/539#issuecomment-2357968283

   > I think you should add DISCLAIMER-WIP to the jar instead of DISCLAIMER while the project uses the DISCLAIMER-WIP and change to DISCLAIMER when the project switches to DISCLAIMER. The exact same file that you have in the project - not some other file.
   
   I had the same doubt but the resource bundle provided by Apache for incubating projects doesn't have that ability.
   https://maven.apache.org/apache-resource-bundles/incubator-disclaimer/ 
   https://github.com/apache/maven-apache-resources/blob/master/incubator-disclaimer/src/main/resources/META-INF/DISCLAIMER.vm 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@xtable.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [532] Add DISCLAIMER file to META-INF folder in jars [incubator-xtable]

Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on PR #539:
URL: https://github.com/apache/incubator-xtable/pull/539#issuecomment-2357921328

   I think you should add DISCLAIMER-WIP to the jar instead of DISCLAIMER while the project uses the DISCLAIMER-WIP and change to DISCLAIMER when the project switches to DISCLAIMER.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@xtable.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [532] Add DISCLAIMER file to META-INF folder in jars [incubator-xtable]

Posted by "vinishjail97 (via GitHub)" <gi...@apache.org>.
vinishjail97 commented on code in PR #539:
URL: https://github.com/apache/incubator-xtable/pull/539#discussion_r1763322805


##########
DISCLAIMER:
##########
@@ -0,0 +1,10 @@
+Apache XTable™ (Incubating) is an effort undergoing incubation at the Apache Software
+Foundation (ASF), sponsored by the Apache Incubator PMC.
+
+Incubation is required of all newly accepted projects until a further review

Review Comment:
   @rangareddy Please remove this, xtable used DISCLAIMER-WIP file and we need to include this file as part of META-INF/ 
   
   https://github.com/apache/incubator-xtable/blob/main/DISCLAIMER-WIP 



##########
pom.xml:
##########
@@ -570,6 +570,10 @@
                             <properties>
                                 <projectName>Apache XTable (incubating)</projectName>
                             </properties>
+                            <resourceBundles>
+                                <resourceBundle>org.apache:apache-jar-resource-bundle:1.4</resourceBundle>
+                                <resourceBundle>org.apache.apache.resources:apache-incubator-disclaimer-resource-bundle:1.2-SNAPSHOT</resourceBundle>

Review Comment:
   Can we use versions available from maven ? 
   
   https://mvnrepository.com/artifact/org.apache/apache-incubator-disclaimer-resource-bundle 
   
   Also can you include the version in properties ? 
   https://github.com/apache/incubator-xtable/blob/main/pom.xml#L56 
   
   `<apache-incubator-disclaimer-resource-bundle.version>1.1</apache-incubator-disclaimer-resource-bundle.version>` Something like this ? 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@xtable.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [532] Add DISCLAIMER file to META-INF folder in jars [incubator-xtable]

Posted by "rangareddy (via GitHub)" <gi...@apache.org>.
rangareddy commented on code in PR #539:
URL: https://github.com/apache/incubator-xtable/pull/539#discussion_r1764380452


##########
DISCLAIMER:
##########
@@ -0,0 +1,10 @@
+Apache XTable™ (Incubating) is an effort undergoing incubation at the Apache Software
+Foundation (ASF), sponsored by the Apache Incubator PMC.
+
+Incubation is required of all newly accepted projects until a further review

Review Comment:
   DISCLAIMER file automatically generated by using following template: 
   
   https://github.com/apache/maven-apache-resources/blob/apache-resource-bundles-1.7/incubator-disclaimer/src/main/resources/META-INF/DISCLAIMER.vm
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@xtable.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [532] Add DISCLAIMER file to META-INF folder in jars [incubator-xtable]

Posted by "rangareddy (via GitHub)" <gi...@apache.org>.
rangareddy commented on code in PR #539:
URL: https://github.com/apache/incubator-xtable/pull/539#discussion_r1764366086


##########
pom.xml:
##########
@@ -570,6 +570,10 @@
                             <properties>
                                 <projectName>Apache XTable (incubating)</projectName>
                             </properties>
+                            <resourceBundles>
+                                <resourceBundle>org.apache:apache-jar-resource-bundle:1.4</resourceBundle>
+                                <resourceBundle>org.apache.apache.resources:apache-incubator-disclaimer-resource-bundle:1.2-SNAPSHOT</resourceBundle>

Review Comment:
   The below artifacts are old and it is last updated on Mar 08, 2007. 
   https://mvnrepository.com/artifact/org.apache/apache-incubator-disclaimer-resource-bundle
   
   You can refer following article for latest artifacts for various apache resource bundles.
   
   - https://maven.apache.org/apache-resource-bundles/index.html
   - https://maven.apache.org/apache-resource-bundles/incubator-disclaimer/ 
   - https://mvnrepository.com/artifact/org.apache.apache.resources



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@xtable.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [532] Add DISCLAIMER file to META-INF folder in jars [incubator-xtable]

Posted by "vinishjail97 (via GitHub)" <gi...@apache.org>.
vinishjail97 commented on PR #539:
URL: https://github.com/apache/incubator-xtable/pull/539#issuecomment-2357650599

   cat META-INF/DISCLAIMER 
   ```
   Apache XTable (incubating) is an effort undergoing incubation at the Apache Software 
   Foundation (ASF), sponsored by the Apache Incubator PMC. 
   
   Incubation is required of all newly accepted projects until a further review 
   indicates that the infrastructure, communications, and decision making process 
   have stabilized in a manner consistent with other successful ASF projects. 
   
   While incubation status is not necessarily a reflection of the completeness 
   or stability of the code, it does indicate that the project has yet to be 
   fully endorsed by the ASF.
   ```
   
   @pjfanning Can you confirm if this looks okay ? We are still keeping DISCLAIMER-WIP in the project though. 
   
   
   
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@xtable.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [532] Add DISCLAIMER file to META-INF folder in jars [incubator-xtable]

Posted by "rangareddy (via GitHub)" <gi...@apache.org>.
rangareddy commented on PR #539:
URL: https://github.com/apache/incubator-xtable/pull/539#issuecomment-2357484492

   Hi @vinishjail97 Review the latest commit changes.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@xtable.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [532] Add DISCLAIMER file to META-INF folder in jars [incubator-xtable]

Posted by "vinishjail97 (via GitHub)" <gi...@apache.org>.
vinishjail97 merged PR #539:
URL: https://github.com/apache/incubator-xtable/pull/539


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@xtable.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [532] Add DISCLAIMER file to META-INF folder in jars [incubator-xtable]

Posted by "vinishjail97 (via GitHub)" <gi...@apache.org>.
vinishjail97 commented on PR #539:
URL: https://github.com/apache/incubator-xtable/pull/539#issuecomment-2357651745

   @rangareddy We can merge after @pjfanning gives an approval as well. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@xtable.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org