You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Jie Yu <yu...@gmail.com> on 2015/11/13 03:15:34 UTC
Review Request 40274: Fixed a few conditional guard issues in
src/Makefile.am.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40274/
-----------------------------------------------------------
Review request for mesos, Ben Mahler and Vinod Kone.
Repository: mesos
Description
-------
Fixed a few conditional guard issues in src/Makefile.am.
Diffs
-----
src/Makefile.am 09c3d8cb3bcdaca7a061574646da8f51cc2c1698
Diff: https://reviews.apache.org/r/40274/diff/
Testing
-------
make distcheck
Thanks,
Jie Yu
Re: Review Request 40274: Fixed a few conditional guard issues in
src/Makefile.am.
Posted by Jie Yu <yu...@gmail.com>.
> On Nov. 13, 2015, 11:22 p.m., Vinod Kone wrote:
> > src/Makefile.am, line 970
> > <https://reviews.apache.org/r/40274/diff/1/?file=1124771#file1124771line970>
> >
> > why not merge this with above?
I want to separate headers/sources like we did for libmesos_la
- Jie
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40274/#review106524
-----------------------------------------------------------
On Nov. 13, 2015, 2:16 a.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40274/
> -----------------------------------------------------------
>
> (Updated Nov. 13, 2015, 2:16 a.m.)
>
>
> Review request for mesos, Ben Mahler and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Fixed a few conditional guard issues in src/Makefile.am.
>
> THis fixed a few small issues in the original file. For example, we didn't set EXTRA_DIST correctly.
>
>
> Diffs
> -----
>
> src/Makefile.am 09c3d8cb3bcdaca7a061574646da8f51cc2c1698
>
> Diff: https://reviews.apache.org/r/40274/diff/
>
>
> Testing
> -------
>
> make distcheck
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 40274: Fixed a few conditional guard issues in
src/Makefile.am.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40274/#review106524
-----------------------------------------------------------
Ship it!
src/Makefile.am (line 788)
<https://reviews.apache.org/r/40274/#comment165228>
why not merge this with above?
- Vinod Kone
On Nov. 13, 2015, 2:16 a.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40274/
> -----------------------------------------------------------
>
> (Updated Nov. 13, 2015, 2:16 a.m.)
>
>
> Review request for mesos, Ben Mahler and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Fixed a few conditional guard issues in src/Makefile.am.
>
> THis fixed a few small issues in the original file. For example, we didn't set EXTRA_DIST correctly.
>
>
> Diffs
> -----
>
> src/Makefile.am 09c3d8cb3bcdaca7a061574646da8f51cc2c1698
>
> Diff: https://reviews.apache.org/r/40274/diff/
>
>
> Testing
> -------
>
> make distcheck
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 40274: Fixed a few conditional guard issues in
src/Makefile.am.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40274/
-----------------------------------------------------------
(Updated Nov. 13, 2015, 2:16 a.m.)
Review request for mesos, Ben Mahler and Vinod Kone.
Repository: mesos
Description (updated)
-------
Fixed a few conditional guard issues in src/Makefile.am.
THis fixed a few small issues in the original file. For example, we didn't set EXTRA_DIST correctly.
Diffs
-----
src/Makefile.am 09c3d8cb3bcdaca7a061574646da8f51cc2c1698
Diff: https://reviews.apache.org/r/40274/diff/
Testing
-------
make distcheck
Thanks,
Jie Yu